Skip to content

The flat adapter declares dummy dims with the unit's own module parameters without importing them #18

Description

@chenyueqi

mean_adv's w_term_ma_zt_lhs takes weights_zt2zm(ngrdcol,nzm,t_above:t_below) where t_above = 1, t_below = 2 are private parameters of the same module. The generated adapter declares real(8), intent(in) :: weights_zt2zm(ngrdcol, nzm, t_below) and f2py's C emits weights_zt2zm_Dims[2]=t_below, which fails to compile (use of undeclared identifier 't_below'). The plan should fold a parameter of the unit (or of a constants module) in a declared bound to its value, or the adapter should use <unit>, only: t_below -- and a non-unit lower bound (t_above:t_below) should become an extent, not the upper-bound name.

Found 2026-09-03 running the recast-clubb extension's tier-0 units (CLUBB_core of larson-group/clubb_release at 8ab3902, double precision, statistics off).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:flattenflat adapters for derived-type interfaces (flatten, recorder, plans)bugSomething isn't workingfixed-in-prfixed on a branch, awaiting the PR's mergefound-by:clubbsurfaced by the recast-clubb extension on CLUBB_core

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions