From a1621729498459999f74a401f51d769f719984a9 Mon Sep 17 00:00:00 2001 From: Samwalton9 Date: Sun, 11 Oct 2026 16:19:55 +0100 Subject: [PATCH] Make SuggestionMergeViewTests upvoter setup deterministic Secondary suggestions were assigned an author/upvoter via random.choice, so ~1/32 of runs picked the coordinator every time and test_merge_partner_suggestion_view_post failed with 1 != 2. Cycle through the editor and coordinator instead so both are always used. Bug: T440812 Co-Authored-By: Claude Opus 5.5 --- TWLight/resources/tests.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/TWLight/resources/tests.py b/TWLight/resources/tests.py index e035cc078b..3871497d81 100644 --- a/TWLight/resources/tests.py +++ b/TWLight/resources/tests.py @@ -1383,8 +1383,12 @@ def setUpTestData(cls): SuggestionFactory(company_url=random.choice(cls.company_urls)) for _ in range(cls.suggestion_merge_count) ] - for suggestion in cls.secondary_suggestions: - upvoter_or_author = random.choice(cls.upvoters_or_authors) + # Cycle through upvoters/authors so each is used at least once, + # keeping the merged upvoter count deterministic. + for i, suggestion in enumerate(cls.secondary_suggestions): + upvoter_or_author = cls.upvoters_or_authors[ + i % len(cls.upvoters_or_authors) + ] suggestion.author = upvoter_or_author.user suggestion.upvoted_users.add(upvoter_or_author.user) suggestion.save()