diff --git a/TWLight/resources/tests.py b/TWLight/resources/tests.py index e035cc078b..3871497d81 100644 --- a/TWLight/resources/tests.py +++ b/TWLight/resources/tests.py @@ -1383,8 +1383,12 @@ def setUpTestData(cls): SuggestionFactory(company_url=random.choice(cls.company_urls)) for _ in range(cls.suggestion_merge_count) ] - for suggestion in cls.secondary_suggestions: - upvoter_or_author = random.choice(cls.upvoters_or_authors) + # Cycle through upvoters/authors so each is used at least once, + # keeping the merged upvoter count deterministic. + for i, suggestion in enumerate(cls.secondary_suggestions): + upvoter_or_author = cls.upvoters_or_authors[ + i % len(cls.upvoters_or_authors) + ] suggestion.author = upvoter_or_author.user suggestion.upvoted_users.add(upvoter_or_author.user) suggestion.save()