From 7b2f0b3178fe4bc3a7a1d9595a8e2a42e96ad008 Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Fri, 6 Nov 2026 16:22:01 -0800 Subject: [PATCH] Fix removal of team review request The review assignment script attempted to remove the binaryen-reviewers team review request after selecting a particular team member to assign the review to. But the API call to remove the request was missing the required `reviewers` field. Fix it. --- scripts/assign_reviewer.py | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/scripts/assign_reviewer.py b/scripts/assign_reviewer.py index 77ea8477d59..e1cfe54abee 100755 --- a/scripts/assign_reviewer.py +++ b/scripts/assign_reviewer.py @@ -310,20 +310,15 @@ def main() -> None: if n['requestedReviewer'] ) if team_requested: - try: - gh_api([ - '--method', - 'DELETE', - f'repos/{owner}/{name}/pulls/{pr_number}/requested_reviewers', - '-f', - f'team_reviewers[]={TEAM_SLUG}', - ]) - except subprocess.CalledProcessError as e: - detail = e.stderr.strip() if e.stderr else str(e) - print( - f'Note: could not remove team review request: {detail}', - file=sys.stderr, - ) + gh_api([ + '--method', + 'DELETE', + f'repos/{owner}/{name}/pulls/{pr_number}/requested_reviewers', + '-f', + 'reviewers[]', + '-f', + f'team_reviewers[]={TEAM_SLUG}', + ]) if __name__ == '__main__':