From 2cf60f6706da15487221259601705908e08ad17a Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 26 Jul 2026 11:50:31 -0700 Subject: [PATCH 1/9] Update generate-messages workflow to use the pull request branch even if it's on a forked project --- .github/workflows/generate-messages.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/generate-messages.yml b/.github/workflows/generate-messages.yml index 3b017868e6f..1d560a134b6 100644 --- a/.github/workflows/generate-messages.yml +++ b/.github/workflows/generate-messages.yml @@ -13,7 +13,8 @@ jobs: steps: - uses: actions/checkout@v6 with: - ref: ${{ github.head_ref || github.ref_name }} + repository: ${{ github.event.pull_request.head.repo.full_name }} + ref: ${{ github.event.pull_request.head.ref }} fetch-depth: 0 - uses: actions/checkout@v6 - name: Use Node.js ${{ matrix.node-version }} @@ -35,8 +36,8 @@ jobs: else echo "NO_CHANGES=false" >> $GITHUB_ENV fi - - name: Commit messages - if: env.NO_CHANGES == 'false' + - name: Commit messages to main project + if: env.NO_CHANGES == 'false' && github.event.pull_request.head.repo.full_name == github.repository run: | git config --global user.name 'github-actions[bot]' git config --global user.email 'github-actions[bot]@users.noreply.github.com' @@ -45,3 +46,8 @@ jobs: git push env: GITHUB_TOKEN: ${{ secrets.token }} + - name: Verify messages are up to date on forked project + if: env.NO_CHANGES == 'false' && github.event.pull_request.head.repo.full_name != github.repository + run: | + echo "Error: src/messages.xlf is out of date. Run 'npm run extract-i18n' and commit the updated file." + exit 1 From a89261442c3df5f127c66c33ec102d9e20c27011 Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 26 Jul 2026 11:51:35 -0700 Subject: [PATCH 2/9] Fixed mistakes in generate-messages workflow --- .github/workflows/generate-messages.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/generate-messages.yml b/.github/workflows/generate-messages.yml index 1d560a134b6..769dc97502f 100644 --- a/.github/workflows/generate-messages.yml +++ b/.github/workflows/generate-messages.yml @@ -16,9 +16,8 @@ jobs: repository: ${{ github.event.pull_request.head.repo.full_name }} ref: ${{ github.event.pull_request.head.ref }} fetch-depth: 0 - - uses: actions/checkout@v6 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/checkout@v6 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - name: Install dependencies @@ -30,8 +29,7 @@ jobs: - name: Check for changes id: check-changes run: | - DIFF=$(git diff ${{ github.head_ref || github.ref_name }}) - if [ -z "$DIFF" ]; then + if git diff --quiet src/messages.xlf; then echo "NO_CHANGES=true" >> $GITHUB_ENV else echo "NO_CHANGES=false" >> $GITHUB_ENV From 9b6c14461542290d89df3c54e898c4a785279780 Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 26 Jul 2026 11:52:31 -0700 Subject: [PATCH 3/9] Temporarily set generate-messages on non-develop branch PRs to use the updated workflow --- .github/workflows/other-branch-workflows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/other-branch-workflows.yml b/.github/workflows/other-branch-workflows.yml index dadec561bfa..8444cc17c1e 100644 --- a/.github/workflows/other-branch-workflows.yml +++ b/.github/workflows/other-branch-workflows.yml @@ -14,6 +14,6 @@ jobs: generate-messages: needs: test-coverage - uses: WISE-Community/WISE-Client/.github/workflows/generate-messages.yml@develop + uses: WISE-Community/WISE-Client/.github/workflows/generate-messages.yml@actions-fails-on-fork secrets: token: ${{ secrets.GITHUB_TOKEN }} From 51ef9cfb197b1934138a10b772cb68b739e0b690 Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Thu, 6 Aug 2026 12:40:23 -0700 Subject: [PATCH 4/9] Removed unused secret --- .github/workflows/other-branch-workflows.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/other-branch-workflows.yml b/.github/workflows/other-branch-workflows.yml index 8444cc17c1e..00ba32696e5 100644 --- a/.github/workflows/other-branch-workflows.yml +++ b/.github/workflows/other-branch-workflows.yml @@ -9,8 +9,6 @@ on: jobs: test-coverage: uses: WISE-Community/WISE-Client/.github/workflows/test-coverage.yml@develop - secrets: - test_reporter: ${{secrets.CC_TEST_REPORTER_ID}} generate-messages: needs: test-coverage From 74defb2a2e8714d2dee5d301743070d872870dfd Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 9 Aug 2026 13:39:10 -0700 Subject: [PATCH 5/9] Fixed possible typo in node-version declaration --- .github/workflows/generate-messages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/generate-messages.yml b/.github/workflows/generate-messages.yml index 769dc97502f..92499e7a695 100644 --- a/.github/workflows/generate-messages.yml +++ b/.github/workflows/generate-messages.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-versions: [24.x] + node-version: [24.x] steps: - uses: actions/checkout@v6 with: From 01cb7f2169c6e801e564a5f6b4fc26c60c16a149 Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 9 Aug 2026 13:39:38 -0700 Subject: [PATCH 6/9] Use setup-node v6 --- .github/workflows/generate-messages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/generate-messages.yml b/.github/workflows/generate-messages.yml index 92499e7a695..518a832ca5c 100644 --- a/.github/workflows/generate-messages.yml +++ b/.github/workflows/generate-messages.yml @@ -17,7 +17,7 @@ jobs: ref: ${{ github.event.pull_request.head.ref }} fetch-depth: 0 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 + uses: actions/setup-node@v6 with: node-version: ${{ matrix.node-version }} - name: Install dependencies From b0cfe76632c4c1a5eb5c1a90e3102aa1cdb0e947 Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 9 Aug 2026 13:52:52 -0700 Subject: [PATCH 7/9] Added removed secret back --- .github/workflows/other-branch-workflows.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/other-branch-workflows.yml b/.github/workflows/other-branch-workflows.yml index 00ba32696e5..083b190b984 100644 --- a/.github/workflows/other-branch-workflows.yml +++ b/.github/workflows/other-branch-workflows.yml @@ -2,13 +2,13 @@ name: Non-develop branch PR workflows on: pull_request: branches: - - '*' - - '*/*' - '**' - '!develop' jobs: test-coverage: uses: WISE-Community/WISE-Client/.github/workflows/test-coverage.yml@develop + secrets: + test_reporter: ${{ secrets.CC_TEST_REPORTER_ID }} generate-messages: needs: test-coverage From d6ae73e57207234680fb6d7b690ea874c99d9a72 Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 9 Aug 2026 13:59:57 -0700 Subject: [PATCH 8/9] Removed secret again --- .github/workflows/other-branch-workflows.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/other-branch-workflows.yml b/.github/workflows/other-branch-workflows.yml index 083b190b984..e2a23e0084e 100644 --- a/.github/workflows/other-branch-workflows.yml +++ b/.github/workflows/other-branch-workflows.yml @@ -7,8 +7,6 @@ on: jobs: test-coverage: uses: WISE-Community/WISE-Client/.github/workflows/test-coverage.yml@develop - secrets: - test_reporter: ${{ secrets.CC_TEST_REPORTER_ID }} generate-messages: needs: test-coverage From 97ed681c3f2c9a24bb449f9c6d9747b80a4740dd Mon Sep 17 00:00:00 2001 From: Aaron Detre Date: Sun, 9 Aug 2026 14:32:10 -0700 Subject: [PATCH 9/9] Use develop version of generate-messages.yml --- .github/workflows/other-branch-workflows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/other-branch-workflows.yml b/.github/workflows/other-branch-workflows.yml index e2a23e0084e..b57c593919a 100644 --- a/.github/workflows/other-branch-workflows.yml +++ b/.github/workflows/other-branch-workflows.yml @@ -10,6 +10,6 @@ jobs: generate-messages: needs: test-coverage - uses: WISE-Community/WISE-Client/.github/workflows/generate-messages.yml@actions-fails-on-fork + uses: WISE-Community/WISE-Client/.github/workflows/generate-messages.yml@develop secrets: token: ${{ secrets.GITHUB_TOKEN }}