Repository navigation
Commit ab4234e
committed
fix: stop a discarded UnifiedBootstrap from clearing the world being created
Every NetworkManager that starts a hybrid session creates a UnifiedBootstrap that is then
discarded, and its finalizer cleared the static LastCreatedWorld and Instance from the GC
finalizer thread. When one ran while another session was starting, Initialize found its new
world null, logged "World is null!" and returned false: the NetworkManager had no world, its
transport threw a NullReferenceException on start, and the created world was never disposed.
The finalizer is removed and Initialize checks the world it created rather than the static.1 parent a49ad61 commit ab4234e
1 file changed
Lines changed: 6 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
| 75 | + | |
75 | 76 | | |
76 | | - | |
| 77 | + | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
83 | | - | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
89 | 90 | | |
90 | 91 | | |
91 | 92 | | |
92 | | - | |
| 93 | + | |
93 | 94 | | |
94 | 95 | | |
95 | | - | |
| 96 | + | |
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | 136 | | |
142 | 137 | | |
143 | 138 | | |
0 commit comments