test: testproject hybrid integration tests - 1st pass (#4175)

* test: opt testproject integration tests into hybrid prefab mode

Opts in RpcTestsAutomated, RpcUserSerializableTypesTest, DontDestroyOnLoadTests, SenderIdTests,
NetworkObjectSpawning, RpcObserverTests and NetworkObjectDestroyWithSceneTests.

Hybrid cases that hit a known limitation are skipped: a client shutting down disposes every world
in the process (SenderIdTests, RpcObserverTests), in-scene placed NetworkObjects are not supported
(NetworkObjectSpawning.SpawnOnSynchronizedNotification), and InstantiateAndSpawn does not select the
NetworkManager's world before instantiating a hybrid prefab (NetworkObjectSpawning.InstantiateAndSpawn).

Removes the unified fixtures from PrefabExtendedTests, NetworkBehaviourSessionSynchronized,
RespawnInSceneObjectsAfterShutdown, SceneObjectsNotDestroyedOnShutdownTest and
ServerDisconnectsClientTest, which depend on in-scene placed NetworkObjects or on one peer shutting
down while the others keep running.

* test: remove the NetworkObjectSpawning hybrid fixture

Its only hybrid case left running, CannotSpawnBeforeApproved, spawns nothing outside distributed
authority, so it passed without exercising hybrid spawning. The other two tests depend on in-scene
placed NetworkObjects and on InstantiateAndSpawn, which does not yet select the NetworkManager's
world for hybrid prefabs.

Author: NoelStephensUnity

testproject/Assets/Tests/Runtime/DontDestroyOnLoadTests.cs

@@ -22,6 +22,13 @@ public class DontDestroyOnLoadTests : NetcodeIntegrationTest
 
         public DontDestroyOnLoadTests(HostOrServer hostOrServer) : base(hostOrServer) { }
 
+#if UNIFIED_NETCODE
+        protected override bool UseUnifiedTests()
+        {
+            return true;
+        }
+#endif
+
         protected override void OnServerAndClientsCreated()
         {
             m_DontDestroyOnLoadObject = CreateNetworkObjectPrefab("DDOLObject");

testproject/Assets/Tests/Runtime/NetworkBehaviourSessionSynchronized.cs

@@ -9,9 +9,6 @@ namespace TestProject.RuntimeTests
 {
     [TestFixture(HostOrServer.Host)]
     [TestFixture(HostOrServer.DAHost)]
-#if UNIFIED_NETCODE
-    [TestFixture(HostOrServer.UnifiedHost)]
-#endif
     public class NetworkBehaviourSessionSynchronized : NetcodeIntegrationTest
     {
         private const string k_SceneToLoad = "SessionSynchronize";

testproject/Assets/Tests/Runtime/NetworkObjectDestroyWithSceneTests.cs

@@ -29,6 +29,13 @@ internal class NetworkObjectDestroyWithSceneTests : NetcodeIntegrationTest
 
         public NetworkObjectDestroyWithSceneTests(HostOrServer hostOrServer) : base(hostOrServer) { }
 
+#if UNIFIED_NETCODE
+        protected override bool UseUnifiedTests()
+        {
+            return true;
+        }
+#endif
+
         protected override void OnServerAndClientsCreated()
         {
             m_TestPrefab = CreateNetworkObjectPrefab("TestObject").GetComponent<NetworkObject>();

testproject/Assets/Tests/Runtime/NetworkObjectSpawning.cs

@@ -10,9 +10,6 @@
 namespace TestProject.RuntimeTests
 {
     [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.Host)]
-#if UNIFIED_NETCODE
-    [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.UnifiedHost)]
-#endif
     [TestFixture(NetworkTopologyTypes.DistributedAuthority, HostOrServer.DAHost)]
     internal class NetworkObjectSpawning : NetcodeIntegrationTest
     {

testproject/Assets/Tests/Runtime/PrefabExtendedTests.cs

@@ -14,10 +14,6 @@ namespace TestProject.RuntimeTests
     // DAMODE-TODO: When scene management is working in distributed authority mode we need to update this test
     [TestFixture(SceneManagementTypes.SceneManagementEnabled, HostOrServer.Host)]
     [TestFixture(SceneManagementTypes.SceneManagementDisabled, HostOrServer.Host)]
-#if UNIFIED_NETCODE
-    [TestFixture(SceneManagementTypes.SceneManagementEnabled, HostOrServer.UnifiedHost)]
-    [TestFixture(SceneManagementTypes.SceneManagementDisabled, HostOrServer.UnifiedHost)]
-#endif
     public class PrefabExtendedTests : NetcodeIntegrationTest
     {
         private const string k_PrefabTestScene = "PrefabTestScene";

testproject/Assets/Tests/Runtime/RespawnInSceneObjectsAfterShutdown.cs

@@ -10,9 +10,6 @@ namespace TestProject.RuntimeTests
 {
     [TestFixture(NetworkTopologyTypes.DistributedAuthority, HostOrServer.DAHost)]
     [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.Host)]
-#if UNIFIED_NETCODE
-    [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.UnifiedHost)]
-#endif
     public class RespawnInSceneObjectsAfterShutdown : NetcodeIntegrationTest
     {
         public const string SceneToLoad = "InSceneNetworkObject";

testproject/Assets/Tests/Runtime/RpcObserverTests.cs

@@ -42,6 +42,13 @@ protected override bool UseCMBService()
 
         public RpcObserverTests(HostOrServer hostOrServer) : base(hostOrServer) { }
 
+#if UNIFIED_NETCODE
+        protected override bool UseUnifiedTests()
+        {
+            return true;
+        }
+#endif
+
         protected override void OnServerAndClientsCreated()
         {
             m_TestPrefab = CreateNetworkObjectPrefab($"{nameof(RpcObserverObject)}");
@@ -106,6 +113,14 @@ public IEnumerator ClientRpcObserverTest()
             m_ServerRpcObserverObject.ObserverMessageClientRpc(clientRpcParams);
             yield return s_DefaultWaitForTick;
 
+#if UNIFIED_NETCODE
+            // Disconnecting a client disposes every world in the process when hybrid prefabs are registered.
+            if (m_AllPrefabsAsHybrid)
+            {
+                m_ServerNetworkManager.LogLevel = LogLevel.Normal;
+                yield break;
+            }
+#endif
             // Validate we can still just send to the host-client when no clients are connected
             if (m_UseHost)
             {

testproject/Assets/Tests/Runtime/RpcTestsAutomated.cs

@@ -31,6 +31,13 @@ public RpcTestsAutomated(HostOrServer hostOrServer) : base(hostOrServer)
 
         }
 
+#if UNIFIED_NETCODE
+        protected override bool UseUnifiedTests()
+        {
+            return true;
+        }
+#endif
+
         protected override NetworkManagerInstatiationMode OnSetIntegrationTestMode()
         {
             return NetworkManagerInstatiationMode.DoNotCreate;

testproject/Assets/Tests/Runtime/RpcUserSerializableTypesTest.cs

@@ -93,6 +93,13 @@ protected override bool UseCMBService()
 
         public RpcUserSerializableTypesTest(NetworkTopologyTypes networkTopologyType, HostOrServer hostOrServer) : base(networkTopologyType, hostOrServer) { }
 
+#if UNIFIED_NETCODE
+        protected override bool UseUnifiedTests()
+        {
+            return true;
+        }
+#endif
+
         protected override NetworkManagerInstatiationMode OnSetIntegrationTestMode()
         {
             return NetworkManagerInstatiationMode.DoNotCreate;

testproject/Assets/Tests/Runtime/SceneObjectsNotDestroyedOnShutdownTest.cs

@@ -11,9 +11,6 @@ namespace TestProject.RuntimeTests
 {
     [TestFixture(NetworkTopologyTypes.DistributedAuthority, HostOrServer.DAHost)]
     [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.Host)]
-#if UNIFIED_NETCODE
-    [TestFixture(NetworkTopologyTypes.ClientServer, HostOrServer.UnifiedHost)]
-#endif
     public class SceneObjectsNotDestroyedOnShutdownTest : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 0;