Repository navigation
Commit 551b825
committed
fix: NetworkList changes pending during client synchronization are applied twice
Override WriteFieldSynchronization in NetworkList<T> so a client synchronized while local changes are still pending receives the list as of the last sent delta, mirroring NetworkVariable<T>. The pending events are then applied exactly once with the next delta.
Fixes #41791 parent 5982716 commit 551b825
3 files changed
Lines changed: 98 additions & 3 deletions
File tree
- com.unity.netcode.gameobjects
- Runtime/NetworkVariable/Collections
- Tests/Runtime/NetworkVariable
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
| |||
67 | 71 | | |
68 | 72 | | |
69 | 73 | | |
| 74 | + | |
70 | 75 | | |
71 | 76 | | |
72 | 77 | | |
| |||
149 | 154 | | |
150 | 155 | | |
151 | 156 | | |
152 | | - | |
153 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
154 | 178 | | |
155 | | - | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
156 | 193 | | |
157 | 194 | | |
158 | 195 | | |
| |||
439 | 476 | | |
440 | 477 | | |
441 | 478 | | |
| 479 | + | |
442 | 480 | | |
443 | 481 | | |
444 | 482 | | |
| |||
466 | 504 | | |
467 | 505 | | |
468 | 506 | | |
| 507 | + | |
469 | 508 | | |
470 | 509 | | |
471 | 510 | | |
| |||
510 | 549 | | |
511 | 550 | | |
512 | 551 | | |
| 552 | + | |
513 | 553 | | |
514 | 554 | | |
515 | 555 | | |
| |||
553 | 593 | | |
554 | 594 | | |
555 | 595 | | |
| 596 | + | |
556 | 597 | | |
557 | 598 | | |
558 | 599 | | |
| |||
589 | 630 | | |
590 | 631 | | |
591 | 632 | | |
| 633 | + | |
592 | 634 | | |
593 | 635 | | |
594 | 636 | | |
| |||
631 | 673 | | |
632 | 674 | | |
633 | 675 | | |
| 676 | + | |
634 | 677 | | |
635 | 678 | | |
636 | 679 | | |
| |||
706 | 749 | | |
707 | 750 | | |
708 | 751 | | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
709 | 757 | | |
710 | 758 | | |
711 | 759 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
83 | 129 | | |
84 | 130 | | |
85 | 131 | | |
| |||
0 commit comments