Commit 45db9fc
committed
chore: fix the standards check for the n4e 7.0.0 dependency
Three things the standards job caught, since it opens the project, runs the formatter with --fix and
then fails on any diff at all:
- The fully qualified INetworkStreamDriverConstructor is simplified by the formatter (IDE0001), so
write it the way the formatter wants. It still resolves to NGO's, since the lookup walks out to
Unity.Netcode.Transports before reaching the shared root.
- N4E 7.0.0 renamed the serialized GlobalNetCodeConfig field to GlobalNetcodeConfig, which the editor
rewrites in the test project's settings asset the first time it loads it.
- validation_editors.minimal is back on a released editor. The standards job opens the project with
it, and trunk rewrites ProjectVersion.txt out from under the cleanliness check. Nothing there needs
N4E present: a released editor bundles 6.7.0 as a built-in package, so the 7.0.0 request is dropped
silently and the project builds with no N4E at all - verified on 6000.7.0a6, which resolves and
compiles clean with N4E absent from packages-lock, PackageCache and ScriptAssemblies alike.1 parent c78f679 commit 45db9fc
3 files changed
Lines changed: 10 additions & 6 deletions
File tree
- .yamato
- com.unity.netcode.gameobjects/Tests/Editor/Transports
- testproject/ProjectSettings
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
180 | | - | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
181 | 185 | | |
182 | 186 | | |
183 | 187 | | |
| |||
187 | 191 | | |
188 | 192 | | |
189 | 193 | | |
190 | | - | |
| 194 | + | |
191 | 195 | | |
192 | 196 | | |
193 | 197 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
| 234 | + | |
235 | 235 | | |
236 | | - | |
| 236 | + | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments