GH#1253: feat: disable compat shims in sovereign tenants by superdav42 · Pull Request #1258 · Ultimate-Multisite/ultimate-multisite

superdav42 · 2026-05-22T06:39:43Z

Summary

Added early-return guards to three compat shims (Auto_Delete_Users, Multiple_Accounts, Edit_Users) to prevent them from registering hooks when WU_MT_SOVEREIGN_TENANT is defined. Non-sovereign installs see zero behavioural change.

Files Changed

inc/compat/class-auto-delete-users-compat.php,inc/compat/class-edit-users-compat.php,inc/compat/class-multiple-accounts-compat.php

Runtime Testing

Risk level: Low (agent prompts / infrastructure scripts)
Verification: PHPCS linting passed on all three modified files. Code follows the reference pattern from issue ADR-001 Phase 3.5 — Sovereign-mode extension points, feature gates, and write branches #1250.

Resolves #1253

aidevops.sh v3.17.27 plugin for OpenCode v1.15.7 with claude-haiku-4-5 spent 2m and 1,728 tokens on this as a headless worker.

superdav42 · 2026-05-22T06:39:46Z

Completion Summary

What: Added early-return guards to three compat shims (Auto_Delete_Users, Multiple_Accounts, Edit_Users) to prevent them from registering hooks when WU_MT_SOVEREIGN_TENANT is defined. Non-sovereign installs see zero behavioural change.
Issue: ADR-001 Phase 3.5 PR-3 — Disable Auto_Delete_Users / Multiple_Accounts / Edit_Users compat in sovereign tenants #1253
Files changed: inc/compat/class-auto-delete-users-compat.php,inc/compat/class-edit-users-compat.php,inc/compat/class-multiple-accounts-compat.php
Testing: PHPCS linting passed on all three modified files. Code follows the reference pattern from issue ADR-001 Phase 3.5 — Sovereign-mode extension points, feature gates, and write branches #1250.
Key decisions: none

aidevops.sh v3.17.27 plugin for OpenCode v1.15.7 with claude-haiku-4-5 spent 2m and 1,728 tokens on this as a headless worker.

coderabbitai · 2026-05-22T06:39:49Z

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 16 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f197dd1a-efa2-4163-978b-6f0ec9f5a1bf

📥 Commits

Reviewing files that changed from the base of the PR and between 4ddd67e and d94a774.

📒 Files selected for processing (3)

inc/compat/class-auto-delete-users-compat.php
inc/compat/class-edit-users-compat.php
inc/compat/class-multiple-accounts-compat.php

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/auto-20260522-063651-gh1253

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-05-22T06:42:04Z

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

Build: ultimate-multisite
⬇️ Download from GitHub Actions
⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

superdav42 · 2026-05-22T06:46:14Z

Completion Summary

What: Added early-return guards to three compat shims (Auto_Delete_Users, Multiple_Accounts, Edit_Users) to prevent them from registering hooks when WU_MT_SOVEREIGN_TENANT is defined. Non-sovereign installs see zero behavioural change.
Issue: ADR-001 Phase 3.5 PR-3 — Disable Auto_Delete_Users / Multiple_Accounts / Edit_Users compat in sovereign tenants #1253
Files changed: inc/compat/class-auto-delete-users-compat.php,inc/compat/class-edit-users-compat.php,inc/compat/class-multiple-accounts-compat.php
Testing: PHPCS linting passed on all three modified files. Code follows the reference pattern from issue ADR-001 Phase 3.5 — Sovereign-mode extension points, feature gates, and write branches #1250.
Key decisions: none

aidevops.sh v3.17.27 plugin for OpenCode v1.15.7 with claude-haiku-4-5 spent 2m and 1,728 tokens on this as a headless worker.

Merged via PR #1258 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

github-actions · 2026-05-22T06:46:19Z

Performance Test Results

Performance test results for 071b5b7 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	40 (-1 / -3% )	37.76 MB	844.50 ms (+19.00 ms / +2% )	166.00 ms	1078.50 ms (+63.00 ms / +6% )	2000.00 ms	1906.90 ms	81.70 ms (+2.00 ms / +2% )
1	56	49.13 MB	948.50 ms (+79.00 ms / +8% )	148.00 ms (+9.00 ms / +6% )	1095.00 ms (+79.50 ms / +7% )	2082.00 ms (+68.00 ms / +3% )	2009.25 ms (+71.70 ms / +4% )	73.20 ms (-2.10 ms / -3% )

github-actions · 2026-05-22T06:47:53Z

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

Build: ultimate-multisite
⬇️ Download from GitHub Actions
⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

…ments (#1266) Extends the sovereign-mode disable pattern (established in #1257, #1258, #1261) to the remaining 8 customer-facing UI elements. When WU_MT_SOVEREIGN_TENANT is defined, each element renders a single 'Manage on main site' link instead of its normal output. Changes: - Add sovereign helper function wu_mt_main_site_account_url() in inc/functions/sovereign.php - Add sovereign-redirect template in views/elements/sovereign-redirect.php - Add sovereign-mode short-circuit to output() method in 8 UI elements: * Account_Summary_Element * Billing_Info_Element * Invoices_Element * My_Sites_Element * Current_Membership_Element * Current_Site_Element * Template_Switching_Element * Domain_Mapping_Element - Add comprehensive unit tests for sovereign-mode functionality Resolves #1263 Resolves Ultimate-Multisite/ultimate-multisite-multi-tenancy#86 Resolves Ultimate-Multisite/ultimate-multisite-multi-tenancy#87

superdav42 added the origin:worker Auto-created by pulse labelless backfill (t2112) label May 22, 2026

wip: add sovereign tenant guards to compat shims

d94a774

superdav42 force-pushed the feature/auto-20260522-063651-gh1253 branch from 85a8156 to d94a774 Compare May 22, 2026 06:45

superdav42 merged commit 5d6cdd6 into main May 22, 2026
7 checks passed

superdav42 mentioned this pull request May 22, 2026

ADR-001 Phase 3.5 PR-3 — Disable Auto_Delete_Users / Multiple_Accounts / Edit_Users compat in sovereign tenants #1253

Closed

superdav42 mentioned this pull request May 22, 2026

feat: ADR-001 Phase 3-A7 — Sovereign-mode disable for remaining customer-facing UI elements #1266

Merged

superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label May 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH#1253: feat: disable compat shims in sovereign tenants#1258

GH#1253: feat: disable compat shims in sovereign tenants#1258
superdav42 merged 1 commit into
mainfrom
feature/auto-20260522-063651-gh1253

superdav42 commented May 22, 2026

Uh oh!

superdav42 commented May 22, 2026

Uh oh!

coderabbitai Bot commented May 22, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

Uh oh!

superdav42 commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

superdav42 commented May 22, 2026

Summary

Files Changed

Runtime Testing

Uh oh!

superdav42 commented May 22, 2026

Completion Summary

Uh oh!

coderabbitai Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

github-actions Bot commented May 22, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

🌐 Test in WordPress Playground (Very Experimental)

Uh oh!

Uh oh!

superdav42 commented May 22, 2026

Completion Summary

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

🌐 Test in WordPress Playground (Very Experimental)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading