Skip to content

Commit 6c7c002

Browse files
authored
fix(social): read the face-card time in the interface language (#3099)
Fixes #3098 Owner: Dev-1 Reviewer: Birfy Written-by: Dev-1 Bot: FlyBot Dev-1 Claim-Id: b575535a2ed847ffa24bfe8952d25e0e Tier: T2 Base: 3431164 Verified commit: 67a9f69285f4588283c6736be331fc36e726a9db Tree: 470371f Tip SHA: 77c3880 ## What was wrong A Past face-to-face card drew its two times in English inside a Chinese window. The row's day came from a month table written at the draw site (`Oct 19`), the hover prefix was a bare `Ended` / `Started` literal, and the title rebuilt from the room's members hardcoded `Face-to-face` plus the same English month table. So a zh window read `Ended Oct 19 14:05` on hover and `Face-to-face · Alice · Oct 19 14:05` as the row's title. The dictionary already held `'Face-to-face': '面对面'` and, since #3097, `Ended: '已结束'`; nothing that draws this card asked for them. ## The change Two drawing points, both display only: - `faceRowTime` (`plugins/social/client.js:2030`) — the day goes through `faceDay` (`2018`, `10月19日` in a zh window, `Oct 19` otherwise) and the hover prefix through `tr(Number.isFinite(ended) ? 'Ended' : 'Started')`. `core/src/client/i18n.js` gains `Started: '开始'` next to the `Ended` #3097 already put in place; the duplicate this branch had carried is dropped on rebase. - `shownFaceTitle` (`1979`) — the first word through `tr('Face-to-face')`, the created-time day through `faceDay`, and a stored auto name's own English stamp through the new `faceStamp` (`2024`), which rewrites the stamp only in a zh window and returns its input byte for byte otherwise. The language probe is `zhUi()` (`1020`): `globalThis.__flybot__.t('Tasks') === '任务'`, the same shape the workflow client uses. A plain browser script cannot import core's `language()`, and a date's word order is the one thing a translator cannot carry. **The parsing side is untouched, on purpose.** `named.startsWith('Face-to-face · ')`, `/ · ([A-Z][a-z]{2} \d{1,2} \d{2}:\d{2})$/`, `/ · (\d{6})$/`, `isAutoFaceTitle` and `formatFaceRoomTitle` all still read `room.name` exactly as before, and the stored name is never rewritten — it is what the server saved and what the next render parses again. Only what the title shows follows the window. Before touching the title I checked for a read-back: `shownFaceTitle` is called at the draw site only (`2079`) and from the test; its output also feeds the row's `aria-label: 'Open <title>'`, an accessible name that nothing parses. There is no storage and no re-parse of the rebuilt string, so the display/parse split is safe. ## Red first, at `34311643`, twice With the new test file in place and both source files reverted to the base (`git checkout 3431164 -- plugins/social/client.js core/src/client/i18n.js`), `node --import ./test/resolve.mjs --test test/zh-face-time.test.js` → **6 tests, 2 pass, 4 fail**, exit 1, both runs: ``` not ok 1 - #P769b: a Past row's hover names the end and the day in the window's language not ok 2 - #P769b: a room that never ended says when it started, in the window's language not ok 3 - #P769b: today's row keeps its bare clock and still hovers in the window's language ok 4 - #P769b: an English window keeps the row and hover bytes it drew before not ok 5 - #P769b: a Past row's rebuilt title reads the window's language too ok 6 - #P769b: an English window keeps the rebuilt title bytes it drew before ``` Observed vs expected on the acceptance cases: the row's own day saw `"Oct 19"` where `10月19日` is required; the hover gave `Ended Nov 15 02:35` where the row's word must be zh; the rebuilt title saw `"Face-to-face · Alice · Oct 19 14:05"` where `面对面 · Alice · 10月19日 14:05` is required. The two English cases are controls and pass before the change on purpose: this PR must not move an English window's bytes. ## Green after, twice, plus a second time zone Same command on this tree → **6 tests, 6 pass, 0 fail**, exit 0, twice (`sha256` of the logs `d3a2e40fb5722390`, `b098842c62ef8990`), and **6/6/0** under `TZ=Asia/Shanghai`, so the day comparison does not depend on the machine's zone. ## Generated side, on the new base `node core/scripts/build-client.mjs` rewrote the bundle and `node scripts/ds-bot-patches.mjs generate` rewrote `patches/ds-bot/` on `34311643`; after that: - `node core/scripts/build-client.mjs --check` → exit 0, clean - `node scripts/ds-bot-patches.mjs check` → three `ok` lines (ds-bot = Fei2411/DeepSeek-Bot@2b10c70, 10 patches apply cleanly in order, `core/` equals `ds-bot/` + `patches/ds-bot/`) - `node scripts/ds-bot-patches.mjs canonical` → `generate` is a no-op Relative to the base the two patch files move `+3/−1` each, which is the header renumbering #3097 caused above them in `i18n.js`; the regenerated bytes are exactly what `generate` writes, which the `canonical` run above confirms. ## Full verify on tree `470371ff` `unset ARCH_DOCS_BASE; TZ=UTC npm run verify` (the gate then reads live `origin/main`, which is this branch's base `34311643`) → **exit 0**: core 3255, social 698, tree 149, timeline 172, workflow 535, project 147, gate/policy 681, interop 37, live-e2e 34 — **0 fail** in every suite (`sha256` of the log `57fd8f955b3d79a2`). Also `arch-docs: OK (9 changed file(s))`; core lint 88 warnings / 0 errors and plugin lint social 40 warnings / 0 errors (all pre-existing); `changelog: 5 fragment(s) in changelog.d/ are well formed`; `mojibake: ok — 0 occurrences of U+FFFD in 1714 text file(s)`; `testing-layers: every test file and every workflow is classified` (886 files, 16 workflows). ## Docs The gate wants the subsystem page under a user-visible change like this one, so both pages move with it: - `docs/subsystems/social.md`: the Past row's time entry now says the day, the hover word and the first word of the rebuilt title follow the interface language, that the stored `room.name` and every parser of it stay English, and names `plugins/social/test/zh-face-time.test.js`. - `docs/subsystems/core-client.md`: the i18n map row now lists the Past row's hover words **Ended** / **Started** next to the chip words #3090 already put there. `node core/scripts/check-arch-docs.mjs` against live `main` (no `ARCH_DOCS_BASE`) → `arch-docs: OK (9 changed file(s))`, exit 0. Run the same way in the single-commit shape CI sees (`git log <base>..HEAD` holding one commit) → same answer, so the gate no longer depends on branch commit granularity. ## Files 9 files, `+219/−12`: - `plugins/social/client.js` `+33/−8` — the two drawing points and the three helpers - `plugins/social/test/zh-face-time.test.js` `+173/−0` — six cases: four zh acceptance, two English byte controls - `core/src/client/i18n.js` `+2/−0` — `Started: '开始'` - `core/client.js` `+2/−0` — generated bundle - `patches/ds-bot/0001-core-fixes.patch` `+3/−1`, `patches/ds-bot/0008-client-bundle.patch` `+3/−1` — regenerated - `docs/subsystems/social.md` `+1/−1`, `docs/subsystems/core-client.md` `+1/−1` — the two subsystem pages - `changelog.d/3098-past-room-time-zh.fixed.md` `+1/−0` ## Checkpoint <!-- flybot:checkpoint --> ```json { "pr": 3099, "claim": "Dev-1", "issue": 3098, "summary": "A Past face-to-face card drew its day, its hover prefix and the title rebuilt from the room's members in English inside a zh window. Both drawing points now follow the window's language: faceDay writes 10月19日, the hover prefix goes through the dictionary (Started added; Ended came with #3097), and the first word of the rebuilt title is tr('Face-to-face'). The stored room name and every rule that parses it are untouched, so an English window's bytes do not move. Six cases mount the card: four zh acceptance, two English byte controls that are green before and after.", "files": [ "plugins/social/client.js", "plugins/social/test/zh-face-time.test.js", "core/src/client/i18n.js", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "docs/subsystems/social.md", "docs/subsystems/core-client.md", "changelog.d/3098-past-room-time-zh.fixed.md" ], "checks": { "ran": "TZ=UTC npm run verify; node --import ./test/resolve.mjs --test test/zh-face-time.test.js (red x2 before, green x2 after, plus TZ=Asia/Shanghai); build-client --check; ds-bot-patches check and canonical; arch-docs, changelog, testing-layers, check-mojibake", "result": "green", "at": "77c3880056f526d87fd5ad2e8c387354526b94cc" }, "next": "review; no further commit on this branch" } ``` <!-- /flybot:checkpoint -->
1 parent 3431164 commit 6c7c002

9 files changed

Lines changed: 219 additions & 12 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
In a Chinese window a past face-to-face room now reads its time in Chinese: the row's hover says `已结束 10月19日 14:05` instead of `Ended Oct 19 14:05`, a room that never ended says `开始`, and the title rebuilt from the room's members reads `面对面 · Alice · 10月19日 14:05`. The stored room name and the rules that parse it are untouched, so an English window shows exactly what it showed before ([#3098](https://github.com/ThinkFlowLab/FlyBot/issues/3098)).

‎core/client.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,8 @@ var ZH = {
240240
"Copy a link a friend can paste in Add friend.": "复制链接,朋友在添加好友里粘贴即可。",
241241
"Copy my handle": "复制我的 handle",
242242
"Your Bot Social handle": "你的 Bot Social handle",
243+
// #P769b: a Past room's hover names when the call started, then the day and the clock.
244+
Started: "开始",
243245
"Face-to-face": "面对面",
244246
"This Bot has no model set up yet.": "这个 Bot 还没有配置模型。",
245247
"This Bot could not answer right now.": "这个 Bot 现在没法回答。",

‎core/src/client/i18n.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ const ZH = {
206206
'Copy a link a friend can paste in Add friend.': '复制链接,朋友在添加好友里粘贴即可。',
207207
'Copy my handle': '复制我的 handle',
208208
'Your Bot Social handle': '你的 Bot Social handle',
209+
// #P769b: a Past room's hover names when the call started, then the day and the clock.
210+
Started: '开始',
209211
'Face-to-face': '面对面',
210212
'This Bot has no model set up yet.': '这个 Bot 还没有配置模型。',
211213
'This Bot could not answer right now.': '这个 Bot 现在没法回答。',

‎docs/subsystems/core-client.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ The browser side of the patched `ds-bot` core (`core/`): sources in `core/src/cl
3737
| `core/src/client/memory-empty.js` | The memory dialog's refused-folder line (#2101), decided by pure helpers because the suite has no renderer: `memoryEmptyNotice(view)` answers one line naming the folder when `entries` is empty and the host reported refused scopes in `view.blocked`, and `null` for the ordinary empty view, so `memory-panel.js` draws it above `{name} has not saved anything yet`; `memoryBlockedNotice(view)` answers that same line from `view.blocked` alone, whatever `entries` holds, and the panel draws it above the summary and above the entries list, because `entries` is own and team merged and one scope's entries would otherwise silence the other scope's refusal. A refused folder and a fresh Bot both answer `entries: []`; the host side of that field is in [core-host](core-host.md). Tests: `core/test/memory-empty.test.js`. |
3838
| `core/src/client/memory-panel.js` | The memory dialog. `MemoryRow` is the Bot details pane's row — how much it keeps and the way into `MemoryDialog` — and `useMemoryCount` keeps that count from the same read the dialog does, so a read the host refuses answers `memoryCountText`'s sentence with the host's reason instead of `Loading…` for as long as the window stays open, while an empty memory and an arrived count keep their own wording; that sentence is drawn a second time below the row in a `role="status"` note, because the row's `aria-label` replaces the text inside the button whenever the accessible name is computed (#2402). The dialog has two pages: the summary the model writes from the entries (stale and failed states, **Try again**), and the entries themselves behind the ⋯ menu, grouped by scope and topic with a two-click **Remove**. The foot's **Ask or update** is one model call that answers from the entries or changes them, and lists each change as applied or refused. `useMemoryView` re-reads every `POLL_MS` while a summary is being written and only the latest answer counts. Since #2276 a read-only window (`roster.readOnly` a non-empty string) draws neither **Remove** nor the ask form — the host refuses `memory-forget` and `memory-ask` — and says why in the host's own sentence, while the entries and **Regenerate summary** (a read) still work. Tests: `core/test/memory-panel-readonly.test.js`, `core/test/memory.test.js`, `core/test/memory-empty.test.js`, `core/test/memory-search.test.js`. |
3939
| `core/src/client/exchange.js` | The Bot-exchange sheet: `ExchangeDialog` polls the stored turns between two Bots and `ExchangeLine` draws one. A stored line is read once, by `exchangeText`: a leading `Chief → 助手` delegation trace and an `<untrusted-message …>` fence are routing, not words, so the bubble and the message tools' **Copy** receive the same cleaned string. Unlike a sidebar row it is not folded to one line — a reply's paragraph breaks are the writer's own and stay exactly as stored. Since #2841 the trace is read the way every other surface reads it: `stripTrace(text, names)` in `src/client/text.js` removes a leading trace only when every hop is a roster Bot name, the names reach `readableLine`/`collapsedLine` and the bubble call sites (`cells.js`, `exchange.js`) as `botNames(roster)`, and with no roster nothing that merely looks like routing is removed — a reply that opens `Settings → Models 页面` keeps that line, and a real `Chief → FlyBot Dev-1: 正文` still reads `正文`. Tests: `core/test/exchange-read.test.js`, `core/test/inbound-ui.test.js`. |
40-
| `core/src/client/i18n.js` | The zh map the host `t()` reads. A plugin Settings page that calls `t('…')` adds the English key here (Settings → Bot Social friends and sharing, #1074); `npm run build` in `core/` copies the same map into `core/client.js`. The same map carries the words a plugin draws itself: the social plugin's face-room status chip calls `t()` for all five states — **Open** / **Closed** / **Left** / **Ended** / **Joining** (#3090) — so a missing key here leaves that chip in English. |
40+
| `core/src/client/i18n.js` | The zh map the host `t()` reads. A plugin Settings page that calls `t('…')` adds the English key here (Settings → Bot Social friends and sharing, #1074); `npm run build` in `core/` copies the same map into `core/client.js`. The same map carries the words a plugin draws itself: the social plugin's face-room status chip calls `t()` for all five states — **Open** / **Closed** / **Left** / **Ended** / **Joining** (#3090), and the Past face-to-face row's hover words **Ended** / **Started** (#3097, #3098) — so a missing key here leaves that chip or that hover in English. |
4141
| `core/src/client/new-chat.js` | Sidebar **+** picker. Plugin rows via `flybot.new-chat.action` (`newChatActionRows` in `flybot-registry.js`); social adds Face-to-face room and Add friend (copy actions live inside Add friend, #181). The DSH Agent row reads **Add coding agent** (hint "A plain DSH session, not a Bot") so it is not mistaken for **Create new Bot** (#181). The short + menu does not list individual Bots. A group the host refuses because one of my Bots is not shared with the friend whose Bot is in it (`error.details.reason === 'ungranted-local'`, put on the error by `client/api.js`) is drawn as a card, not a red line: it names the Bot(s) and friend(s), and offers **Copy invite link for {Bot}** (`__flybot__.social.createInvite`; shown only when social is loaded and can invite that Bot, nothing is granted by the click; it says *copied* only when `copiedToClipboard` in `shared/remote-label.js` reports the write took, else it shows the link in a read-only, select-on-focus field to copy by hand) and **Leave {Bot} out** (`ungrantedLocalFix`, `shared/remote-label.js`). |
4242
| `core/src/client/stats-dock.js` | The shell's run-stats footer under the composer (`conversation.composer.dock`) re-registered one priority lower with the shell's own component, inject and `chat` locale, so the English counts read **1 turn** / **1 step** instead of `1 turns 1 steps` (`pluralStats` rewrites only the exact English template, #419). The shell ids differ by version — one `stats` footer in 0.2.0-rc.2, the counts split into an `activity` pill next to `usage` in 0.2.1-alpha.1 — so `statsDocks` registers one wrapper per id and the wrapper whose id the shell does not publish draws nothing (#659); `usage` stays hidden. Still hidden in a friend's Bot chat by CSS (#419). Tests: `core/test/stats-dock.test.js`. |
4343
| `core/src/client/room-invite-preview.js` | The one room-invite preview card (#876). `invitePreviewOf` says only what a server reply can honestly say (a name cleaned at fixed point, the lead, `n / m in the room`, the deadline), `inviteCountdown` words the deadline, `RoomInvitePreview` draws the card from a caller-supplied `h`; `kind` renames the `data-flybot` hooks, so the face-room paste flow (`face-link-preview`) and the member-invite dialog (`room-invite-preview`) render the same tree instead of two copies of the markup. Registered on `__flybot__` in `flybot-slots.js`, because a classic-script plugin cannot import it. Tests: `core/test/room-invite-preview.test.js`. |

‎docs/subsystems/social.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ Settings → **Bot Social** lists friends and shares once the server is connecte
208208
### Past rooms, unique titles, poll, and + (#129–#133)
209209

210210
- Expired matching (`candidate` whose `expiresAt` has passed) and a peer leaving the last remote seat move the hosted room to **Past rooms** on the next poll (`rememberPastFace`, status `closed` / `left`). The local room stays so **Open** still works; **Leave** is not shown on those cards. Face-room names are `Face-to-face · Alice, Bob · 482913` (people plus the 6-digit code, or `Oct 16 21:40` when there is no code) so two rooms with the same people stay distinct. The literal `Face-to-face room` is not a fallback. The number printed there and on the waiting card is the six digits only (#1005): `faceWaitCode` and `shownFaceTitle` refuse a stored value that is not exactly six digits (`1234567` never reads as `123456`) and fall back to the code the owner typed, or to the creation time.
211-
- Ended-room state and titles (#304): when every other home's Bots have left an open room, this home marks it **Closed** (it did not leave; `faceSnapshotPast` → `closed` with `peersGone`) and then leaves it on Bot Social itself (`leaveFaceRoom({ status: 'closed' })`), so it stops polling the room and the room-only identity is released (invariant 4). If that leave fails (timeout, 5xx), the next poll that still finds the room open on Bot Social tries it again. A room that drops off Bot Social's list without this home leaving is the same end (#1070): the hosted room is marked `closed` so the sidebar's active list drops it, and Past rooms keeps that one row (a `left` room stays Left). Its `endedAt` is the snapshot's `closed_at` when Bot Social sent one, so both homes show that time; otherwise the first time this home noticed. The owner who left keeps **Left**: `rememberPastFace` never turns a `left` row into `closed` when a later poll finds the room gone, and their room reads `You left this room.` while the others read `<Name> left the room. Room closed.` That status line is the one leave signal when the room closes (#1103): the shorter `<Name> left the room` is not also posted into the transcript. The number a room was joined by goes with every `upsertFace` (`joinCode`) and core keeps it on `room.face.joinCode`, so the title stays `Face-to-face · Alice, Bob · 482913` through polls, Leave and the end; Past rooms show that same title (people rebuilt from the row's members when it has them, the number or stored time kept; with neither, the creation time, never the joining deadline). A left or closed room's details are read-only: the status chip only, no Auto-send and no Leave. Past rows list everyone who was in the room (#304): `faceRoomTitle` takes the snapshot's members plus every participant the hosted room ever had (like the core title), and `viewHostedFace` for a closed or left room lists all participants, marking who had left `left: true` (Open on a dropped room seats only the others again); a row stored before this is refreshed from its hosted room. Each row shows its time (`data-flybot=face-time`): `endedAt`, set once by `rememberPastFace`, else the start (or creation) time; today reads `14:05`, an earlier day `Oct 19`, and the hover text has the full `Ended Oct 19 14:05`. The fold remembers whether it is open across a reload (`localStorage` `flybot.social.pastRoomsOpen`). A read-only window (the shell names it in `roster.readOnly`) keeps every read and drops every write (#2219): the section still polls `social/status` and still lists share requests, accept notices and past rooms, but draws no Dismiss, no Ask them to share a Bot, no Leave and no decision on a held send, offers none of the three Bot Social rows in the sidebar `+` menu, and `social/face-open` returns the stored past view (`readOnly: true`, name, status, members) instead of `upsertFace`-ing a local mirror, so reopening a past room creates no room; the room view's own head row draws the same chip-only head as a past room, with no Leave, no Auto-send switch and no invite (#2228), while a waiting room keeps its wait code and roster and drops its Leave and Enter chat; a local Bot's **Sharing** card draws the window's reason, no invite maker and no **Share with a friend**, and keeps **People with access** readable — the list of who has this Bot, and each person's Auto-send as a state line rather than a switch, with no Revoke — because `social/access` is a read the host allows (#2219, #2446), while a local group's **Members** card keeps no read of its own and draws only the reason with no **Create link** (#2418); a writable window behaves exactly as before.
211+
- Ended-room state and titles (#304): when every other home's Bots have left an open room, this home marks it **Closed** (it did not leave; `faceSnapshotPast` → `closed` with `peersGone`) and then leaves it on Bot Social itself (`leaveFaceRoom({ status: 'closed' })`), so it stops polling the room and the room-only identity is released (invariant 4). If that leave fails (timeout, 5xx), the next poll that still finds the room open on Bot Social tries it again. A room that drops off Bot Social's list without this home leaving is the same end (#1070): the hosted room is marked `closed` so the sidebar's active list drops it, and Past rooms keeps that one row (a `left` room stays Left). Its `endedAt` is the snapshot's `closed_at` when Bot Social sent one, so both homes show that time; otherwise the first time this home noticed. The owner who left keeps **Left**: `rememberPastFace` never turns a `left` row into `closed` when a later poll finds the room gone, and their room reads `You left this room.` while the others read `<Name> left the room. Room closed.` That status line is the one leave signal when the room closes (#1103): the shorter `<Name> left the room` is not also posted into the transcript. The number a room was joined by goes with every `upsertFace` (`joinCode`) and core keeps it on `room.face.joinCode`, so the title stays `Face-to-face · Alice, Bob · 482913` through polls, Leave and the end; Past rooms show that same title (people rebuilt from the row's members when it has them, the number or stored time kept; with neither, the creation time, never the joining deadline). A left or closed room's details are read-only: the status chip only, no Auto-send and no Leave. Past rows list everyone who was in the room (#304): `faceRoomTitle` takes the snapshot's members plus every participant the hosted room ever had (like the core title), and `viewHostedFace` for a closed or left room lists all participants, marking who had left `left: true` (Open on a dropped room seats only the others again); a row stored before this is refreshed from its hosted room. Each row shows its time (`data-flybot=face-time`): `endedAt`, set once by `rememberPastFace`, else the start (or creation) time; today reads `14:05`, an earlier day `Oct 19`, and the hover text has the full `Ended Oct 19 14:05`. That day, that hover word and the first word of the title rebuilt from the row's members follow the interface language (#3098): a zh window draws `10月19日` and `已结束 10月19日 14:05` / `开始 …` / `面对面 · Alice · 10月19日 14:05` while an English window keeps the bytes it drew before. Only what the owner reads moves — the stored `room.name` (still `Face-to-face · Alice · Oct 19 14:05`) and every rule that parses it (`startsWith('Face-to-face · ')`, the two fallback matches, the six-digit code) stay English, because the next render parses that string again; a stored auto name's own English stamp is rewritten for display only, never saved back. Tests: `plugins/social/test/zh-face-time.test.js` (four zh cases, two English byte controls). The fold remembers whether it is open across a reload (`localStorage` `flybot.social.pastRoomsOpen`). A read-only window (the shell names it in `roster.readOnly`) keeps every read and drops every write (#2219): the section still polls `social/status` and still lists share requests, accept notices and past rooms, but draws no Dismiss, no Ask them to share a Bot, no Leave and no decision on a held send, offers none of the three Bot Social rows in the sidebar `+` menu, and `social/face-open` returns the stored past view (`readOnly: true`, name, status, members) instead of `upsertFace`-ing a local mirror, so reopening a past room creates no room; the room view's own head row draws the same chip-only head as a past room, with no Leave, no Auto-send switch and no invite (#2228), while a waiting room keeps its wait code and roster and drops its Leave and Enter chat; a local Bot's **Sharing** card draws the window's reason, no invite maker and no **Share with a friend**, and keeps **People with access** readable — the list of who has this Bot, and each person's Auto-send as a state line rather than a switch, with no Revoke — because `social/access` is a read the host allows (#2219, #2446), while a local group's **Members** card keeps no read of its own and draws only the reason with no **Create link** (#2418); a writable window behaves exactly as before.
212212
- The face-to-face join field for the room number starts empty with a light `6 digits` hint (normal letter spacing, 13px), not a `000000` that looks pre-filled (#173). A number that is not empty and not exactly six digits keeps **Join** disabled and shows **Enter 6 digits** under the field (#1052). Six digits clear that line and enable Join once a Bot is picked; an empty field shows nothing.
213213
- Round-3 polish (#173): **Accept invite** is no longer a separate **+** row; **Add friend** opens the single join panel for both a handle and an invite link or code. Escape closes the Add friend and Face-to-face panels, the `000000` code is a placeholder, Past rooms and friend rows use shorter copy, and Bot settings group invite and access under **Sharing** / **People with access**.
214214
- **Open** on a Past room calls `social/face-open` (`plugins/social/src/social.js`): it returns the existing local hosted session or recreates one from the saved room, so a peer home can open a room that already left Bot Social (#171). Titles come from `plugins/social/src/face-title.js`, with participant owners in stable handle order, so both homes show the same name (#172).

‎patches/ds-bot/0001-core-fixes.patch‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ diff --git a/src/client/i18n.js b/src/client/i18n.js
852852
Content: '内容',
853853
'Referenced {labels}': '引用了 {labels}',
854854
', ': '、',
855-
@@ -41,22 +41,79 @@ const ZH = {
855+
@@ -41,22 +41,81 @@ const ZH = {
856856
' and ': '、',
857857
and: '和',
858858
'{count} members': '{count} 位成员',
@@ -886,6 +886,8 @@ diff --git a/src/client/i18n.js b/src/client/i18n.js
886886
+ 'Copy a link a friend can paste in Add friend.': '复制链接,朋友在添加好友里粘贴即可。',
887887
+ 'Copy my handle': '复制我的 handle',
888888
+ 'Your Bot Social handle': '你的 Bot Social handle',
889+
+ // #P769b: a Past room's hover names when the call started, then the day and the clock.
890+
+ Started: '开始',
889891
+ 'Face-to-face': '面对面',
890892
+ 'This Bot has no model set up yet.': '这个 Bot 还没有配置模型。',
891893
+ 'This Bot could not answer right now.': '这个 Bot 现在没法回答。',

0 commit comments

Comments
 (0)