fix(i18n): localize the remaining system text and open the Blocked log from the summary

The Quick Settings tile and notification-listener labels, the digest's
source breakdown, the notes stored when a number is blocked or trusted from
a notification, and every checker description in Checkers.kt were English
literals. Checker descriptions are user-visible: Lookup's Details row and
the block log show them. They now resolve through ctx.appContext, the way
the caller-name and region checkers already did, and the digest keeps its
stable bucket keys and maps each one to a translatable label. The copies
that carried an em dash or a " - " lost it on the way. All 26 new strings
and 3 plurals have zh-rCN text, so coverage rises from 76.1% to 76.5%.

The zh-rCN digest_big_text used literal line breaks, which aapt2 collapses
to spaces, so the Chinese digest ran together on one line. It uses \n now.

The grouped "blocked recently" summary had no content intent. It now opens
MainActivity with ACTION_OPEN_BLOCKED_LOG, which selects Activity and its
Blocked tab once per request and closes an open number detail. Checked on
the API 35 emulator: two blocked calls, then a tap on the collapsed group
opened the Blocked log.

Tests: new LocalizedSystemTextTest runs in zh-rCN, so an English literal
can't pass for a resource; BlockedSummaryNotificationTest reads the
summary's PendingIntent; launch routing and the digest labels are pinned.
Each fails with its fix reverted. README's resource counts follow
(1508 strings, 38 plurals).

Author: SysAdminDoc

CHANGELOG.md

@@ -155,6 +155,9 @@ All notable changes to CallShield will be documented in this file.
 
 ### Interface
 
+- Tapping the "blocked recently" notification opens the Blocked log now. It
+  used to do nothing at all.
+
 - Setup now says what to do when Android won't let a permission through. Apps
   installed outside an app store run into Android's restricted settings. The
   grant screen refuses notification access from Android 13, and the overlay
@@ -423,6 +426,13 @@ The rest of this section takes effect when the report Worker is next deployed.
 
 ### Translations
 
+- The last of the system text is translatable. That covers the Quick Settings
+  tile and notification-access labels, the source breakdown in the daily
+  summary, the note saved when you block or trust a number from a
+  notification, and the explanation each detection layer gives in Lookup and
+  the block log. Chinese has all of it. The Chinese daily summary also keeps
+  its line breaks now, where before it ran together on one line.
+
 - A shipped locale can no longer decay silently. Each has a coverage floor in
   `scripts/translation_floors.json`, and dropping below it fails the build.
   zh-rCN starts at 76.1%. A locale with no recorded floor warns instead, so

README.md

@@ -509,7 +509,7 @@ language in [issue #7](https://github.com/SysAdminDoc/CallShield/issues/7).
 | URL Safety | Local spam-domain data; optional URLhaus (abuse.ch) |
 | Verification | Local Gradle, lint, and release-artifact checks |
 | Tests | 1100 JVM unit tests (JUnit) |
-| Strings | 1482 string resources and 35 plural groups (translation-ready) |
+| Strings | 1508 string resources and 38 plural groups (translation-ready) |
 | Accessibility | 100+ content descriptions, 48dp touch targets |
 | Min SDK | 29 (Android 10) |
 | Target SDK | 36 |

app/src/main/AndroidManifest.xml

@@ -151,7 +151,7 @@
         <service
             android:name=".service.CallShieldTileService"
             android:icon="@drawable/ic_callshield_brand"
-            android:label="CallShield"
+            android:label="@string/app_name"
             android:permission="android.permission.BIND_QUICK_SETTINGS_TILE"
             android:exported="true">
             <intent-filter>
@@ -179,7 +179,7 @@
 
         <service
             android:name=".service.RcsNotificationListener"
-            android:label="CallShield RCS Filter"
+            android:label="@string/notification_listener_label"
             android:permission="android.permission.BIND_NOTIFICATION_LISTENER_SERVICE"
             android:exported="true">
             <intent-filter>

app/src/main/java/com/sysadmindoc/callshield/data/checker/Checkers.kt

@@ -39,7 +39,7 @@ internal class EmergencyNumberFloorChecker : IChecker {
         return BlockResult.allow(
             matchSource = name,
             type = "safety_floor",
-            description = "Emergency and public-safety numbers are never blocked",
+            description = ctx.appContext.getString(R.string.block_reason_emergency_floor),
         )
     }
 }
@@ -57,7 +57,7 @@ internal class VerificationMessageFloorChecker(
         return BlockResult.allow(
             matchSource = name,
             type = "safety_floor",
-            description = "Verification messages are exempt from blocking",
+            description = ctx.appContext.getString(R.string.block_reason_verification_floor),
         )
     }
 }
@@ -136,7 +136,7 @@ internal class ContactsOnlyChecker(
 
     override suspend fun check(ctx: CheckContext): BlockResult? =
         if (!spamHeuristics.isInContacts(appContext, ctx.number)) {
-            BlockResult.block("contacts_only", description = "Blocked — contacts-only mode is active")
+            BlockResult.block("contacts_only", description = appContext.getString(R.string.block_reason_contacts_only))
         } else {
             null
         }
@@ -313,7 +313,7 @@ internal class StirShakenChecker : IChecker {
             BlockResult.block(
                 matchSource = "stir_shaken_failed",
                 type = "spoofed",
-                description = "Carrier could not verify caller identity",
+                description = ctx.appContext.getString(R.string.block_reason_carrier_unverified),
             )
         } else {
             null
@@ -358,7 +358,7 @@ internal class SystemBlockListChecker(
             BlockResult.block(
                 matchSource = "system_block_list",
                 type = "user_blocked",
-                description = "Blocked via system block list",
+                description = appContext.getString(R.string.block_reason_system_block_list),
             )
         } else {
             null
@@ -383,7 +383,7 @@ internal class UserBlocklistChecker(
                 if (entry.expiresAt == null) {
                     entry.description
                 } else {
-                    entry.description.ifBlank { "Temporarily blocked" }
+                    entry.description.ifBlank { ctx.appContext.getString(R.string.block_reason_temporary_block) }
                 }
             BlockResult.block(source, entry.type, description, ruleId = entry.id)
         } else {
@@ -425,7 +425,7 @@ internal class DbPrefixExpansionChecker(
         if (!repo.hasDbPrefixMatch(ctx.number)) return null
         return BlockResult.block(
             "db_prefix_expansion",
-            description = "Number shares prefix with a known spam entry",
+            description = ctx.appContext.getString(R.string.block_reason_db_prefix),
             confidence = 50,
         )
     }
@@ -816,7 +816,7 @@ internal class TimeBlockChecker : IChecker {
 
         val now = Calendar.getInstance().get(Calendar.HOUR_OF_DAY)
         return if (isInQuietWindow(now, start, end)) {
-            BlockResult.block("time_block", "unknown", "Blocked during quiet hours")
+            BlockResult.block("time_block", "unknown", ctx.appContext.getString(R.string.block_reason_quiet_hours))
         } else {
             null
         }
@@ -866,7 +866,11 @@ internal class FrequencyEscalationChecker(
         val freq = repo.getCallFrequencySinceInternal(ctx.number, System.currentTimeMillis() - windowMs)
         val threshold = (ctx.prefs[SpamRepository.KEY_FREQ_THRESHOLD] ?: 3).coerceAtLeast(2)
         return if (freq >= threshold) {
-            BlockResult.block("frequency", "repeat_caller", "Called $freq times in 7 days - auto-blocked")
+            BlockResult.block(
+                "frequency",
+                "repeat_caller",
+                ctx.appContext.resources.getQuantityString(R.plurals.block_reason_frequency, freq, freq),
+            )
         } else {
             null
         }
@@ -1008,20 +1012,39 @@ internal class CampaignBurstChecker(
                 campaignDetector.getCampaignEvidence(ctx.number)
             } ?: return null
         if (!evidence.isActive) return null
+        val resources = ctx.appContext.resources
         val details =
             buildList {
-                add("${evidence.distinctNumberCount} neighbor numbers in ${evidence.observationCount} calls")
+                add(
+                    resources.getString(
+                        R.string.block_reason_campaign_neighbors,
+                        evidence.distinctNumberCount,
+                        evidence.observationCount,
+                    ),
+                )
                 if (evidence.repeatedNumberCount > 0) {
-                    add("${evidence.repeatedNumberCount} repeated number(s) suggest callback reuse")
+                    add(
+                        resources.getQuantityString(
+                            R.plurals.block_reason_campaign_repeats,
+                            evidence.repeatedNumberCount,
+                            evidence.repeatedNumberCount,
+                        ),
+                    )
                 }
                 if (evidence.sourceAgreementCount > 0) {
-                    add("${evidence.sourceAgreementCount} source signal(s) agree")
+                    add(
+                        resources.getQuantityString(
+                            R.plurals.block_reason_campaign_sources,
+                            evidence.sourceAgreementCount,
+                            evidence.sourceAgreementCount,
+                        ),
+                    )
                 }
-            }.joinToString("; ")
+            }.joinToString(resources.getString(R.string.block_reason_detail_separator))
         return BlockResult.block(
             matchSource = "campaign_burst",
             type = "robocall",
-            description = "Active campaign: $details",
+            description = resources.getString(R.string.block_reason_campaign, details),
             confidence = 75,
         )
     }
@@ -1047,9 +1070,9 @@ internal class MlScorerChecker(
                 type = "robocall",
                 description =
                     listOfNotNull(
-                        "ML model: ${verdict.confidence}% spam probability",
+                        ctx.appContext.getString(R.string.block_reason_ml, verdict.confidence),
                         CallerIdentitySignals.describe(ctx.callerIdentity).takeIf { it.isNotBlank() },
-                    ).joinToString(". "),
+                    ).joinToString(ctx.appContext.getString(R.string.block_reason_sentence_separator)),
                 confidence = verdict.confidence,
             )
         } else {
@@ -1122,7 +1145,12 @@ internal class SmsKeywordChecker(
         val now = java.util.Calendar.getInstance()
         for (rule in rules) {
             if (rule.matchesNow(body, now)) {
-                return BlockResult.block("keyword", "sms_spam", "Keyword: ${rule.keyword}", ruleId = rule.id)
+                return BlockResult.block(
+                    "keyword",
+                    "sms_spam",
+                    ctx.appContext.getString(R.string.block_reason_keyword, rule.keyword),
+                    ruleId = rule.id,
+                )
             }
         }
         return null

app/src/main/java/com/sysadmindoc/callshield/service/DigestWorker.kt

@@ -53,7 +53,9 @@ class DigestWorker
                         .eachCount()
                         .entries
                         .sortedByDescending { it.value }
-                        .joinToString(" · ") { "${it.value} ${it.key}" }
+                        .joinToString(applicationContext.getString(R.string.digest_source_separator)) {
+                            applicationContext.getString(bucketLabelRes(it.key), it.value)
+                        }
 
                 if (!CallShieldPermissions.hasNotificationPermission(applicationContext)) {
                     // User has not granted POST_NOTIFICATIONS on API 33+; skip quietly.
@@ -123,6 +125,17 @@ class DigestWorker
                     else -> "other"
                 }
 
+            /** The digest's "count + source" label for a [matchReasonBucket] key. */
+            internal fun bucketLabelRes(bucket: String): Int =
+                when (bucket) {
+                    "database" -> R.string.digest_source_database
+                    "heuristic" -> R.string.digest_source_heuristic
+                    "ML" -> R.string.digest_source_ml
+                    "content" -> R.string.digest_source_content
+                    "RCS filter" -> R.string.digest_source_rcs_filter
+                    else -> R.string.digest_source_other
+                }
+
             fun schedule(context: Context) {
                 WorkManager.getInstance(context).enqueueUniquePeriodicWork(
                     WORK_NAME,

app/src/main/java/com/sysadmindoc/callshield/service/NotificationHelper.kt

@@ -19,6 +19,7 @@ import com.sysadmindoc.callshield.data.PhoneFormatter
 import com.sysadmindoc.callshield.data.SmsContentAnalyzer
 import com.sysadmindoc.callshield.domain.model.BlockReasonCode
 import com.sysadmindoc.callshield.permissions.CallShieldPermissions
+import com.sysadmindoc.callshield.ui.ACTION_OPEN_BLOCKED_LOG
 import com.sysadmindoc.callshield.ui.MainActivity
 import com.sysadmindoc.callshield.util.filterAsciiDigits
 import com.sysadmindoc.callshield.util.filterAsciiDigitsLast
@@ -499,6 +500,7 @@ object NotificationHelper {
                 .setGroup(GROUP_BLOCKED)
                 .setGroupSummary(true)
                 .setGroupAlertBehavior(NotificationCompat.GROUP_ALERT_SUMMARY)
+                .setContentIntent(blockedLogIntent(context))
                 .setAutoCancel(true)
                 // Zero the per-process counter when the user dismisses the group,
                 // so the next block starts counting from that block instead of
@@ -507,6 +509,18 @@ object NotificationHelper {
         safeNotify(context, SUMMARY_ID, summary)
     }
 
+    /** The summary counts blocks, so tapping it opens the Blocked log that lists them. */
+    private fun blockedLogIntent(context: Context): PendingIntent =
+        PendingIntent.getActivity(
+            context,
+            SUMMARY_ID,
+            Intent(context, MainActivity::class.java).apply {
+                action = ACTION_OPEN_BLOCKED_LOG
+                flags = Intent.FLAG_ACTIVITY_SINGLE_TOP or Intent.FLAG_ACTIVITY_CLEAR_TOP
+            },
+            PendingIntent.FLAG_IMMUTABLE or PendingIntent.FLAG_UPDATE_CURRENT,
+        )
+
     private fun summaryDeleteIntent(context: Context): PendingIntent =
         PendingIntent.getBroadcast(
             context,

app/src/main/java/com/sysadmindoc/callshield/service/SpamActionReceiver.kt

@@ -31,7 +31,7 @@ class SpamActionReceiver : BroadcastReceiver() {
                     notificationManager.cancel(NotificationHelper.feedbackNotificationId(number))
                     Toast.makeText(appContext, appContext.getString(R.string.feedback_blocked), Toast.LENGTH_SHORT).show()
                     suspend {
-                        repo.blockNumber(number, "spam", "Blocked from after-call feedback")
+                        repo.blockNumber(number, "spam", appContext.getString(R.string.desc_blocked_from_after_call_feedback))
                         CommunityContributor.contribute(appContext, repo.normalizeNumber(number), "spam")
                     }
                 }
@@ -41,7 +41,7 @@ class SpamActionReceiver : BroadcastReceiver() {
                     notificationManager.cancel(NotificationHelper.feedbackNotificationId(number))
                     Toast.makeText(appContext, appContext.getString(R.string.feedback_whitelisted), Toast.LENGTH_SHORT).show()
                     suspend {
-                        repo.addToWhitelist(number, "Marked safe from after-call feedback")
+                        repo.addToWhitelist(number, appContext.getString(R.string.desc_marked_safe_from_after_call_feedback))
                         CommunityContributor.reportNotSpam(appContext, repo.normalizeNumber(number))
                     }
                 }
@@ -55,7 +55,7 @@ class SpamActionReceiver : BroadcastReceiver() {
                         notificationManager.cancel(notifId)
                     }
                     suspend {
-                        repo.blockNumber(number, reportType, "Blocked from notification")
+                        repo.blockNumber(number, reportType, appContext.getString(R.string.desc_blocked_from_notification))
                         CommunityContributor.contribute(appContext, repo.normalizeNumber(number), reportType, smsIndicators)
                     }
                 }
@@ -88,7 +88,7 @@ class SpamActionReceiver : BroadcastReceiver() {
                         notificationManager.cancel(notifId)
                     }
                     suspend {
-                        repo.addToWhitelist(number, "Reported as not spam from notification")
+                        repo.addToWhitelist(number, appContext.getString(R.string.desc_reported_not_spam_from_notification))
                         CommunityContributor.reportNotSpam(appContext, repo.normalizeNumber(number))
                     }
                 }

app/src/main/java/com/sysadmindoc/callshield/ui/MainActivity.kt

@@ -135,16 +135,16 @@ fun CallShieldRoot(
     // from the request — computing it inside the effect raced the child's
     // LaunchedEffect(tabRequestId), which captured the pre-update startTab and
     // never re-ran, so the Lookup shortcut landed on Home.
-    val initialTab =
-        when (launchRequest.shortcutAction) {
-            "com.sysadmindoc.callshield.LOOKUP" -> 2
-            else -> 0
-        }
+    val initialTab = launchTab(launchRequest.shortcutAction)
     LaunchedEffect(launchRequest.id) {
         launchRequest.deepLinkNumber?.let { viewModel.openNumberDetail(it) }
         when (launchRequest.shortcutAction) {
             "com.sysadmindoc.callshield.SCAN" -> viewModel.scanCallLog()
+
             "com.sysadmindoc.callshield.SCAN_SMS" -> viewModel.scanSmsInbox()
+
+            // An open number detail replaces the tab shell, which would hide the log.
+            ACTION_OPEN_BLOCKED_LOG -> viewModel.closeNumberDetail()
         }
     }
 
@@ -184,6 +184,7 @@ fun CallShieldRoot(
                         viewModel = viewModel,
                         startTab = initialTab,
                         tabRequestId = launchRequest.id.takeIf { launchRequest.shortcutAction != null },
+                        blockedLogRequestId = launchRequest.blockedLogRequestId(),
                     )
                 }
             }
@@ -198,6 +199,7 @@ fun CallShieldApp(
     viewModel: MainViewModel,
     startTab: Int = 0,
     tabRequestId: Int? = null,
+    blockedLogRequestId: Int? = null,
 ) {
     var selectedTab by rememberSaveable { mutableIntStateOf(startTab) }
     var showSearch by rememberSaveable { mutableStateOf(false) }
@@ -357,7 +359,7 @@ fun CallShieldApp(
                             }
 
                             1 -> {
-                                ActivityScreen(viewModel)
+                                ActivityScreen(viewModel, blockedLogRequestId = blockedLogRequestId)
                             }
 
                             2 -> {
@@ -843,11 +845,26 @@ internal fun Intent?.toLaunchRequest(nextId: Int): LaunchRequest {
     )
 }
 
+/** Opens Activity on its Blocked tab. The blocked-summary notification sends it. */
+internal const val ACTION_OPEN_BLOCKED_LOG = "com.sysadmindoc.callshield.BLOCKED_LOG"
+
+/** The bottom-bar tab a launch opens on: Lookup, Activity for the blocked log, else Home. */
+internal fun launchTab(shortcutAction: String?): Int =
+    when (shortcutAction) {
+        "com.sysadmindoc.callshield.LOOKUP" -> 2
+        ACTION_OPEN_BLOCKED_LOG -> 1
+        else -> 0
+    }
+
+/** This request's id when it asks for the blocked log, so Activity can switch to it once. */
+internal fun LaunchRequest.blockedLogRequestId(): Int? = id.takeIf { shortcutAction == ACTION_OPEN_BLOCKED_LOG }
+
 private val KNOWN_SHORTCUT_ACTIONS =
     setOf(
         "com.sysadmindoc.callshield.LOOKUP",
         "com.sysadmindoc.callshield.SCAN",
         "com.sysadmindoc.callshield.SCAN_SMS",
+        ACTION_OPEN_BLOCKED_LOG,
     )
 
 // Stable SaveableStateHolder keys for the two top-level branches. They must not