fix(scripts): delete the smoke pass's last dump before a new one

uiautomator leaves the previous file in place when a dump fails, so
the next read handed a step the labels of the screen before.

Author: SysAdminDoc

CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to CallShield will be documented in this file.
 ## Unreleased
 
 - The data pipeline's test runner now uses the first Python on PATH that has the pipeline's packages installed. With an older Python ahead of it on PATH, three suites used to fail on a missing cryptography or numpy.
+- `scripts/device_smoke.py` deletes its last screen dump before taking a new one. A dump that failed used to leave the old file in place, so a step could act on labels from the screen before.
 
 ## v1.13.0 (2026-10-30)
 

scripts/device_smoke.py

@@ -86,6 +86,9 @@ def shell(self, *args: str) -> str:
         return out.stdout.decode("utf-8", "replace")
 
     def nodes(self) -> list[Node]:
+        # A dump that fails leaves the old file behind, and its labels would
+        # read as the current screen.
+        self.shell("rm", "-f", DUMP)
         self.shell("uiautomator", "dump", DUMP)
         return parse_nodes(self.shell("cat", DUMP))
 

scripts/test_device_smoke.py

@@ -37,6 +37,16 @@ def test_a_tab_is_the_lowest_node_with_its_name(self):
         self.assertEqual((539, 2113), (tab.x, tab.y))
         self.assertIsNone(device_smoke.bottom_most(device_smoke.parse_nodes(DUMP), "Rules"))
 
+    def test_a_dump_deletes_the_last_one_first(self):
+        # A dump that fails leaves the old file, which would read as the current screen.
+        calls = []
+        phone = device_smoke.Phone.__new__(device_smoke.Phone)
+        phone.shell = lambda *args: calls.append(args) or (DUMP if args[0] == "cat" else "")
+
+        self.assertEqual(4, len(phone.nodes()))
+        self.assertEqual(("rm", "-f", device_smoke.DUMP), calls[0])
+        self.assertEqual("uiautomator", calls[1][0])
+
     def test_the_expected_version_and_lists_come_from_the_repo(self):
         self.assertRegex(device_smoke.app_version(), r"^\d+\.\d+\.\d+$")
         self.assertIn("Lista Hũ", device_smoke.catalog_names())