fix(detail): don't report a looked-up number as "Seen 0 times"

The Report button fills a GitHub issue with how many calls and texts from
the number CallShield has logged. A number looked up by hand has none, and
issues #24 and #27 both arrived saying "Seen 0 times", which reads as if the
reporter had never seen the number. That case now says the number isn't in
the app's log yet.

The issue title and body go to the English-language tracker, so they are
marked translatable="false". The Chinese locale had translated the title to
"[垃圾]", which broke the tracker's "[SPAM]" convention.

Refs #24, #27.

Author: SysAdminDoc

CHANGELOG.md

@@ -238,6 +238,11 @@ All notable changes to CallShield will be documented in this file.
 
 - Tapping the "blocked recently" notification opens the Blocked log now. It
   used to do nothing at all.
+- The Report button on a number's detail page no longer opens a GitHub issue
+  saying the number was "Seen 0 times" when you looked it up by hand. It says
+  the number isn't in the app's log yet. The issue title and body also stay
+  in English whatever language the app runs in, since they go to the
+  English-language tracker (issues #24 and #27 arrived this way).
 - Blocking a number with the Block button at the bottom of Lookup saved the
   name of the check that flagged it ("prefix", "database") as the block's
   note, and Lookup then showed that under Details. It saves the result's

app/src/main/java/com/sysadmindoc/callshield/ui/screens/details/NumberDetailScreen.kt

@@ -94,13 +94,7 @@ fun NumberDetailScreen(
             }
         }
     val reportIssueTitle = stringResource(R.string.detail_report_issue_title, number)
-    val reportIssueBody =
-        pluralStringResource(
-            R.plurals.detail_report_issue_body,
-            numberCalls.size,
-            number,
-            numberCalls.size,
-        )
+    val reportIssueBody = reportIssueBody(context.resources, number, numberCalls.size)
 
     // Contact name resolution
     var contactName by remember(number) { mutableStateOf<String?>(null) }

app/src/main/java/com/sysadmindoc/callshield/ui/screens/details/ReportIssueBody.kt

@@ -0,0 +1,21 @@
+package com.sysadmindoc.callshield.ui.screens.details
+
+import android.content.res.Resources
+import com.sysadmindoc.callshield.R
+
+/**
+ * Body of the GitHub issue the Report button opens. The count is how many
+ * calls and texts from the number CallShield has logged. A number looked up
+ * by hand has none, and "Seen 0 times" read as if the reporter had never
+ * seen it, so that case says what it is instead.
+ */
+fun reportIssueBody(
+    resources: Resources,
+    number: String,
+    loggedEntries: Int,
+): String =
+    if (loggedEntries == 0) {
+        resources.getString(R.string.detail_report_issue_body_unseen, number)
+    } else {
+        resources.getQuantityString(R.plurals.detail_report_issue_body, loggedEntries, number, loggedEntries)
+    }

app/src/main/res/values-zh-rCN/strings.xml

@@ -844,7 +844,6 @@
     <string name="detail_block_area_code_description_location">拦截区号 %1$s（%2$s）</string>
     <string name="detail_blocked_from_detail">从详情拦截</string>
     <string name="detail_whitelisted_from_detail">从详情加入白名单</string>
-    <string name="detail_report_issue_title">[垃圾] %s</string>
     <string name="confidence_suffix">（%d%%）</string>
     <string name="nav_home">主页</string>
     <string name="nav_lookup">查询</string>

app/src/main/res/values/strings.xml

@@ -1210,11 +1210,13 @@
     <string name="detail_unknown_location">Unknown region</string>
     <string name="detail_blocked_from_detail">Blocked from detail</string>
     <string name="detail_whitelisted_from_detail">Trusted from detail screen</string>
-    <string name="detail_report_issue_title">[SPAM] %s</string>
+    <!-- The report title and body open a GitHub issue on the English-language tracker, so they stay in English in every locale. -->
+    <string name="detail_report_issue_title" translatable="false">[SPAM] %s</string>
     <plurals name="detail_report_issue_body">
         <item quantity="one">## Phone Number\n%1$s\n\n## Type\nReported from CallShield\n\n## Description\nSeen %2$d time</item>
         <item quantity="other">## Phone Number\n%1$s\n\n## Type\nReported from CallShield\n\n## Description\nSeen %2$d times</item>
     </plurals>
+    <string name="detail_report_issue_body_unseen" translatable="false">## Phone Number\n%1$s\n\n## Type\nReported from CallShield\n\n## Description\nLooked up in CallShield. No calls or texts from this number are in the app\'s log yet.</string>
     <string name="confidence_suffix"> (%d%%)</string>
     <plurals name="detail_reports_count_plural">
         <item quantity="one">%d report</item>

app/src/test/java/com/sysadmindoc/callshield/ui/screens/details/ReportIssueBodyTest.kt

@@ -0,0 +1,42 @@
+package com.sysadmindoc.callshield.ui.screens.details
+
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.robolectric.RobolectricTestRunner
+import org.robolectric.annotation.Config
+
+@RunWith(RobolectricTestRunner::class)
+@Config(sdk = [34])
+class ReportIssueBodyTest {
+    private val resources = ApplicationProvider.getApplicationContext<Context>().resources
+
+    @Test
+    fun `a number with nothing in the log isn't reported as seen zero times`() {
+        // Issues #24 and #27 both arrived as "Seen 0 times": the reporter had
+        // looked the number up by hand, so nothing from it was in the log.
+        val body = reportIssueBody(resources, "+18056377456", 0)
+
+        assertTrue(body, body.contains("+18056377456"))
+        assertTrue(body, body.contains("No calls or texts"))
+        assertFalse(body, body.contains("Seen 0"))
+    }
+
+    @Test
+    fun `logged calls and texts are counted`() {
+        assertTrue(reportIssueBody(resources, "+18056377456", 1).endsWith("Seen 1 time"))
+        assertTrue(reportIssueBody(resources, "+18056377456", 3).endsWith("Seen 3 times"))
+    }
+
+    @Test
+    fun `the body keeps the tracker's headings whatever the count`() {
+        for (count in listOf(0, 2)) {
+            val body = reportIssueBody(resources, "+18056377456", count)
+            assertTrue(body, body.startsWith("## Phone Number\n+18056377456\n\n## Type\n"))
+            assertTrue(body, body.contains("\n\n## Description\n"))
+        }
+    }
+}