fix(ui): keep a hint asked for as the last one closes

When a permission hint's snackbar finished in the same frame a second
hint was asked for, the first one's effect resumed after the second was
set and cleared it, so the second hint never showed. The effect now
clears the pending hint only when it's still its own.

Found by the batch verification pass on 671824c.

Tests: one new PermissionHintTest case closes the first snackbar and asks
for the Default apps hint in one main-thread step, then waits for it. No
existing test changed. Without the identity check it fails with a
ComposeTimeoutException after 10 s.

Author: SysAdminDoc

README.md

@@ -12,7 +12,7 @@
 <p align="center">
   <a href="https://github.com/SysAdminDoc/CallShield/releases/latest"><img src="https://img.shields.io/github/v/release/SysAdminDoc/CallShield?style=flat-square&color=a6e3a1" alt="Release"></a>
   <img src="https://img.shields.io/badge/Spam%20Numbers-51%2C403-f38ba8?style=flat-square" alt="51,403 Numbers">
-  <img src="https://img.shields.io/badge/JVM%20unit%20tests-2070-94e2d5?style=flat-square" alt="2070 JVM unit tests">
+  <img src="https://img.shields.io/badge/JVM%20unit%20tests-2071-94e2d5?style=flat-square" alt="2071 JVM unit tests">
   <img src="https://img.shields.io/badge/Android-10%2B-89b4fa?style=flat-square" alt="Android 10+">
   <img src="https://img.shields.io/badge/License-MIT-cba6f7?style=flat-square" alt="MIT License">
   <img src="https://img.shields.io/badge/API%20Keys-None-fab387?style=flat-square" alt="No required API keys">
@@ -592,12 +592,12 @@ RELEASE_KEY_PASSWORD=...
 ## Testing
 
 ```bash
-./gradlew testDebugUnitTest   # 2070 tests
+./gradlew testDebugUnitTest   # 2071 tests
 ./gradlew connectedDebugAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.sysadmindoc.callshield.platform.TargetSdkBehaviorSmokeTest
 ./gradlew verifyPipelineTests # Cloudflare Worker (node) + data-pipeline and translation checks (python)
 ```
 
-The suite is **2070 total JVM unit tests**, run with Robolectric wherever a screen, a service or the database is involved.
+The suite is **2071 total JVM unit tests**, run with Robolectric wherever a screen, a service or the database is involved.
 
 Two GitHub workflows run without building the app. **Validation** runs the Worker and
 pipeline suites on every push except report-only ones (`run-pipeline-tests.ps1 -CorrectnessOnly`),
@@ -634,7 +634,7 @@ language in [issue #7](https://github.com/SysAdminDoc/CallShield/issues/7).
 | Community API | Cloudflare Workers |
 | URL Safety | Local spam-domain data, with optional PhishTank and OpenPhish |
 | Verification | Local Gradle, lint, and release-artifact checks |
-| Tests | 2070 JVM unit tests (JUnit) |
+| Tests | 2071 JVM unit tests (JUnit) |
 | Strings | 1796 string resources and 49 plural groups (translation-ready) |
 | Accessibility | 100+ content descriptions, 48dp touch targets |
 | Min SDK | 29 (Android 10) |

app/src/main/java/com/sysadmindoc/callshield/ui/PermissionRecovery.kt

@@ -116,7 +116,8 @@ fun PermissionHintsHost(
             hints.snackbars.currentSnackbarData?.dismiss()
             val result = hints.snackbars.showSnackbar(SettingsHintVisuals(message, actionLabel))
             if (result == SnackbarResult.ActionPerformed) context.startActivitySafely(hint.page.intent(context))
-            hints.pending = null
+            // A newer hint asked for as this one closed is still waiting to show.
+            if (hints.pending === hint) hints.pending = null
         }
     }
     SnackbarHost(hints.snackbars, modifier) { Snackbar(it, actionOnNewLine = it.visuals is SettingsHintVisuals) }

app/src/test/java/com/sysadmindoc/callshield/ui/PermissionHintTest.kt

@@ -235,6 +235,30 @@ class PermissionHintTest {
         assertEquals(Settings.ACTION_MANAGE_DEFAULT_APPS_SETTINGS, awaitStartedActivity().action)
     }
 
+    @Test
+    fun `a hint asked for just as the last one closes still shows`() {
+        var hints: PermissionHints? = null
+        var askForRole: () -> Unit = {}
+        show {
+            hints = LocalPermissionHints.current
+            val appInfo = rememberPermissionRequest(R.string.permission_core_in_app_info)
+            val role = rememberRoleRequest(R.string.role_call_screening_in_default_apps, roleHeld = { false })
+            askForRole = { role(Intent("test.REQUEST_ROLE")) }
+            Button(onClick = { appInfo(listOf(Manifest.permission.READ_CALL_LOG)) }) { Text("Ask") }
+        }
+        composeRule.onNodeWithText("Ask").performClick()
+        awaitText(composeRule.activity.getString(R.string.permission_core_in_app_info))
+
+        // The first snackbar closes, and the second hint is asked for before
+        // the first one's effect gets to run again.
+        composeRule.runOnUiThread {
+            hints!!.snackbars.currentSnackbarData!!.dismiss()
+            askForRole()
+        }
+
+        awaitText(composeRule.activity.getString(R.string.role_call_screening_in_default_apps))
+    }
+
     @Test
     fun `with no hint host App info opens straight away`() {
         show(withHost = false) {