Repository navigation
Commit f87fc9f
Fix review findings on Cargo [patch] shadowing and bypass details
Review on #2024 (/code-review high), round 4:
- The "resolves it only from other Socket patches" diagnostic fired
beside a same-version crates.io twin; it now needs a lock with no
non-Socket entry of the crate.
- Shadow resolves a [patch.<registry>] table through the config's
[registries] index, so a config [patch."<index>"] item shadows it.
- An identical path-less Socket registry [patch] pin in the manifest and
the config is the same wiring, not a shadow.
- patched_by (registry-index) and same_patch_source share
patch_source_key, with CanonicalUrl rules on both.
- patch_bypassed's conflict-gate check matches the CLI's bypassed_ref
(file-scoped marks only); it routes each declaration once; its detail
also names other-patch declarations; a git lock entry a git [patch]
table redirects gets the stale/re-lock remedy.
- Reuse patch::redirect::is_crates_io_source for lock sources.
- Move the manifests comment back above its vector.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 5d99eb0 commit f87fc9f
2 files changed
Lines changed: 229 additions & 70 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2538 | 2538 | | |
2539 | 2539 | | |
2540 | 2540 | | |
2541 | | - | |
| 2541 | + | |
2542 | 2542 | | |
2543 | 2543 | | |
2544 | 2544 | | |
| |||
0 commit comments