@@ -439,6 +439,53 @@ async fn opt_in_note_renders_and_persists_in_human_and_json_get() {
439439 assert_eq ! ( event[ "details" ] [ "optInNote" ] , NOTE ) ;
440440}
441441
442+ #[ tokio:: test]
443+ async fn get_json_uses_fetched_view_instead_of_stale_search_opt_in_metadata ( ) {
444+ const STALE : & str = "Stale search instruction." ;
445+ const LATEST : & str = "Latest view instruction." ;
446+ let server = MockServer :: start ( ) . await ;
447+ let cve = "CVE-2024-4246" ;
448+ Mock :: given ( method ( "GET" ) )
449+ . and ( path ( format ! ( "/v0/orgs/{ORG}/patches/by-cve/{cve}" ) ) )
450+ . respond_with ( ResponseTemplate :: new ( 200 ) . set_body_json ( serde_json:: json!( {
451+ "patches" : [ {
452+ "uuid" : UUID , "purl" : PURL ,
453+ "publishedAt" : "2024-01-01T00:00:00Z" ,
454+ "description" : "View metadata is authoritative" ,
455+ "license" : "MIT" , "tier" : "free" , "vulnerabilities" : { } ,
456+ "requiresOptIn" : false , "optInNote" : STALE ,
457+ } ] ,
458+ "canAccessPaidPatches" : false ,
459+ } ) ) )
460+ . mount ( & server)
461+ . await ;
462+ let mut view = view_json ( UUID , PURL , good_files ( ) ) ;
463+ view[ "requiresOptIn" ] = serde_json:: json!( true ) ;
464+ view[ "optInNote" ] = serde_json:: json!( LATEST ) ;
465+ Mock :: given ( method ( "GET" ) )
466+ . and ( path ( format ! ( "/v0/orgs/{ORG}/patches/view/{UUID}" ) ) )
467+ . respond_with ( ResponseTemplate :: new ( 200 ) . set_body_json ( view) )
468+ . mount ( & server)
469+ . await ;
470+ let tmp = tempfile:: tempdir ( ) . unwrap ( ) ;
471+
472+ let ( code, stdout, stderr) =
473+ run_get_bin ( tmp. path ( ) , & server. uri ( ) , & [ cve, "--save-only" , "--json" ] ) ;
474+ assert_eq ! ( code, 0 , "stdout={stdout}\n stderr={stderr}" ) ;
475+ let envelope: serde_json:: Value = serde_json:: from_str ( & stdout) . unwrap ( ) ;
476+ let event = envelope[ "events" ]
477+ . as_array ( )
478+ . unwrap ( )
479+ . iter ( )
480+ . find ( |event| event[ "uuid" ] == UUID )
481+ . unwrap ( ) ;
482+ assert_eq ! ( event[ "details" ] [ "requiresOptIn" ] , true , "{event}" ) ;
483+ assert_eq ! ( event[ "details" ] [ "optInNote" ] , LATEST , "{event}" ) ;
484+ let record = & manifest_json ( tmp. path ( ) ) [ "patches" ] [ PURL ] ;
485+ assert_eq ! ( record[ "requiresOptIn" ] , true ) ;
486+ assert_eq ! ( record[ "optInNote" ] , LATEST ) ;
487+ }
488+
442489#[ tokio:: test]
443490async fn changed_view_opt_in_note_is_not_suppressed_in_nested_apply ( ) {
444491 const PREVIEW_NOTE : & str = "Preview configuration instruction." ;
@@ -846,6 +893,104 @@ async fn human_vendored_uuid_rerun_prints_already_vendored_skip() {
846893 assert ! ( artifact. is_file( ) , "stdout={stdout}\n stderr={stderr}" ) ;
847894}
848895
896+ #[ tokio:: test]
897+ async fn vendored_same_uuid_view_refresh_updates_state_list_and_vex ( ) {
898+ const NOTE : & str = "Set `safeMode` to `true`; defaults remain vulnerable." ;
899+ let server = MockServer :: start ( ) . await ;
900+ let files = serde_json:: json!( {
901+ "package/index.js" : {
902+ "beforeHash" : git_hash( BEFORE_BYTES ) ,
903+ "afterHash" : git_hash( AFTER_BYTES ) ,
904+ "blobContent" : b64( AFTER_BYTES ) ,
905+ }
906+ } ) ;
907+ let mut view = view_json ( UUID , PURL , files) ;
908+ view[ "vulnerabilities" ] = serde_json:: json!( {
909+ GHSA : {
910+ "cves" : [ "CVE-2024-4247" ] ,
911+ "summary" : "Activation metadata refresh" ,
912+ "severity" : "high" ,
913+ "description" : "d" ,
914+ }
915+ } ) ;
916+ Mock :: given ( method ( "GET" ) )
917+ . and ( path ( format ! ( "/v0/orgs/{ORG}/patches/view/{UUID}" ) ) )
918+ . respond_with ( ResponseTemplate :: new ( 200 ) . set_body_json ( view. clone ( ) ) )
919+ . mount ( & server)
920+ . await ;
921+ crate :: prebuilt_common:: mount_view ( & server, & view, None ) . await ;
922+ let tmp = tempfile:: tempdir ( ) . unwrap ( ) ;
923+ write_project ( tmp. path ( ) ) ;
924+
925+ let ( code, stdout, stderr) = run_get_bin (
926+ tmp. path ( ) ,
927+ & server. uri ( ) ,
928+ & [
929+ UUID ,
930+ "--mode" ,
931+ "vendored" ,
932+ "--vendor-source" ,
933+ "service" ,
934+ "--json" ,
935+ ] ,
936+ ) ;
937+ assert_eq ! ( code, 0 , "initial vendor: stdout={stdout}\n stderr={stderr}" ) ;
938+ let entry = & vendor_state ( tmp. path ( ) ) [ "entries" ] [ PURL ] ;
939+ assert ! ( entry[ "record" ] . get( "requiresOptIn" ) . is_none( ) ) ;
940+ assert ! ( entry[ "record" ] . get( "optInNote" ) . is_none( ) ) ;
941+ let artifact = tmp
942+ . path ( )
943+ . join ( ".socket/vendor/npm" )
944+ . join ( UUID )
945+ . join ( format ! ( "{NAME}-1.0.0.tgz" ) ) ;
946+ let artifact_before = std:: fs:: read ( & artifact) . unwrap ( ) ;
947+
948+ server. reset ( ) . await ;
949+ view[ "requiresOptIn" ] = serde_json:: json!( true ) ;
950+ view[ "optInNote" ] = serde_json:: json!( NOTE ) ;
951+ Mock :: given ( method ( "GET" ) )
952+ . and ( path ( format ! ( "/v0/orgs/{ORG}/patches/view/{UUID}" ) ) )
953+ . respond_with ( ResponseTemplate :: new ( 200 ) . set_body_json ( view) )
954+ . mount ( & server)
955+ . await ;
956+ let ( code, stdout, stderr) = run_get_bin (
957+ tmp. path ( ) ,
958+ & server. uri ( ) ,
959+ & [ UUID , "--mode" , "vendored" , "--vendor-source" , "service" ] ,
960+ ) ;
961+ assert_eq ! ( code, 0 , "reused vendor: stdout={stdout}\n stderr={stderr}" ) ;
962+ let entry = & vendor_state ( tmp. path ( ) ) [ "entries" ] [ PURL ] ;
963+ assert_eq ! ( entry[ "record" ] [ "requiresOptIn" ] , true , "{entry}" ) ;
964+ assert_eq ! ( entry[ "record" ] [ "optInNote" ] , NOTE , "{entry}" ) ;
965+ assert_eq ! ( std:: fs:: read( & artifact) . unwrap( ) , artifact_before) ;
966+
967+ let ( code, stdout, stderr) = crate :: common:: run_with_env (
968+ tmp. path ( ) ,
969+ & [ "list" , "--offline" ] ,
970+ & [ ( "SOCKET_TELEMETRY_DISABLED" , "1" ) ] ,
971+ ) ;
972+ assert_eq ! ( code, 0 , "list: stdout={stdout}\n stderr={stderr}" ) ;
973+ assert ! (
974+ stdout. contains( & format!( "Opt-in required: {NOTE}" ) ) ,
975+ "{stdout}"
976+ ) ;
977+
978+ let ( code, stdout, stderr) = crate :: common:: run_with_env (
979+ tmp. path ( ) ,
980+ & [ "vex" , "--no-verify" ] ,
981+ & [ ( "SOCKET_TELEMETRY_DISABLED" , "1" ) ] ,
982+ ) ;
983+ assert_eq ! ( code, 0 , "vex: stdout={stdout}\n stderr={stderr}" ) ;
984+ let document: serde_json:: Value = serde_json:: from_str ( & stdout) . unwrap ( ) ;
985+ let impact = document[ "statements" ] [ 0 ] [ "impact_statement" ]
986+ . as_str ( )
987+ . unwrap ( ) ;
988+ assert ! (
989+ impact. contains( & format!( "opt-in required: {NOTE}" ) ) ,
990+ "{document}"
991+ ) ;
992+ }
993+
849994/// Agent-mode `--dry-run` (search path) previews and writes NOTHING: no
850995/// `.socket/`, no view fetch, no prompt, exit 0.
851996#[ tokio:: test]
0 commit comments