You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9bac91f
Browse filesBrowse the repository at this point in the historyBrowse files
Scrub ambient Go env from spawned test children (#2063)
A developer or runner that exports GOWORK, GOFLAGS=-modfile=...,
GOMODCACHE or GOPATH (or sets them with `go env -w`) leaks them into
every socket-patch and `go` child the CLI tests spawn. With
GOWORK=<file> exported, every `go mod download` in the Go suites'
staging fails; with GOFLAGS=-modfile=... Go vendor refuses to write
its replace. e2e_golang_build failed 21/21 and e2e_vendor_golang_build
11/13 that way on a clean checkout.
Add hermetic::Extra::Go (remove GOFLAGS, GOWORK, GOPATH, GOMODCACHE;
set GOENV=off) and apply it to CRAWLER_EXTRAS, to every child of
common::run_bin_with_env, and to the go/socket-patch spawn helpers
of e2e_golang_build, e2e_golang_hosted_build and
e2e_vendor_golang_build. Tests that need a value still set it after
the scrub. A spawn_env_hygiene self-test pins the scrub.
Part of #1981 (items 1-2).
Claude-Session: https://claude.ai/code/session_011f9aeR7CFpkqZDdd9hfYmM
Co-authored-by: Claude <noreply@anthropic.com>
0 commit comments