You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8b59a5a
Browse filesBrowse the repository at this point in the historyBrowse files
Address the second code review of the pnpm planner PR
- The hosted confirmation probe skips a pnpm lock pnpm does not read
(N11): a stale Socket URL in a shadowed shrinkwrap.yaml confirmed the
dependency, which the attribution gate then dropped as
redirect_unattributable.
- The pnpm trust/heal post-pass takes the governing root lock from
planned_locks, so under a pnpm 1 / 2 pin a stray v9 pnpm-lock.yaml no
longer plans a trustLockfile write.
- Mixed line endings get their own error type instead of overloading
io::ErrorKind::Unsupported, which an OS ENOTSUP read also returns;
read_pnpm_text normalizes through utils::line_endings::to_lf.
- The pnpm pin is read only when both pnpm-lock.yaml and
shrinkwrap.yaml exist (planned_locks, vendoring, discovery).
- Docs: divergences N16 names the two checks; read_project refuses
mixed endings, not CRLF.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: docs/design/lock-model-divergences.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -96,7 +96,7 @@ follow from the install-tree decision. N11 was decided on 2026-11-05.
96
96
| N13 | Plug'n'Play | Vendored refuses. The hosted berry preflight has no PnP gate. The inventory returns an error, so `scan` sees nothing in a project hosted pinned. | The inventory reads PnP locks. Vendored keeps its refusal. | target-specific (vendored) |
97
97
| N14 | pnpm `lockfile=false`| Hosted refuses. Discovery withholds hosted refs, keeps vendored ones. Vendored proceeds. The inventory ignores the setting. | The modes stay as they are; the inventory follows discovery. **Resolved in PR 2a (#2009)**: under the setting (not under Rush), the inventory keeps a Socket-hosted pnpm entry but drops its integrity, as discovery withholds the lock pin. | target-specific |
98
98
| N15 | CRLF `pnpm-lock.yaml` / `pnpm-workspace.yaml`| Vendored refuses; the rest handle it | Handle it everywhere. **Resolved in PR 2b (#2029)**: the vendored planner and reverter edit a CRLF lock or workspace file like its LF twin and write it back CRLF. Only a file mixing CRLF and LF is still refused (`vendor_lockfile_crlf_unsupported`), since no single ending writes it back byte-faithfully. ||
99
-
| N16 | Lock versions | pnpm: vendored accepts only 5.4/6.0/9.0; hosted any but early shrinkwrap. vlt: vendored refuses a lock with no version; hosted rewrites and warns. | Hosted. **pnpm, PR 2b (#2029)**: one table, `plan::Target::check_lock`. Vendored keeps its 5.4/6.0/9.0 range: no other version has a captured pnpm `file:` override shape that proves its rekey, so the other versions stay refused, target-specifically. vlt is unchanged. | target-specific (pnpm vendored) |
99
+
| N16 | Lock versions | pnpm: vendored accepts only 5.4/6.0/9.0; hosted any but early shrinkwrap. vlt: vendored refuses a lock with no version; hosted rewrites and warns. | Hosted. **pnpm, PR 2b (#2029)**: two target-specific checks: hosted refuses only pnpm 1's early shrinkwrap (`plan::hosted_refuses_lock`), and the vendored dialects route by `formats::pnpm::sniff_lock_grammar` (`PnpmDialect::check_lock`). Vendored keeps its 5.4/6.0/9.0 range: no other version has a captured pnpm `file:` override shape that proves its rekey, so the other versions stay refused, target-specifically. vlt is unchanged. | target-specific (pnpm vendored) |
100
100
| N17 | Bun workspaces, yarn classic offline mirror | Refused differently by the two modes | Stays | target-specific |
101
101
| N18 | An unparseable npm lock | Hosted warns and skips. Vendored refuses the primary lock. Discovery diagnoses. The inventory returns nothing silently. | Discovery's diagnostic, surfaced by every consumer ||
102
102
| N19 | yarn.lock with a stray top-level line | Discovery rejects the file; hosted and the inventory scan its blocks | Discovery's rule ||
0 commit comments