Skip to content

Commit 237307e

Browse files
mikolalysenkoclaude
andcommitted
Keep coordinate docs on the no-profile reading after the #2020 merge
ScopedDep coordinates here are the no-profile value, with every profile reading carried by coordinate_alternatives, and the hosted index reads profile <properties> too: restate both docs #2020's round-3 merge brought in for its own branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 791ded0 commit 237307e

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

  • crates/socket-patch-core/src/formats/maven

‎crates/socket-patch-core/src/formats/maven/mod.rs‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,9 @@ struct ProfileProperties {
176176
/// classpaths, `<pluginRepositories>` / `<distributionManagement>` plugin
177177
/// and deploy repositories; `<profiles>` apply only when activated. Shared
178178
/// by the VEX reader ([`parse_pom`]) and the hosted rewriter, so the
179-
/// rewriter edits exactly the markup VEX later attests. Only the VEX
180-
/// reader weighs profile `<properties>` ([`Self::read_profiles`]).
179+
/// rewriter edits exactly the markup VEX later attests. Both the VEX
180+
/// reader and the hosted rewriter's index weigh profile `<properties>`
181+
/// ([`Self::read_profiles`]).
181182
#[derive(Debug)]
182183
pub(crate) struct PomScope {
183184
/// The pom with comments and CDATA blanked byte-for-byte.
@@ -555,15 +556,12 @@ fn inside(pos: usize, set: &[Element]) -> bool {
555556
pub(crate) struct ScopedDep {
556557
pub(crate) element: Element,
557558
/// `<groupId>` / `<artifactId>` with every `${prop}` the build defines
558-
/// (user properties, the project model, the root `<properties>`)
559-
/// interpolated ([`PomScope::interpolate_coordinate`]); an undefined
560-
/// one stays as written, so [`may_name`] can tell it apart. No profile
561-
/// is active but, for a `<profiles>` declaration, its own, whose
562-
/// `<properties>` count only once [`PomScope::read_profiles`] has run:
563-
/// the VEX reader runs it, the hosted rewriter does not, so a profile
564-
/// declaration whose coordinates only its own profile's `<properties>`
565-
/// define is the pinned GA to VEX (which then withholds the pin) and
566-
/// not to the rewriter.
559+
/// with no profile active (user properties, the project model, the
560+
/// root `<properties>`) interpolated
561+
/// ([`PomScope::interpolate_coordinate`]); an undefined one stays as
562+
/// written, so [`may_name`] can tell it apart. What a profile (a
563+
/// `<profiles>` declaration's own included) makes of them is
564+
/// [`PomScope::coordinate_alternatives`]' job.
567565
pub(crate) group: Option<String>,
568566
pub(crate) artifact: Option<String>,
569567
/// The trimmed `<groupId>` / `<artifactId>` text as written.

0 commit comments

Comments
 (0)