You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit af3e558
Browse filesBrowse the repository at this point in the historyBrowse files
fix(scan): make every discovered ecosystem facts-only under --dynamic-sbom-inference
Coana was told NuGet artifacts come only from facts files when some .NET
build root happened to produce facts, and Maven always. Which raw
manifests reachability and fix trusted therefore depended on what other
build roots produced. Every ecosystem a build root was discovered for is
now facts-only, generated or not; Maven alone keeps the older flag.
When Coana consumes the facts, a .NET build root without a usable SDK
now fails before any build runs instead of silently losing its
dependencies, reachability fails clearly when no build root produced
facts (Coana refuses such a run), and roots skipped in socket.json get a
warning that the analysis leaves them out. Callers now name the facts
consumer (fix or reach) instead of passing withFiles/sidecar flags.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: CHANGELOG.md
+6Lines changed: 6 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
4
4
5
5
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
6
6
7
+
## [Unreleased]
8
+
9
+
### Changed
10
+
- With `--dynamic-sbom-inference`, reachability analysis and `socket fix` now take the dependencies of every Gradle, sbt, Maven and .NET build they find from Socket facts only, so results no longer depend on which other builds produced facts.
11
+
- With `--dynamic-sbom-inference`, reachability analysis and `socket fix` now stop with clear next steps when a .NET build cannot be read because no .NET SDK is installed, and warn that builds skipped in `socket.json` are left out. Reachability analysis also stops with next steps when no build produced Socket facts.
`No .NET SDK runs for ${displayPath(buildRootPath(root))} (${reason}), so it has no Socket facts, and the analysis takes .NET dependencies only from them.`,
225
+
'',
226
+
'- Install the .NET SDK, or point defaults.manifest.dotnet.bin in socket.json at one.',
227
+
'- Or leave it out with --exclude-paths, or with defaults.manifest.dotnet.disabled in socket.json.',
228
+
].join('\n'),
229
+
)
230
+
}
231
+
}elseif(
216
232
ecosystem==='dotnet'&&
217
233
// eslint-disable-next-line no-await-in-loop
218
234
(awaitskipWithoutDotnetSdk(dirConfig.bin,dir))
@@ -355,6 +371,7 @@ export async function generateRecursiveManifests({
355
371
excludePaths,
356
372
ignoreUnresolved,
357
373
optionFlags =newSet(),
374
+
requireDotnetSdk,
358
375
sbtTmpDir,
359
376
sidecarAcc,
360
377
verbose,
@@ -367,6 +384,8 @@ export async function generateRecursiveManifests({
367
384
// Options the invoking command takes as flags; hints send the rest to each
368
385
// build root's socket.json.
369
386
optionFlags?: ReadonlySet<BuildOption>|undefined
387
+
// Fail instead of skipping a .NET build root no .NET SDK can build.
388
+
requireDotnetSdk?: boolean|undefined
370
389
// Reachability path only: caller-supplied directory to use as sbt's shared
371
390
// global base across every sbt root in this run. sbt provisions the Scala
372
391
// toolchain under `<base>/boot`, which withFiles' artifactPaths point into,
@@ -405,6 +424,7 @@ export async function generateRecursiveManifests({
0 commit comments