Repository navigation
Commit 421bd9f
authored
fix: run Bazel Maven scans on Windows (#1658)
* fix: run Bazel Maven scans on Windows
Generate Maven manifests with native Windows tools. Preserve paths
and arguments, use the scan environment for prerequisite checks,
and clean up servers started by the connector.
Add pinned Windows fixtures and packaged CLI checks.
Assisted-by: Codex:GPT-6
* fix: keep native Windows executable paths
Use executable lookup before unwrapping Node launchers so native
Bazel and Python executables remain runnable. Keep custom batch
wrappers intact and invoke their selected paths.
Pin the existing which version without changing resolutions.
Assisted-by: Codex:GPT-6
* test: handle Windows executable path casing
Compare executable identity so case-insensitive Windows paths do
not fail when PATHEXT uses an uppercase extension.
Assisted-by: Codex:GPT-6
* fix: only stop Bazel servers this scan started
Ask Bazel for the effective output base before shutdown, so an rc
file that selects a caller-owned output base keeps its server alive.
Skip every socket-bazel- output directory during workspace discovery,
and strip quotes from PATH entries before resolving them.
Simplify the Windows process helpers. Use one environment key lookup,
one batch escaper and one Python shim result shape, require explicit
env and cwd, shut down servers in parallel, and cancel superseded
Windows CI runs.
Assisted-by: Claude Code:claude-opus-5-5
* fix: stop servers the scan started, keep inputs
Shut down any Bazel server whose install or output base is in the
scan's own root, including one started in an explicit output base,
and always remove the root afterwards, even when Bazel cannot report
its bases. A python on PATH that is not Python 3 falls back to
python3. Quotes in Bazel flags only open at the start of a value or
after =, so apostrophes stay literal. A relative --bazel resolves
against the current directory again. The Windows Bazel workflow runs
only for Bazel changes.
Assisted-by: Claude Code:claude-opus-5-5
* fix: stop launcher trees and verify server exit
A Bazel timeout or cancellation now kills every process a launcher
started, through a process group on Unix and taskkill on Windows. If
something still holds the output pipes, the call settles after a short
grace period. Timeouts surface as BazelTimeoutError.
Cleanup runs under its own time limit, so it still works after Ctrl-C
aborts the scan. It reads the pid of each server the scan owns before
shutdown, waits for that server to exit, and kills it if shutdown left
it running. The output root is kept only while an owned server is
still alive. Real Bazel tests cover timeout and cancellation behind a
JavaScript launcher, and behind a batch launcher on Windows.
Assisted-by: Claude Code:claude-opus-5-5
* fix: keep scans passing when pid files can't be read
Bazel cleanup runs after a scan has produced its manifests. An
unreadable server pid file made cleanup throw and failed the scan.
Cleanup now warns, still shuts down the servers it knows about, and
keeps the output root because it can't confirm the servers stopped.
Assisted-by: Claude Code:claude-opus-5-5
* fix: report cancelled Bazel runs as aborted on Windows
On Windows, stopping a cancelled Bazel run kills the launcher before
the abort reaches the spawn, so the run failed with the launcher's exit
code. It now fails with an AbortError like on other platforms. The
escaped-process test also waits for its child to exit, because Windows
keeps the temporary directory locked until then.
Assisted-by: Claude Code:claude-opus-5-51 parent ea8ec86 commit 421bd9f
31 files changed
Lines changed: 2272 additions & 845 deletions
File tree
- .github/workflows
- src/commands/manifest/bazel
- test/fixtures/manifest-bazel/native
- bzlmod
- workspace
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
12 | 23 | | |
13 | 24 | | |
14 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| 201 | + | |
201 | 202 | | |
202 | 203 | | |
203 | 204 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | | - | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
5 | 8 | | |
6 | 9 | | |
7 | 10 | | |
| |||
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| 21 | + | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | | - | |
| 25 | + | |
| 26 | + | |
21 | 27 | | |
22 | | - | |
| 28 | + | |
23 | 29 | | |
24 | 30 | | |
25 | | - | |
| 31 | + | |
26 | 32 | | |
27 | 33 | | |
28 | | - | |
| 34 | + | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
32 | | - | |
| 38 | + | |
33 | 39 | | |
34 | 40 | | |
35 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
2 | 10 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
| 14 | + | |
11 | 15 | | |
12 | 16 | | |
13 | | - | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | | - | |
| 20 | + | |
17 | 21 | | |
18 | 22 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
29 | 54 | | |
30 | 55 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
35 | 63 | | |
| 64 | + | |
36 | 65 | | |
37 | 66 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
44 | 73 | | |
| 74 | + | |
45 | 75 | | |
46 | 76 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
51 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
52 | 94 | | |
53 | 95 | | |
0 commit comments