You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3c5eced
Browse filesBrowse the repository at this point in the historyBrowse files
feat(manifest): name failing JVM dependencies and remedies the command accepts (#1638)
* feat(manifest): name failing JVM dependencies and remedies the command accepts
When dependency resolution fails, the report now names the dependency that
failed, the subproject and scope that needed it, and only remedies the
invoking command actually accepts:
- Single-build manifest commands suggest their flags; `socket manifest
dynamic-sbom-inference` gains --ignore-unresolved; scan/fix/auto-manifest
point at the failing build's own socket.json and its setup wizard.
- Maven no longer reports a dependency-graph failure as a `graph`
configuration against the module itself: it names the failing dependency
and the scope it has in the graph, so excluding that scope clears it.
- Unresolved dependencies are reported and left out of the facts for Maven,
Gradle and sbt alike. sbt retries leniently instead of excluding modules,
so an unresolved dependency no longer empties the whole project.
- socket.json `verbose` is honored on the dynamic-sbom-inference path, a build
tool that cannot start says why, and scan create/reach warn about build
flags they read from socket.json instead.
* test(manifest): put each compat JDK on PATH so sbt rows use it
The sbt launcher runs java from PATH and ignores JAVA_HOME, so every sbt row
ran on whatever JDK came first on PATH (and sbt 0.13 failed on a modern one).
* fix(manifest): print a usable socket.json path and skip an empty abort warning
A build root outside the shell's directory got a socket.json hint that climbed
to the filesystem root; it now gets the absolute path. A failed last build root
no longer warns that the remaining roots cannot be classified.
* fix(manifest): stream build-tool output to stderr
With verbose set in socket.json, Maven's log was inherited onto stdout and
broke --json output. Streamed build output is a diagnostic, so it now goes to
stderr on every path.
* fix(manifest): give each sbt failure its own module's message
Every failure carried the whole batch resolve message, so the records grew
quadratically with the number of failed modules. Each failure now keeps only
its module's part of the message.
Copy file name to clipboardExpand all lines: CHANGELOG.md
+13Lines changed: 13 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,6 +4,19 @@ All notable changes to this project will be documented in this file.
4
4
5
5
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
6
6
7
+
## [Unreleased]
8
+
9
+
### Added
10
+
-`socket manifest dynamic-sbom-inference --ignore-unresolved` keeps going past unresolved JVM dependencies in every discovered build.
11
+
12
+
### Fixed
13
+
-`--dynamic-sbom-inference` honors each build's `verbose` setting in `socket.json`.
14
+
- JVM resolution failures name the dependency that failed, the subproject and scope that needed it, and suggest only options the command you ran accepts, pointing at the failing build's own `socket.json`.
15
+
- Unresolved JVM dependencies are reported and left out of the Socket facts for Maven, Gradle and sbt alike, as far as each build tool identifies them; a Maven dependency in an excluded scope no longer blocks the run.
16
+
- An sbt project with an unresolved dependency keeps the rest of its dependencies instead of silently losing all of them.
17
+
-`socket scan create` and `socket scan reach` warn about `--ignore-unresolved`, `--exclude-configs`, `--include-configs` and `--verbose`, which they read from `socket.json` instead.
18
+
- When a build tool cannot be started, the error says why, for example a missing `mvn`.
"Warn on unresolved dependencies instead of failing the run (unresolved deps are not emitted to the facts files); overrides each build's socket.json setting",
--exclude-paths List of glob patterns to exclude from manifest/facts generation. Patterns are anchored micromatch globs matched relative to CWD (\`--cwd\` if set): \`tests\` matches only \`<cwd>/tests\`; use \`**/tests\` to match at any depth. Negation patterns (\`!path\`) are not supported. Accepts a comma-separated value or multiple flags.
37
+
--ignore-unresolved Warn on unresolved dependencies instead of failing the run (unresolved deps are not emitted to the facts files); overrides each build's socket.json setting
`Aborting ${ecosystem} discovery: ${dir}'s workspace layout could not be determined, so its remaining build roots cannot be safely classified as covered or independent.`,
178
-
)
179
-
for(constabortedDirofdirs.slice(dirIndex+1)){
197
+
constabortedDirs=dirs.slice(dirIndex+1)
198
+
if(abortedDirs.length){
199
+
logger.warn(
200
+
`Aborting ${ecosystem} discovery: ${dir} failed to generate Socket facts, and without them the remaining build roots cannot be safely classified as covered or independent.`,
0 commit comments