SPFx 1.22.0-beta.2 - Feedback

[Adam Wójcik (Adam-it)]

Hey team,
I created this discussion to gather some of my (and I hope also other folks) feedback regarding SPFx 1.22.0 -beta.2

[Adam Wójcik (Adam-it)]

💬 Suggestion
Super awesome to see the reduction of vulnerabilities from 90 to 19 🤩👏.
I guess this will help explain it to our customers
BUT I would also recommend adding somewhere in the docs a detailed explanation about the remaining 19 vulnerabilities and why they pose no (or little risk) to the end product/app that is developed. This will give us (developers/architects) a common reference point to which we may point our customers when such questions arise

[Adam Wójcik (Adam-it)]

✅ Positive feed
So far I played with only webparts with no-framework and React and:

• the build is indeed a lot faster on windows machines 🚀
• all the typical scenarios like serving on the workbench or deploying on the site and serving for debugging or just production deploying and exposing as Teams Tab or Personal App work properly ✅

[Adam Wójcik (Adam-it)]

❓Question
Why in the package.json we need "overrides": { "@rushstack/heft": "0.74.3" } ?
If most of the build toolchain/packages are now owned by Microsoft couldn't we align the heft version in all of those instead of having to override the version? Also I think Heft is already 1.0.0, I think it would better to use this version of package in the scaffolded project as well

[Adam Wójcik (Adam-it)]

💬 Suggestion
Awesome to see the npm scripts now wrap most of the heft commands (previously with gulp it wasn't the case). I would only suggest to consider:

• npm publish script which would be a combination of heft build --clean && heft package-solution --production. We already saw in many places similar suggestion or features in the past when gulp was used and this was also one of the suggestions we got for SPFx Toolkit that we introduced as a small feature
• I wonder would it make more sense if the npm script package-solution would default to production package so run `heft package-solution --production

[Adam Wójcik (Adam-it)]

❓Question
In the .yo-rc.json file I noticed that:

• we have a useGulp: false property. What is the point of that?
• in the past version the 'sdkVersions' had microsoft-graph-client and teams-js specified. Now this property is empty. Is this ok?

[Adam Wójcik (Adam-it)]

Also, I noticed the newly scaffolded projects are missing launch.json file to start debugging from VS Code

[Adam Wójcik (Adam-it)]

since beta 3 is out I will close this one and we may start collecting feed on #10442