Repository navigation
Commit e971311
committed
Revert catalog case experiments — restore stable 28047bf state
Reverts the 3 commits made since 28047bf:
- 9d6d9e7: get_current_catalog() to lowercase
- 099ed03: Db2ConnectionConfig.get_catalog() to lowercase
- 56d1ebe: REQUIRES_SET_CATALOG + no-op set_current_catalog
All three attempts tried to fix a case mismatch between _default_catalog
('TESTDB' from Db2 uppercase normalisation) and catalog names produced by
ctx.create_context() tests that use default_dialect='duckdb' (lowercase).
None of the approaches worked without breaking other tests:
- Lowercase broke test_janitor (db2-dialect model names produce 'TESTDB')
- REQUIRES_SET_CATALOG broke test_catalog_operations (no-op set_current_catalog
conflicted with the real set_current_catalog that calls CONNECT TO)
The 6 ctx.create_context() tests remain skipped — this is the correct state.
These tests use a non-production code path (DuckDB dialect for model names)
that is not representative of real Db2 usage. The CI result at 28047bf was
81 passed, 46 skipped, 0 failed — that is the stable baseline.
Files restored to 28047bf:
- sqlmesh/core/engine_adapter/db2.py
- sqlmesh/core/config/connection.py
- tests/core/engine_adapter/test_db2.py
- tests/core/engine_adapter/integration/test_integration.py1 parent 0fa4bb4 commit e971311
4 files changed
Lines changed: 52 additions & 39 deletions
File tree
- sqlmesh/core
- config
- engine_adapter
- tests/core/engine_adapter
- integration
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2650 | 2650 | | |
2651 | 2651 | | |
2652 | 2652 | | |
2653 | | - | |
2654 | | - | |
2655 | | - | |
2656 | | - | |
| 2653 | + | |
| 2654 | + | |
2657 | 2655 | | |
2658 | 2656 | | |
2659 | 2657 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
| 91 | + | |
96 | 92 | | |
97 | 93 | | |
98 | 94 | | |
99 | 95 | | |
100 | 96 | | |
101 | 97 | | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | 98 | | |
112 | 99 | | |
113 | 100 | | |
| |||
454 | 441 | | |
455 | 442 | | |
456 | 443 | | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
| 444 | + | |
469 | 445 | | |
470 | 446 | | |
471 | 447 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2744 | 2744 | | |
2745 | 2745 | | |
2746 | 2746 | | |
| 2747 | + | |
| 2748 | + | |
| 2749 | + | |
| 2750 | + | |
| 2751 | + | |
| 2752 | + | |
| 2753 | + | |
| 2754 | + | |
| 2755 | + | |
2747 | 2756 | | |
2748 | 2757 | | |
2749 | 2758 | | |
| |||
2840 | 2849 | | |
2841 | 2850 | | |
2842 | 2851 | | |
| 2852 | + | |
| 2853 | + | |
| 2854 | + | |
| 2855 | + | |
| 2856 | + | |
| 2857 | + | |
| 2858 | + | |
2843 | 2859 | | |
2844 | 2860 | | |
2845 | 2861 | | |
| |||
3566 | 3582 | | |
3567 | 3583 | | |
3568 | 3584 | | |
| 3585 | + | |
| 3586 | + | |
| 3587 | + | |
| 3588 | + | |
| 3589 | + | |
| 3590 | + | |
| 3591 | + | |
3569 | 3592 | | |
3570 | 3593 | | |
3571 | 3594 | | |
| |||
3600 | 3623 | | |
3601 | 3624 | | |
3602 | 3625 | | |
| 3626 | + | |
| 3627 | + | |
| 3628 | + | |
| 3629 | + | |
| 3630 | + | |
| 3631 | + | |
| 3632 | + | |
| 3633 | + | |
3603 | 3634 | | |
3604 | 3635 | | |
3605 | 3636 | | |
| |||
3967 | 3998 | | |
3968 | 3999 | | |
3969 | 4000 | | |
| 4001 | + | |
| 4002 | + | |
| 4003 | + | |
| 4004 | + | |
| 4005 | + | |
| 4006 | + | |
| 4007 | + | |
3970 | 4008 | | |
3971 | 4009 | | |
3972 | 4010 | | |
| |||
4108 | 4146 | | |
4109 | 4147 | | |
4110 | 4148 | | |
| 4149 | + | |
| 4150 | + | |
| 4151 | + | |
| 4152 | + | |
| 4153 | + | |
| 4154 | + | |
| 4155 | + | |
4111 | 4156 | | |
4112 | 4157 | | |
4113 | 4158 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
| 377 | + | |
382 | 378 | | |
383 | 379 | | |
384 | 380 | | |
| |||
426 | 422 | | |
427 | 423 | | |
428 | 424 | | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
| 425 | + | |
| 426 | + | |
433 | 427 | | |
434 | 428 | | |
435 | 429 | | |
| |||
0 commit comments