Repository navigation
Commit bba1caa
committed
test: use ISO T-separated expected values to catch silent string mismatch
Per review feedback, changing the expected strings to '0001-01-01T00:00:00'
and '9999-12-31T23:59:59' means that if the datetime parsing regressed and
fell back to a str-based comparison, the mismatch against
str(datetime.datetime(1, 1, 1)) == '0001-01-01 00:00:00' would surface
directly through assert_equal - not only via the log_warning check.
The T-separated form still parses via pd.to_datetime -> us fallback to the
same year-1 / year-9999 instances as before, so the test remains a valid
end-to-end assertion of the fix in sqlmesh/core/test/definition.py.
Signed-off-by: mokashang <shangmengjiajiajia@gmail.com>1 parent d9c3820 commit bba1caa
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2964 | 2964 | | |
2965 | 2965 | | |
2966 | 2966 | | |
2967 | | - | |
| 2967 | + | |
| 2968 | + | |
| 2969 | + | |
2968 | 2970 | | |
2969 | 2971 | | |
2970 | 2972 | | |
| |||
0 commit comments