Merge branch 'main' into feature/smarter-unit-tests

Author: cmgoffena13

docs/integrations/dbt.md

@@ -287,9 +287,12 @@ If set to `False`, then the snapshot will be skipped and a warning will be logge
 Support for this will be added soon.
 
 ## Tests
-SQLMesh uses dbt tests to perform SQLMesh [audits](../concepts/audits.md) (coming soon).
 
-Add SQLMesh [unit tests](../concepts/tests.md) to a dbt project by placing them in the "tests" directory.
+dbt and SQLMesh use the word "test" differently. See [Workflow differences](#workflow-differences-between-sqlmesh-and-dbt) above for an overview.
+
+SQLMesh converts dbt tests (singular and generic `.sql` files in the `tests/` directory) into SQLMesh [audits](../concepts/audits.md). These run against data that already exists in your tables, just like dbt tests.
+
+Add SQLMesh [unit tests](../concepts/tests.md) to a dbt project by placing YAML files named `test*.yaml` or `test*.yml` in the `tests/` directory. Unit tests validate model query logic with predefined inputs and expected outputs; they are separate from dbt's SQL test files.
 
 ## Seed column types
 

sqlmesh/core/context.py

@@ -1339,7 +1339,8 @@ def format(
             ):  # introduced to satisfy type checker as still want to pull filter out as many targets as possible before loop
                 continue
 
-            with open(target._path, "r+", encoding="utf-8") as file:
+            mode = "r" if check else "r+"
+            with open(target._path, mode, encoding="utf-8") as file:
                 before = file.read()
 
                 after = self._format(

sqlmesh/core/engine_adapter/clickhouse.py

@@ -13,6 +13,7 @@
     DataObjectType,
     EngineRunMode,
     SourceQuery,
+    CommentCreationTable,
     CommentCreationView,
     InsertOverwriteStrategy,
 )
@@ -36,6 +37,7 @@ class ClickhouseEngineAdapter(EngineAdapterWithIndexSupport, LogicalMergeMixin):
     SUPPORTS_TRANSACTIONS = False
     SUPPORTS_VIEW_SCHEMA = False
     SUPPORTS_REPLACE_TABLE = False
+    COMMENT_CREATION_TABLE = CommentCreationTable.COMMENT_COMMAND_ONLY
     COMMENT_CREATION_VIEW = CommentCreationView.COMMENT_COMMAND_ONLY
 
     SCHEMA_DIFFER_KWARGS = {}

tests/core/engine_adapter/integration/test_integration_bigquery.py

@@ -490,7 +490,7 @@ def test_run_correlation_id_in_job_labels(ctx: TestContext):
     cron '@daily',
     start '2023-01-07'
 );
-SELECT 1 AS col, '2023-01-07' AS event_ts
+SELECT 1 AS col, CAST('2023-01-07' AS DATE) AS event_ts
 """
             )
         )

tests/core/test_format.py

@@ -1,4 +1,6 @@
+import os
 import pathlib
+import stat
 
 from pytest_mock.plugin import MockerFixture
 from sqlmesh.core.config import Config
@@ -146,6 +148,25 @@ def test_ignore_formating_files(tmp_path: pathlib.Path):
     )
 
 
+def test_format_check_read_only_files(tmp_path: pathlib.Path, mocker: MockerFixture):
+    models_dir = pathlib.Path("models")
+
+    model_text = "MODEL(name this.model, dialect 'duckdb'); SELECT 1 AS col"
+    model = create_temp_file(
+        tmp_path,
+        pathlib.Path(models_dir, "model.sql"),
+        model_text,
+    )
+    os.chmod(model, stat.S_IRUSR | stat.S_IRGRP | stat.S_IROTH)
+
+    context = Context(paths=tmp_path, config=Config())
+    context.console = mocker.Mock()
+    context.load()
+
+    assert not context.format(check=True)
+    assert model.read_text(encoding="utf-8") == model_text
+
+
 def test_format_without_state_load(tmp_path: pathlib.Path, mocker: MockerFixture):
     mock = mocker.patch(
         "sqlmesh.core.state_sync.db.facade.EngineAdapterStateSync.get_versions",