Skip to content

Commit 40c8ba6

Browse files
committed
style(web): fix prettier and eslint violations that accumulated while CI was off
`ui-style` has been disabled, so `prettier --check .` and the per-package eslint runs have not been enforced on merges for a while and drifted. Reformat the three files prettier flags, and fix the one eslint error in `vscode/extension`: `lineage_settings.spec.ts` imported `FrameLocator` and `Page` straight from `@playwright/test`, which `no-restricted-imports` forbids for `tests/**/*.spec.ts`. Every other spec takes `Page` from `./fixtures`, so re-export `FrameLocator` there too and import both from the fixtures module. No behavioural changes — the reformatting is whitespace only. Signed-off-by: Adegbite Ayoade <tripleaceme@gmail.com>
1 parent 8d0b4de commit 40c8ba6

5 files changed

Lines changed: 17 additions & 10 deletions

File tree

‎.devcontainer/devcontainer.json‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@
1111
"postCreateCommand": "bash .devcontainer/post-create-command.sh",
1212
"customizations": {
1313
"vscode": {
14-
"extensions": [
15-
"ms-python.python",
16-
"ms-python.vscode-pylance"
17-
]
14+
"extensions": ["ms-python.python", "ms-python.vscode-pylance"]
1815
}
1916
},
2017
"remoteUser": "vscode"

‎vscode/extension/tests/fixtures.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,5 @@ export const test = base.extend<
6060
],
6161
})
6262

63-
// Export expect and Page from Playwright for convenience
64-
export { expect, Page } from '@playwright/test'
63+
// Export expect and commonly used Playwright types for convenience
64+
export { expect, FrameLocator, Page } from '@playwright/test'

‎vscode/extension/tests/lineage_settings.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { test, expect } from './fixtures'
2-
import type { FrameLocator, Page } from '@playwright/test'
2+
import type { FrameLocator, Page } from './fixtures'
33
import fs from 'fs-extra'
44
import {
55
openLineageView,

‎web/client/src/library/components/graph/ModelNode.tsx‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,11 @@ export default function ModelNode({
198198
style={{
199199
width: '100%',
200200
...(tagColor != null
201-
? { borderColor: tagColor, backgroundColor: tagColor, color: tagColor }
201+
? {
202+
borderColor: tagColor,
203+
backgroundColor: tagColor,
204+
color: tagColor,
205+
}
202206
: {}),
203207
}}
204208
>
@@ -246,7 +250,10 @@ export default function ModelNode({
246250
/>
247251
</div>
248252
{showColumns && (
249-
<div ref={columnsWrapperRef} style={{ height: '10rem', overflow: 'hidden' }}>
253+
<div
254+
ref={columnsWrapperRef}
255+
style={{ height: '10rem', overflow: 'hidden' }}
256+
>
250257
<ModelColumns
251258
className="nowheel rounded-b-lg bg-theme-lighter text-xs h-full"
252259
nodeId={id}

‎web/client/src/library/components/graph/help.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,10 @@ function getNodeMap({
175175
const model = models.get(modelName)
176176
const tagsStr = model?.details?.tags
177177
const tags = tagsStr
178-
? tagsStr.split(',').map(t => t.trim()).filter(Boolean)
178+
? tagsStr
179+
.split(',')
180+
.map(t => t.trim())
181+
.filter(Boolean)
179182
: undefined
180183
const node = createGraphNode(modelName, {
181184
label: model?.displayName ?? modelName,

0 commit comments

Comments
 (0)