Maximum Packet Length is too low for SignNew Packet (47)

[lost-werewolf]

The character limit for signs in Terraria is 1,200 characters.
Spamming unicode characters or even filling a sign with normal characters can exceed a packet length of 1,000 defined at:

TSAPI/TerrariaServerAPI/TerrariaApi.Server/HookManager.cs

Line 420 in 2b81ac7

if (length > 1000)

...which can disconnect a legitimate client.

An exception could be made for signs, since spamming 1,200 unicode characters could result in ~3000+ length.
If this shouldn't be fixed, then feel free to ignore this issue and/or close it. It breaks vanilla behavior, but it isn't that important - realistically, there is no reason to fill a sign with over ~500 characters as it cuts off in-game.

[bartico6]

This mitigation and the associated bug should be revisited as I've since then built significantly better mitigation for network attacks like this (and the fixed >1000 check might be severely outdated now)

@hakusaro

[lost-werewolf]

Should this be revisited soon? Would be good to know how if we can just remove the >1000 check or bump it to something higher like 4096, as this disconnect really shouldn't be possible to trigger from a vanilla client if it's meant to stop network attacks (especially now that there's an option in TShock to allow for longer chat messages, which is only possible on mobile...)