Finish a delivered transaction whose finish failed, on the next delivery

The server already has that version, so it is not sent again; an update
repeating a version the server took is skipped as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: Programcode

apps/mobile/src/lib/purchases.test.ts

@@ -180,6 +180,21 @@ describe('delivering unfinished transactions', () => {
     expect(store.unfinishedList).toHaveLength(0);
   });
 
+  it('finishes on the next delivery a transaction whose finish failed, without sending it again', async () => {
+    const bought = transaction(USER_A);
+    store.unfinishedList.push(bought);
+    env.respond = () => Promise.resolve(APPLIED);
+    const finish = store.finish;
+    store.finish = () => Promise.reject(new Error('StoreKit busy'));
+    await deliverPending(USER_A);
+    expect(store.unfinishedList).toHaveLength(1);
+
+    store.finish = finish;
+    await deliverPending(USER_A);
+    expect(env.posts).toHaveLength(1);
+    expect(store.unfinishedList).toHaveLength(0);
+  });
+
   it('does not send a purchase under the account that signed in while the sheet was open', async () => {
     const sheet = deferred<StorePurchaseResult>();
     let opened = false;

apps/mobile/src/lib/purchases.ts

@@ -140,8 +140,8 @@ async function post(transaction: StoreTransaction, userId: string): Promise<Deli
  */
 async function deliver(transaction: StoreTransaction, userId: string): Promise<Delivery> {
   const version = transaction.signedTransaction;
-  if (delivered.has(version)) return { ok: true, plan: delivered.get(version) ?? null };
-  const result = await post(transaction, userId);
+  // The server already has this version: only finish it, in case the last finish failed.
+  const result: Delivery = delivered.has(version) ? { ok: true, plan: delivered.get(version) ?? null } : await post(transaction, userId);
   if (!result.ok) return result;
   delivered.set(version, result.plan);
   await storeKit()
@@ -273,6 +273,8 @@ export async function manageSubscriptions(): Promise<boolean> {
 function deliverUpdate(transaction: StoreTransaction, userId: string): Promise<void> {
   if (!belongsTo(transaction, userId)) return Promise.resolve();
   return serial(async () => {
+    // A version the server already took this run was finished then; an update repeating it needs nothing.
+    if (delivered.has(transaction.signedTransaction)) return;
     await deliver(transaction, userId);
   });
 }