Skip to content

Commit aa923ac

Browse files
committed
fix: remove auto side option, default role to R1 in Generate
- Remove 'auto' from side enum (only Pro/Con now) - Default side: pro, default role: r1 - Update prompt builder fallback from 'auto' to 'pro' - Length, audience, tone confirmed passed to AI (not illusion)
1 parent 7492980 commit aa923ac

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

‎src/components/features/generate/GenerateForm.tsx‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ export function GenerateForm({ onSubmit, isLoading }: GenerateFormProps) {
3434
resolver: zodResolver(GenerateInputSchema),
3535
defaultValues: {
3636
motion: '',
37-
side: 'auto',
37+
side: 'pro',
3838
format: 'custom',
39-
role: 'intro',
39+
role: 'r1',
4040
length: 'standard',
4141
audience: 'intermediate',
4242
tone: 'formal',
@@ -141,7 +141,6 @@ export function GenerateForm({ onSubmit, isLoading }: GenerateFormProps) {
141141
<SelectValue />
142142
</SelectTrigger>
143143
<SelectContent>
144-
<SelectItem value="auto">{t('generateForm.sideAuto')}</SelectItem>
145144
<SelectItem value="pro">{t('generateForm.sidePro')}</SelectItem>
146145
<SelectItem value="con">{t('generateForm.sideCon')}</SelectItem>
147146
</SelectContent>

‎src/lib/ai/schemas/generate.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { z } from 'zod';
33

44
export const GenerateInputSchema = z.object({
55
motion: z.string().min(1, 'Motion is required'),
6-
side: z.enum(['pro', 'con', 'auto']),
6+
side: z.enum(['pro', 'con']),
77
format: z.enum(['custom', 'bp', 'policy', 'classroom']), // Kept others for backward compatibility but UI will restrict
88
role: z.enum(['intro', 'r1', 'r2', 'conc', 'general']),
99
length: z.enum(['brief', 'standard', 'comprehensive']),

‎src/test/supabase/prompt-builder.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('supabase prompt-builder', () => {
7878
}, '');
7979

8080
expect(prompt).toContain('Motion: ');
81-
expect(prompt).toContain('Side: auto');
81+
expect(prompt).toContain('Side: pro');
8282
expect(prompt).toContain('Format: custom');
8383
expect(prompt).toContain('Role: intro');
8484
expect(prompt).toContain('Length: standard');

‎supabase/functions/ai/prompt-builder.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export function buildUserPrompt(feature: Feature, input: Record<string, unknown>
3434
if (feature === "generate") {
3535
const language = asString(input.language, "en");
3636
return `Motion: ${asString(input.motion)}
37-
Side: ${asString(input.side, "auto")}
37+
Side: ${asString(input.side, "pro")}
3838
Format: ${asString(input.format, "custom")}
3939
Role: ${asString(input.role, "intro")}
4040
Length: ${asString(input.length, "standard")}

0 commit comments

Comments
 (0)