Skip to content

Commit 97d33b4

Browse files
committed
Ollie greets an empty Sparring list; a judged round shows the mint check
Review of #265: the Practice tab was the only empty state without Ollie, and the judging ring showed a blue check where success is always mint with a check mark.
1 parent 0c22ab7 commit 97d33b4

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

‎apps/mobile/src/app/(tabs)/(practice)/practice.tsx‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { useTranslation } from 'react-i18next';
44
import { StyleSheet, View } from 'react-native';
55

66
import { Card, IconTile, ListItemIn } from '@/components/card';
7+
import { EmptyState } from '@/components/empty-state';
78
import { Icon } from '@/components/icon';
89
import { PressScale } from '@/components/press-scale';
910
import { PRACTICE_TOOLS, type PracticeTool } from '@/components/practice-tools';
@@ -112,11 +113,7 @@ export default function PracticeScreen() {
112113
</Text>
113114
</Card>
114115
) : items.length === 0 ? (
115-
<Card>
116-
<Text tone="secondary" style={styles.body}>
117-
{t('historyPage.emptySparringDesc')}
118-
</Text>
119-
</Card>
116+
<EmptyState pose="arguing" title={t('historyPage.emptySparring')} description={t('historyPage.emptySparringDesc')} />
120117
) : (
121118
<Card style={styles.list}>
122119
{items.map((round, index) => (

‎apps/mobile/src/app/sparring/index.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import { SegmentedControl } from '@/components/segmented-control';
3434
import { ContextLine } from '@/components/context-line';
3535
import { SessionCostNote } from '@/components/session-cost-note';
3636
import { SparringScorecardScreen, winnerText } from '@/components/sparring-views';
37+
import { SuccessCheck } from '@/components/success-check';
3738
import { Text } from '@/components/text';
3839
import { TimerRing } from '@/components/timer-ring';
3940
import { ToolTitle, WorkingIn } from '@/components/tool-form';
@@ -617,7 +618,7 @@ function LiveRound({
617618
{status}
618619
</Text>
619620
{judging ? (
620-
<Icon name="check" color={colors.primary} size={Math.round(ringSize * 0.22)} />
621+
<SuccessCheck size={Math.round(ringSize * 0.26)} haptic={false} />
621622
) : (
622623
<Text
623624
weight="bold"

0 commit comments

Comments
 (0)