chore: remove dead code and tautological tests (#29)

* chore: remove dead code and tautological tests

Dead code (zero references anywhere, including tests):
- src/lib/ai/prompts/index.ts (165 lines) — prompt building moved
  server-side to supabase/functions/_shared/prompts.ts
- useKeyboardShortcuts, useResolvedTheme hooks
- isUrlSafe (validateUrl is the live entry point)
- requireAdmin in _shared/auth.ts — admin/index.ts does its own
  inline user_roles lookups
- getAppRedirectUrl in native.ts
- mockSparringResponse/mockSparringScore aliases
- buildSearchQueries wrapper — inlined the one-line .map into its
  two callers, which were both tests

Tests that assert nothing about our code:
- example.test.ts: expect(true).toBe(true)
- utils.test.ts: 11 tests over cn(), a one-line clsx+tailwind-merge
  pass-through — tested the libraries, not us
- providers.test.ts: 14 of 15 tests re-asserted that a static const
  is still a static const; kept the duplicate-model-ID check, which
  guards real routing behavior
- i18n.test.ts: "locale has keys" tautologies and a key-count check
  subsumed by the bidirectional key-set comparisons
- export-utils-extended.test.ts: 6 "typeof x === function" tests
- pages/HistoryPage smoke tests asserting document.body is defined
- settings-store-branches: the `afterRehydrate(undefined)` call
  existed only to hit an `if (!state) return` line

Preserved deliberately: setActiveEnv/IS_STAGING in supabase/env.ts
(reserved by plans/supabase-staging.md for the admin env switcher),
and security-hardening/runtime-contracts/vercel-deployment-config
tests, which guard invariants from PRs #26/#27.

Verified: 921 tests pass, lint clean, tsc clean, build succeeds,
coverage thresholds still met (statements 90.45/90, branches
82.91/80, functions 91.46/89, lines 94.04/90).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* test: give CI expect assertions room for lazy route chunks

The e2e suite runs against the Vite dev server, which transforms
lazily-imported route modules on demand. The first assertion after
navigating to a lazy route therefore races that transform waterfall.

Trace timings from the failing CI run on this branch:

  22:16:35.139  GET /app/sparring        (document)
  22:16:38.463  SparringPage.tsx         (+3.3s)
  22:16:38.755  SparringSetup.tsx        (+3.6s, owns the heading)

Against the 5s Playwright default, with two workers sharing a runner,
that overruns. The failure screenshot shows the heading rendered
correctly -- the budget simply expired first.

Raise the expect timeout to 15s under CI only, leaving local runs at
the 5s default so genuine hangs still surface quickly. No assertion is
weakened: every expectation still has to pass, it just gets a budget
that reflects what the dev server actually costs on a shared runner.

Pre-existing, not caused by the dead-code removal in this branch: PR
28 recorded the same test as flaky, and it reproduces on base 79b65ca
with these changes absent.

Verified under 12 busy-loop jobs on 8 cores, 18-test sample:
  5s  (control): 1 flaky, 17 passed
  15s (fixed):   18 passed
Full suite on a clean machine: 124 passed, 0 flaky.

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: Programcode

playwright.config.ts

@@ -28,6 +28,11 @@ export default defineConfig({
   retries: process.env.CI ? 2 : 0,
   workers: process.env.CI ? 2 : undefined,
   reporter: process.env.CI ? [['github'], ['html', { open: 'never' }]] : 'list',
+  // The dev server transforms lazily-imported route modules on demand, so the
+  // first assertion after navigating to a lazy route races that waterfall. On a
+  // shared CI runner it has measured over 3.5s from document to the component
+  // that owns the heading, which overruns the 5s default.
+  expect: { timeout: process.env.CI ? 15_000 : 5_000 },
   use: {
     baseURL,
     trace: 'retain-on-failure',

src/hooks/use-keyboard-shortcuts.ts

@@ -508,5 +508,3 @@ export async function mockJudgeSparringSession(input: SparringScoreInput): Promi
 }
 
 // Names kept short for callers that treat the mock provider as a feature adapter.
-export const mockSparringResponse = mockGenerateSparringTurn;
-export const mockSparringScore = mockJudgeSparringSession;

src/hooks/use-resolved-theme.ts

@@ -9,11 +9,6 @@ export function isNativeApp(): boolean {
   return Capacitor.isNativePlatform();
 }
 
-export function getAppRedirectUrl(path = '/app'): string {
-  if (isNativeApp()) return `${NATIVE_URL_SCHEME}://${path.replace(/^\/+/, '')}`;
-  return `${window.location.origin}${path}`;
-}
-
 export function getWebAppRedirectUrl(path = '/app'): string {
   const origin = isNativeApp() ? PUBLIC_WEB_APP_ORIGIN : window.location.origin;
   return `${origin}${path}`;

src/lib/ai/prompts/index.ts

@@ -55,11 +55,3 @@ export function validateUrl(url?: string): string | undefined {
         return undefined;
     }
 }
-
-/**
- * Checks if a URL is safe without normalizing it.
- * Useful for validation-only scenarios.
- */
-export function isUrlSafe(url?: string): boolean {
-    return validateUrl(url) !== undefined;
-}

src/lib/ai/providers/mock-provider.ts

@@ -225,29 +225,4 @@ describe('Export Utils - Extended', () => {
     });
   });
 
-  describe('PDF export functions exist', () => {
-    it('exportCaseToDocx is a function', () => {
-      expect(typeof exportCaseToDocx).toBe('function');
-    });
-
-    it('exportAttackToDocx is a function', () => {
-      expect(typeof exportAttackToDocx).toBe('function');
-    });
-
-    it('exportBrainstormToDocx is a function', () => {
-      expect(typeof exportBrainstormToDocx).toBe('function');
-    });
-
-    it('exportFactoidsToDocx is a function', () => {
-      expect(typeof exportFactoidsToDocx).toBe('function');
-    });
-
-    it('exportCaseToGoogleDocs is a function', () => {
-      expect(typeof exportCaseToGoogleDocs).toBe('function');
-    });
-
-    it('exportBrainstormToGoogleDocs is a function', () => {
-      expect(typeof exportBrainstormToGoogleDocs).toBe('function');
-    });
-  });
 });

src/lib/native.ts

@@ -32,23 +32,6 @@ describe('i18n locale files', () => {
   const esKeys = flattenKeys(es);
   const huKeys = flattenKeys(hu);
 
-  it('en.json has keys', () => {
-    expect(enKeys.length).toBeGreaterThan(0);
-  });
-
-  it('es.json has keys', () => {
-    expect(esKeys.length).toBeGreaterThan(0);
-  });
-
-  it('hu.json has keys', () => {
-    expect(huKeys.length).toBeGreaterThan(0);
-  });
-
-  it('all 3 locale files have same number of keys', () => {
-    expect(enKeys.length).toBe(esKeys.length);
-    expect(enKeys.length).toBe(huKeys.length);
-  });
-
   it('all keys in en.json exist in es.json', () => {
     const esKeySet = new Set(esKeys);
     const missing = enKeys.filter(k => !esKeySet.has(k));
@@ -100,15 +83,9 @@ describe('i18n locale files', () => {
 });
 
 describe('i18n runtime', () => {
-  it('i18n.t returns correct English value for nav.home', () => {
+  it('i18n.t resolves English nav values', () => {
     expect(i18n.t('nav.home')).toBe('Home');
-  });
-
-  it('i18n.t returns correct English value for nav.generate', () => {
     expect(i18n.t('nav.generate')).toBe('Generate');
-  });
-
-  it('i18n.t returns correct English value for nav.settings', () => {
     expect(i18n.t('nav.settings')).toBe('Settings');
   });
 
@@ -124,11 +101,6 @@ describe('i18n runtime', () => {
     await i18n.changeLanguage('en');
   });
 
-  it('i18n.changeLanguage back to en', async () => {
-    await i18n.changeLanguage('en');
-    expect(i18n.language).toBe('en');
-  });
-
   it('interpolation works for limitModal.limitReachedDesc', () => {
     const result = i18n.t('limitModal.limitReachedDesc', { current: 5, limit: 10 });
     expect(result).toContain('5');