Keep text typed during a save marked as an edit

A finished save cleared the edit mark of every field it sent, even one
the student changed again while it ran, so that text was never sent and
could be replaced by the stored copy. Each field now carries an edit count
and each sheet opening a number; a save clears a mark only when neither
changed. lib-edit-while-switching types on during a slow save and checks
the next Save sends it, and first checks the editor opened mid-write.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: Programcode

.claude/skills/verify-debatelab/features/library-sources.md

@@ -7,7 +7,7 @@ Users save reference texts to their Library. The Library belongs to the Current
 - `lib-add` adds a source with a title and content. It shows at once while it saves, then a toast `Saved <title> to the Library`; its toggle is on, and the banner `Grounding Active` shows.
 - `lib-toggle` pauses a source through its switch, which keeps it out of prompts.
 - `lib-offline` offline, the switch does not move and a toast says `You are offline. Reconnect and try again.` A write that fails online puts the switch back with a toast.
-- `lib-edit-while-switching` the source editor's untouched fields follow the stored source while it is open (a switch that rolls back shows as rolled back), and `Save` sends only the fields edited in the sheet.
+- `lib-edit-while-switching` the source editor's untouched fields follow the stored source while it is open (a switch that rolls back shows as rolled back), and `Save` sends only the fields edited in the sheet. Text typed while a save runs stays an edit and goes out with the next `Save`.
 - `lib-dedupe` keeps one row per web page per debate. URLs match after normalizing (host without `www.`, no scheme, fragment, tracking parameters or trailing slash). Importing a page the debate has warns `This page is already in this debate's Library.` before any fetch; research refreshes the existing row instead of adding one.
 - `lib-layout` on a phone the row's controls take their own line, so a long title gets the row's width and two lines.
 - `lib-ground` includes only active sources' text in the `system` of later AI calls (Generate, Brainstorm, and others).

.claude/skills/verify-debatelab/recipes/library.spec.ts

@@ -132,6 +132,8 @@ test("lib-edit-while-switching: the editor follows a switch that rolls back, and
   await page.getByRole("switch", { name: "Toggle Race study" }).click();
   await page.getByRole("button", { name: "Race study", exact: true }).click();
   const sheet = page.getByRole("dialog");
+  // The editor opened while the write was still running, so it shows the switch off.
+  await expect(sheet.getByRole("switch", { name: "Use for AI grounding" })).not.toBeChecked();
   await expect(page.getByText("Could not change this source")).toBeVisible();
   // The switch went back on; the editor shows that, since it was not edited there.
   await expect(sheet.getByRole("switch", { name: "Use for AI grounding" })).toBeChecked();
@@ -142,6 +144,22 @@ test("lib-edit-while-switching: the editor follows a switch that rolls back, and
   const row = async () => (await admin.from("sources").select("content,is_active").eq("user_id", await user.userId()).eq("title", "Race study")).data;
   await expect.poll(row).toEqual([{ content: "Edited text.", is_active: true }]);
   await evidence.shot("01-editor-after-rollback");
+
+  // Typing on while a save runs keeps that text as an edit, so the next Save sends it.
+  const slowSave = async (route: import("@playwright/test").Route) => {
+    if (route.request().method() === "PATCH") await new Promise((resolve) => setTimeout(resolve, 1_500));
+    await route.continue();
+  };
+  await page.route("**/rest/v1/sources?**", slowSave);
+  const content = sheet.getByRole("textbox", { name: "Content" });
+  await content.fill("Second edit.");
+  await sheet.getByRole("button", { name: "Save" }).click();
+  await content.fill("Second edit, typed on.");
+  await expect.poll(row).toEqual([{ content: "Second edit.", is_active: true }]);
+  await expect(sheet.getByRole("button", { name: "Save" })).toBeEnabled();
+  await page.unroute("**/rest/v1/sources?**", slowSave);
+  await sheet.getByRole("button", { name: "Save" }).click();
+  await expect.poll(row).toEqual([{ content: "Second edit, typed on.", is_active: true }]);
   await evidence.json("02-row", await row());
 });
 

src/pages/LibraryPage.tsx

@@ -220,9 +220,11 @@ export default function LibraryPage() {
   const draftTitleRef = useRef<HTMLInputElement>(null);
   const draftContentRef = useRef<HTMLTextAreaElement>(null);
   const draftLoadedFor = useRef<string | null>(null);
-  // Fields the student edited in the sheet. Save sends only these; the others
-  // follow the stored source while the sheet is open.
-  const touchedDraftFields = useRef(new Set<keyof typeof sourceDraft>());
+  // Fields the student edited in the sheet, each with an edit count. Save sends
+  // only these; the others follow the stored source while the sheet is open.
+  const touchedDraftFields = useRef(new Map<keyof typeof sourceDraft, number>());
+  // Counts sheet openings, so a save that lands after a reopen leaves the new edits alone.
+  const draftOpening = useRef(0);
   const [isSavingDraft, setIsSavingDraft] = useState(false);
   const [newSource, setNewSource] = useState({
     title: '',
@@ -527,6 +529,7 @@ export default function LibraryPage() {
     };
     if (draftLoadedFor.current !== selectedSource.id) {
       draftLoadedFor.current = selectedSource.id;
+      draftOpening.current += 1;
       touchedDraftFields.current.clear();
       setDraftErrors({});
       setSourceDraft(stored);
@@ -618,7 +621,8 @@ export default function LibraryPage() {
     }
   };
   const editDraft = (patch: Partial<typeof sourceDraft>) => {
-    for (const key of Object.keys(patch) as Array<keyof typeof sourceDraft>) touchedDraftFields.current.add(key);
+    const touched = touchedDraftFields.current;
+    for (const key of Object.keys(patch) as Array<keyof typeof sourceDraft>) touched.set(key, (touched.get(key) ?? 0) + 1);
     setSourceDraft((draft) => ({ ...draft, ...patch }));
   };
   const handleSaveSourceDraft = async () => {
@@ -630,14 +634,18 @@ export default function LibraryPage() {
 
     // Only what was edited here is written, so a change that reached this
     // source while the sheet was open (a switch, research) is not overwritten.
-    const sourceId = selectedSource.id;
-    const sent = Array.from(touchedDraftFields.current);
-    const patch = Object.fromEntries(sent.map((key) => [key, sourceDraft[key]])) as Partial<typeof sourceDraft>;
+    const opening = draftOpening.current;
+    const sent = new Map(touchedDraftFields.current);
+    const patch = Object.fromEntries(Array.from(sent.keys(), (key) => [key, sourceDraft[key]])) as Partial<typeof sourceDraft>;
     setIsSavingDraft(true);
     try {
-      await updateSource(sourceId, patch);
-      // The sheet may show another source by now; its edits are its own.
-      if (draftLoadedFor.current === sourceId) for (const key of sent) touchedDraftFields.current.delete(key);
+      await updateSource(selectedSource.id, patch);
+      // A field counts as saved only if it was not edited again meanwhile and
+      // the sheet still shows the opening this save came from.
+      if (draftOpening.current === opening) {
+        const touched = touchedDraftFields.current;
+        for (const [key, edits] of sent) if (touched.get(key) === edits) touched.delete(key);
+      }
     } catch (error) {
       toast({
         title: t('libraryPage.saveFailed', 'Could not save this source.'),