Address code review: evict only the faulted cache entry, clarify test path

Co-authored-by: jessehouwing <4173387+jessehouwing@users.noreply.github.com>

Author: Copilot

Engine/CommandInfoCache.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Concurrent;
+using System.Collections.Generic;
 using System.Management.Automation;
 using System.Linq;
 using System.Management.Automation.Runspaces;
@@ -86,8 +87,10 @@ public CommandInfo GetCommandInfo(string commandName, CommandTypes? commandTypes
             {
                 // Lazy<T> caches exceptions forever, which would make every subsequent lookup of this
                 // command fail for the lifetime of the process. Evict the entry so that the next lookup
-                // can try again.
-                _commandInfoCache.TryRemove(key, out _);
+                // can try again. Only remove the faulted instance so that a replacement that another
+                // thread may already have added is left alone.
+                ((ICollection<KeyValuePair<CommandLookupKey, Lazy<CommandInfo>>>)_commandInfoCache)
+                    .Remove(new KeyValuePair<CommandLookupKey, Lazy<CommandInfo>>(key, lazyCommandInfo));
                 throw;
             }
         }

Tests/Rules/Issue2205.tests.ps1

@@ -4,7 +4,8 @@
 Describe 'Issue 2205' {
     It "does not fail the analysis when a command lookup hits the runspace affinity problem" -Skip:(-not $IsLinux) {
         $settingsPath = Join-Path $PSScriptRoot 'Issue2205/PSScriptAnalyzerSettings.psd1'
-        $repositoryRoot = Split-Path -Parent (Split-Path -Parent $PSScriptRoot)
+        # $PSScriptRoot is <repo>/Tests/Rules, so two levels up is the repository root.
+        $repositoryRoot = (Resolve-Path (Join-Path $PSScriptRoot '..' '..')).Path
 
         Invoke-ScriptAnalyzer -Path $repositoryRoot -Recurse -Settings $settingsPath -ErrorAction Stop | Out-Null
     }