Skip to content

Commit f4af88a

Browse files
authored
fix: acknowledge oversized dropped events (#543)
1 parent 6b3d1c7 commit f4af88a

3 files changed

Lines changed: 7 additions & 0 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
pypi/posthog: patch
3+
---
4+
5+
Prevent flush from hanging after dropping oversized queued events.

‎posthog/consumer.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ def next(self):
112112
self.log.error(
113113
"Item exceeds 900kib limit, dropping. (%s)", str(item)
114114
)
115+
queue.task_done()
115116
continue
116117
items.append(item)
117118
total_size += item_size

‎posthog/test/test_consumer.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def test_dropping_oversize_msg(self) -> None:
4545
next = consumer.next()
4646
self.assertEqual(next, [])
4747
self.assertTrue(q.empty())
48+
self.assertEqual(q.unfinished_tasks, 0)
4849

4950
def test_upload(self) -> None:
5051
q = Queue()

0 commit comments

Comments
 (0)