|
| 1 | +import type { AgentSideConnection } from "@agentclientprotocol/sdk"; |
| 2 | +import { beforeEach, describe, expect, it, vi } from "vitest"; |
| 3 | +import { |
| 4 | + CODE_EXECUTION_MODES, |
| 5 | + type CodeExecutionMode, |
| 6 | +} from "../../execution-mode"; |
| 7 | +import { createMockQuery, type MockQuery } from "../../test/mocks/claude-sdk"; |
| 8 | +import { Pushable } from "../../utils/streams"; |
| 9 | +import { toSdkPermissionMode } from "./tools"; |
| 10 | + |
| 11 | +vi.mock("@anthropic-ai/claude-agent-sdk", () => ({ |
| 12 | + query: vi.fn(), |
| 13 | +})); |
| 14 | + |
| 15 | +vi.mock("./mcp/tool-metadata", () => ({ |
| 16 | + fetchMcpToolMetadata: vi.fn().mockResolvedValue(undefined), |
| 17 | + getConnectedMcpServerNames: vi.fn().mockReturnValue([]), |
| 18 | + setMcpToolApprovalStates: vi.fn(), |
| 19 | + isMcpToolReadOnly: vi.fn().mockReturnValue(false), |
| 20 | + getMcpToolMetadata: vi.fn().mockReturnValue(undefined), |
| 21 | + getMcpToolApprovalState: vi.fn().mockReturnValue(undefined), |
| 22 | +})); |
| 23 | + |
| 24 | +const { ClaudeAcpAgent } = await import("./claude-agent"); |
| 25 | +type Agent = InstanceType<typeof ClaudeAcpAgent>; |
| 26 | + |
| 27 | +interface ClientMocks { |
| 28 | + sessionUpdate: ReturnType<typeof vi.fn>; |
| 29 | + extNotification: ReturnType<typeof vi.fn>; |
| 30 | +} |
| 31 | + |
| 32 | +function makeAgent(): { agent: Agent; client: ClientMocks } { |
| 33 | + const client: ClientMocks = { |
| 34 | + sessionUpdate: vi.fn().mockResolvedValue(undefined), |
| 35 | + extNotification: vi.fn().mockResolvedValue(undefined), |
| 36 | + }; |
| 37 | + const agent = new ClaudeAcpAgent(client as unknown as AgentSideConnection); |
| 38 | + return { agent, client }; |
| 39 | +} |
| 40 | + |
| 41 | +function installFakeSession( |
| 42 | + agent: Agent, |
| 43 | + sessionId: string, |
| 44 | + permissionMode: CodeExecutionMode = "default", |
| 45 | +): MockQuery { |
| 46 | + const query = createMockQuery(); |
| 47 | + const input = new Pushable(); |
| 48 | + const abortController = new AbortController(); |
| 49 | + |
| 50 | + const session = { |
| 51 | + query, |
| 52 | + queryOptions: { sessionId, cwd: "/tmp/repo", abortController }, |
| 53 | + buildInProcessMcpServers: () => ({}), |
| 54 | + localToolsServerNames: [] as string[], |
| 55 | + input, |
| 56 | + cancelled: false, |
| 57 | + interruptReason: undefined, |
| 58 | + settingsManager: { dispose: vi.fn(), getRepoRoot: () => "/tmp/repo" }, |
| 59 | + permissionMode, |
| 60 | + abortController, |
| 61 | + accumulatedUsage: { |
| 62 | + inputTokens: 0, |
| 63 | + outputTokens: 0, |
| 64 | + cachedReadTokens: 0, |
| 65 | + cachedWriteTokens: 0, |
| 66 | + }, |
| 67 | + sessionResources: new Set(), |
| 68 | + configOptions: [], |
| 69 | + turnQueue: [], |
| 70 | + activeTurn: null, |
| 71 | + pendingOrphanResults: 0, |
| 72 | + queryGeneration: 0, |
| 73 | + cwd: "/tmp/repo", |
| 74 | + notificationHistory: [] as unknown[], |
| 75 | + taskRunId: "run-1", |
| 76 | + lastContextWindowSize: 200_000, |
| 77 | + modelId: "claude-sonnet-4-6", |
| 78 | + knownSlashCommands: undefined, |
| 79 | + }; |
| 80 | + |
| 81 | + (agent as unknown as { session: typeof session }).session = session; |
| 82 | + (agent as unknown as { sessionId: string }).sessionId = sessionId; |
| 83 | + |
| 84 | + return query; |
| 85 | +} |
| 86 | + |
| 87 | +describe("ClaudeAcpAgent.setSessionMode — SDK permission-mode translation", () => { |
| 88 | + beforeEach(() => { |
| 89 | + vi.clearAllMocks(); |
| 90 | + }); |
| 91 | + |
| 92 | + it.each(CODE_EXECUTION_MODES)( |
| 93 | + "maps modeId %s to the SDK's permission mode at the setPermissionMode call site", |
| 94 | + async (modeId) => { |
| 95 | + const { agent } = makeAgent(); |
| 96 | + const query = installFakeSession(agent, "s-mode"); |
| 97 | + |
| 98 | + await agent.setSessionMode({ sessionId: "s-mode", modeId }); |
| 99 | + |
| 100 | + expect(query.setPermissionMode).toHaveBeenCalledWith( |
| 101 | + toSdkPermissionMode(modeId), |
| 102 | + ); |
| 103 | + expect( |
| 104 | + (agent as unknown as { session: { permissionMode: string } }).session |
| 105 | + .permissionMode, |
| 106 | + ).toBe(modeId); |
| 107 | + }, |
| 108 | + ); |
| 109 | + |
| 110 | + it("reverts session.permissionMode to the previous mode when the SDK rejects", async () => { |
| 111 | + const { agent } = makeAgent(); |
| 112 | + const query = installFakeSession(agent, "s-mode", "default"); |
| 113 | + vi.mocked(query.setPermissionMode).mockRejectedValueOnce( |
| 114 | + new Error("sdk rejected"), |
| 115 | + ); |
| 116 | + |
| 117 | + await expect( |
| 118 | + agent.setSessionMode({ sessionId: "s-mode", modeId: "auto" }), |
| 119 | + ).rejects.toThrow("sdk rejected"); |
| 120 | + |
| 121 | + expect( |
| 122 | + (agent as unknown as { session: { permissionMode: string } }).session |
| 123 | + .permissionMode, |
| 124 | + ).toBe("default"); |
| 125 | + }); |
| 126 | + |
| 127 | + it("falls back to a generic error message when the SDK rejection has none", async () => { |
| 128 | + const { agent } = makeAgent(); |
| 129 | + const query = installFakeSession(agent, "s-mode", "default"); |
| 130 | + vi.mocked(query.setPermissionMode).mockRejectedValueOnce(new Error()); |
| 131 | + |
| 132 | + await expect( |
| 133 | + agent.setSessionMode({ sessionId: "s-mode", modeId: "auto" }), |
| 134 | + ).rejects.toThrow("Invalid Mode"); |
| 135 | + }); |
| 136 | + |
| 137 | + it("records modeBeforePlan using the host mode, unaffected by the SDK translation", async () => { |
| 138 | + const { agent } = makeAgent(); |
| 139 | + installFakeSession(agent, "s-mode", "auto"); |
| 140 | + |
| 141 | + await agent.setSessionMode({ sessionId: "s-mode", modeId: "plan" }); |
| 142 | + |
| 143 | + const session = ( |
| 144 | + agent as unknown as { |
| 145 | + session: { permissionMode: string; modeBeforePlan?: string }; |
| 146 | + } |
| 147 | + ).session; |
| 148 | + expect(session.permissionMode).toBe("plan"); |
| 149 | + expect(session.modeBeforePlan).toBe("auto"); |
| 150 | + }); |
| 151 | +}); |
0 commit comments