From 404ee0cb2bcb5f785a7a64058ff2bc5571626834 Mon Sep 17 00:00:00 2001 From: Max Ghenis Date: Sun, 11 Oct 2026 10:52:30 -0400 Subject: [PATCH] Drop the fixed Illinois AABD entry from the person-adds ratchet #9902 made il_aabd_expense_exemption_person count only the person's own withholding, so it no longer adds the tax-unit state_withheld_income_tax. test_known_violations_only_shrink (#9897) then fails on main because the entry is still listed in KNOWN_VIOLATIONS. Remove it. Co-Authored-By: Claude Opus 5.5 --- changelog.d/fix-known-violations-il-aabd.fixed.md | 1 + .../tests/code_health/test_no_group_variables_in_person_adds.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 changelog.d/fix-known-violations-il-aabd.fixed.md diff --git a/changelog.d/fix-known-violations-il-aabd.fixed.md b/changelog.d/fix-known-violations-il-aabd.fixed.md new file mode 100644 index 00000000000..480f61ef2c6 --- /dev/null +++ b/changelog.d/fix-known-violations-il-aabd.fixed.md @@ -0,0 +1 @@ +Remove the Illinois AABD expense exemption from the known person-adds-group violations, which #9902 fixed, so the ratchet test passes again. diff --git a/policyengine_us/tests/code_health/test_no_group_variables_in_person_adds.py b/policyengine_us/tests/code_health/test_no_group_variables_in_person_adds.py index cc36269eca5..888a6260870 100644 --- a/policyengine_us/tests/code_health/test_no_group_variables_in_person_adds.py +++ b/policyengine_us/tests/code_health/test_no_group_variables_in_person_adds.py @@ -113,7 +113,6 @@ KNOWN_VIOLATIONS = { # PolicyEngine/policyengine-us#9888. ("mt_misc_deductions", "adds", "casualty_loss_deduction"), - ("il_aabd_expense_exemption_person", "adds", "state_withheld_income_tax"), ( "ca_riv_general_relief_countable_property_value", "adds",