Repository navigation
Commit c39f5c6
committed
test(ir): close the two acceptance gaps review found in a689326
Both were real, and both were the same shape: an assertion that passed for a
reason weaker than its own name.
SECONDARY SARIF PATH. `Evidence.line` reaches a region by a route the primary
control never touches — `steps_for` copies it into a `Step`, `emittable`
applies the `>= 1` gate, and `related_locations` and `code_flow` each build a
`Region` from it. Measured: a truncation planted in `steps_for` left ALL NINE
earlier controls green, because `EvidenceIdentity` inspects the `Evidence` and
the primary region never passes through a `Step`. The new control walks the
band through evidence and asserts BOTH consumers — they share `emittable`
today, and checking only `relatedLocations` would have been leaning on that
rather than testing it.
DI FALLBACK EXACTNESS. `a_non_positive_site_takes_the_registration_fallback`
asserted that the verdict was NOT anchored at the negative site. That catches
the `>= 1` -> `!= 0` refactor and nothing else: a fallback landing on any third
coordinate passed it, while the test's name claimed otherwise. Now filtered to
DI004 and asserted exactly — `("reg.cs", 5)` for i64::MIN / -1 / 0, and
`("call.cs", line)` for 1 / u32::MAX+1 / i64::MAX. Verified by mutating the
fallback to `reg_line + 1`, which the old form passed.
Mutations 7 and 8, both caught; 8 of 8 across the representation work.
Refs #250, #259.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CJF7MBi1ijU5m9cJVWgQsM1 parent a689326 commit c39f5c6
2 files changed
Lines changed: 87 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
127 | 131 | | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
138 | 147 | | |
139 | 148 | | |
140 | 149 | | |
141 | 150 | | |
142 | 151 | | |
143 | 152 | | |
144 | 153 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
150 | 164 | | |
151 | 165 | | |
152 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
0 commit comments