Skip to content

Tangential damping coefficient in linearCF.hpp: sqrt(kt) is inside log() — might be a typo #268

Description

@junecpct

File: src/Interaction/Models/contactForce/linearCF.hpp (present in the v-1.0 tag and current main)

In the constructor that precomputes the damping coefficients, the normal
direction is:

etha_n[i] = -2.0*log(en[i])*sqrt(kn[i])/
        sqrt(pow(log(en[i]),static_cast<real>(2.0))+ pow(Pi,static_cast<real>(2.0)));

but the tangential line has sqrt(kt[i]) inside the log():

etha_t[i] = -2.0*log( et[i]*sqrt(kt[i]) )/
        sqrt(pow(log(et[i]),static_cast<real>(2.0))+ pow(Pi,static_cast<real>(2.0)));

This looks like a typo: for the restitution-derived linear dashpot the stiffness belongs outside the logarithm, as in the normal direction (the denominator already uses the correct log(et[i])).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions