move test-only implementation into the test context

Author: rbev

src/ServiceControl.Persistence.EFCore/Implementation/ErrorMessagesDataStore.cs

@@ -113,7 +113,4 @@ public Task<byte[]> FetchFromFailedMessage(string uniqueMessageId) =>
 
     public Task StoreEventLogItem(EventLogItem logItem) =>
         throw new NotImplementedException();
-
-    public Task StoreFailedMessagesForTestsOnly(params FailedMessage[] failedMessages)
-        => throw new NotImplementedException("EF Tests Use the Ingestion pathway to populate this data");
 }

src/ServiceControl.Persistence.RavenDB/ErrorMessagesDataStore.cs

@@ -663,16 +663,5 @@ public async Task StoreEventLogItem(EventLogItem logItem)
 
             await session.SaveChangesAsync();
         }
-
-        public async Task StoreFailedMessagesForTestsOnly(params FailedMessage[] failedMessages)
-        {
-            using var session = await sessionProvider.OpenSession();
-            foreach (var message in failedMessages)
-            {
-                await session.StoreAsync(message);
-            }
-
-            await session.SaveChangesAsync();
-        }
     }
 }

src/ServiceControl.Persistence.Tests/Recoverability/EditHandlerAuditTests.cs

@@ -105,7 +105,7 @@ async Task<FailedMessage> CreateAndStoreFailedMessage(string failedMessageId = n
                     }
                 ]
         };
-        await ErrorMessageDataStore.StoreFailedMessagesForTestsOnly(new[] { failedMessage });
+        await PersistenceTestsContext.InsertFailedMessages(failedMessage);
         return failedMessage;
     }
 }

src/ServiceControl.Persistence.Tests/Recoverability/EditMessageTests.cs

@@ -262,7 +262,7 @@ async Task<FailedMessage> CreateAndStoreFailedMessage(string failedMessageId = n
                         }
                     ]
             };
-            await ErrorMessageDataStore.StoreFailedMessagesForTestsOnly(new[] { failedMessage });
+            await PersistenceTestsContext.InsertFailedMessages(failedMessage);
             return failedMessage;
         }
     }

src/ServiceControl.Persistence.Tests/Recoverability/RetryConfirmationProcessorTests.cs

@@ -25,7 +25,7 @@ public async Task Setup()
 
             Handler = new LegacyMessageFailureResolvedHandler(ErrorMessageDataStore, domainEvents);
 
-            await ErrorMessageDataStore.StoreFailedMessagesForTestsOnly(
+            await PersistenceTestsContext.InsertFailedMessages(
                 new FailedMessage
                 {
                     Id = MessageId,

src/ServiceControl.Persistence.Tests/Recoverability/ReturnToSenderDequeuerTests.cs

@@ -243,8 +243,6 @@ public Task<QueryResult<IList<FailedMessageView>>> ErrorsByEndpointName(string s
 
             public Task<byte[]> FetchFromFailedMessage(string bodyId) => Task.FromResult(Encoding.UTF8.GetBytes(bodyId));
             public Task StoreEventLogItem(EventLogItem logItem) => throw new NotImplementedException();
-
-            public Task StoreFailedMessagesForTestsOnly(params FailedMessage[] failedMessages) => throw new NotImplementedException();
         }
     }
 }

src/ServiceControl.Persistence.Tests/RetryStateTests.cs

@@ -254,7 +254,7 @@ public async Task When_a_selection_is_staged_each_message_is_audited_as_a_batch(
                 ]
             }).ToArray();
 
-            await ErrorStore.StoreFailedMessagesForTestsOnly(messages);
+            await PersistenceTestsContext.InsertFailedMessages(messages);
             await CompleteDatabaseOperation();
 
             var gateway = new CustomRetriesGateway(true, RetryStore, retryManager);
@@ -342,7 +342,7 @@ async Task CreateAFailedMessageAndMarkAsPartOfRetryBatch(RetryingManager retryMa
                 ]
             }).ToArray();
 
-            await ErrorStore.StoreFailedMessagesForTestsOnly(messages);
+            await PersistenceTestsContext.InsertFailedMessages(messages);
 
             // Needs index FailedMessages_ByGroup
             // Needs index FailedMessages_UniqueMessageIdAndTimeOfFailures

src/ServiceControl.Persistence/IErrorMessageDatastore.cs

@@ -71,7 +71,5 @@ public interface IErrorMessageDataStore
 
         // AuditEventLogWriter
         Task StoreEventLogItem(EventLogItem logItem);
-
-        Task StoreFailedMessagesForTestsOnly(params FailedMessage[] failedMessages);
     }
 }

src/ServiceControl.UnitTests/MessageFailures/AsyncRangeAndQueueAuditTests.cs

@@ -192,6 +192,5 @@ internal sealed class StubErrorMessageDataStore : IErrorMessageDataStore
         public Task RevertRetry(string messageUniqueId) => throw new NotImplementedException();
         public Task<byte[]> FetchFromFailedMessage(string uniqueMessageId) => throw new NotImplementedException();
         public Task StoreEventLogItem(EventLogItem logItem) => throw new NotImplementedException();
-        public Task StoreFailedMessagesForTestsOnly(params FailedMessage[] failedMessages) => throw new NotImplementedException();
     }
 }

src/ServiceControl.UnitTests/MessageFailures/EditFailedMessagesControllerAuditTests.cs

@@ -97,6 +97,5 @@ sealed class StubErrorMessageDataStore : IErrorMessageDataStore
         public Task<string[]> GetRetryPendingMessages(DateTime from, DateTime to, string queueAddress) => throw new NotImplementedException();
         public Task<byte[]> FetchFromFailedMessage(string uniqueMessageId) => throw new NotImplementedException();
         public Task StoreEventLogItem(EventLogItem logItem) => throw new NotImplementedException();
-        public Task StoreFailedMessagesForTestsOnly(params FailedMessage[] failedMessages) => throw new NotImplementedException();
     }
 }