invoking retrieveCookie(NamespacedKey) with the same namespace twice deletes the first retrive from the map, resulting in kicks

[Outfluencer]

Expected behavior

When calling retrieveCookie(NamespacedKey) twice, both futures should be completed and the client should not be kicked.

Currently

@Override
public void handleCookieResponse(ServerboundCookieResponsePacket packet) {
    if (this.paperConnection().handleCookieResponse(packet)) return; // Paper
    this.disconnect(DISCONNECT_UNEXPECTED_QUERY, io.papermc.paper.connection.DisconnectionReason.INVALID_COOKIE); // Paper - kick event cause
}

kicks the player.

Because the second retrieveCookie call overrides the first because its a map, then when both cookies arrive the last one is not handled

Paper/paper-server/src/main/java/io/papermc/paper/connection/ReadablePlayerCookieConnectionImpl.java

Line 19 in 37dc545

private final Map<Identifier, CookieFuture> requestedCookies = new ConcurrentHashMap<>();

Observed/Actual behavior

Kick for Component.translatable("multiplayer.disconnect.unexpected_query_response")

Steps/models to reproduce

retriving the same cookie twice directly

Plugin and Datapack List

Paper version

latest

Other

No response

[electronicboy]

The issue here is that there is no transactional mechanism, I guess we could back it up with a List or something but it's not like there would be any real transactionality here

[Outfluencer]

The client always directly responses to the packets, so you can assume that the first retrive will be responded to first, also tcp garantees that the packet order is always correct. i'd just do it like the original impl in bungee has done it

[Outfluencer]

Otherwise you could do a list and always iterate over it

[electronicboy]

I was basically just thinking Map<K, ArrayDeque<>> or something, generally prefer to avoid referring to software with restrictive licensing for legal reasons

[Outfluencer]

Map<K, ArrayDeque<>> would also be okay both should work fine

generally prefer to avoid referring to software with restrictive licensing for legal reasons

Don't really understand whats the problem here, as this project litrally is a spigot fork. And spigot just contains bungeecord code

[electronicboy]

it contains the library, not the code; BungeeCord is ARR, it's code would be a violation of this and craft/bukkits license

(This is probably technically still a problem, just one we can't really navigate out of without breaking stuff)