From 63c10644c763379944905955f5941cd46bdc48a3 Mon Sep 17 00:00:00 2001 From: Ramon Roche Date: Wed, 24 Jun 2026 08:53:50 -0700 Subject: [PATCH] Fix weekly sweep masking conflict-check exit code The full-file check piped through `tee`, but the step ran under the default `bash -e` shell without pipefail, so the pipeline took tee's exit code (0) and the failing check was reported as success. This is the same silent-failure class the check itself was meant to catch: the manual dispatch printed the id-88 conflict yet the job passed and no issue was filed. Set `shell: bash` so the step runs with pipefail. --- .github/workflows/weekly_board_conflicts.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/weekly_board_conflicts.yaml b/.github/workflows/weekly_board_conflicts.yaml index c6c96a38a4..96422eabb1 100644 --- a/.github/workflows/weekly_board_conflicts.yaml +++ b/.github/workflows/weekly_board_conflicts.yaml @@ -21,6 +21,9 @@ jobs: - name: Run full-file conflict check id: check + # shell: bash runs with -o pipefail so the script's exit code is not + # masked by `tee` in the pipeline. + shell: bash run: ./Tools/check_board_types_conflicts.sh | tee conflict_output.txt # If the sweep failed, open a tracking issue or append to the existing