Update t client.sh - #33
Open
flichtenheld wants to merge 4 commits into
Open
Conversation
* Applies the the shfmt format changes * Applies some fixes done due to code review This is the state of https://gerrit.openvpn.net/c/openvpn/+/1882/1 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Now that we check the actual error message I discovered that some of the tests were failing for unrelated reasons. And some were matching for wrong strings. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
This avoids one case where we needed to change the server.conf file on provisioning, creating an unclean git checkout. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
That installs mbedTLS 2.28, which is not supported by current openvpn. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
flichtenheld
force-pushed
the
update-t_client.sh
branch
from
August 28, 2026 15:30
2e63764 to
1a88890
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the OpenVPN “t_server / t_client” testbed harness, primarily improving client test runner behavior around expected failures and refactoring how peer-fingerprint configuration is generated/consumed.
Changes:
- Refactors
t_client.shcontrol flow and output handling, and introduces new failure exit codes for “expected failure did not match”. - Moves the
tun-udp-p2mp-hash-defscriptpeer-fingerprint block to a generated include file (fp.conf) and wires the server config to include it. - Adjusts a few test expectations/configs and updates the orchestration script to treat new failure return codes as test failures.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| t_server/tofu/modules/tserver_user_data/provision/install-openvpn-build-deps-rhel-9.sh | Adjusts RHEL9 build dependency installation list. |
| t_server/tofu/modules/tserver_user_data/provision/28-setup-test-dependencies.sh | Generates peer-fingerprint config file dynamically during provisioning. |
| t_server/original/t_server/tun-udp-p2mp-hash-defscript/server.conf | Includes generated fp.conf instead of inline empty <peer-fingerprint> block. |
| t_server/original/t_server/tun-udp-p2mp-hash-defscript/.gitignore | Ignores the generated fp.conf. |
| t_server/original/run_t_clients.sh | Treats additional client return codes as test failures. |
| t_server/original/client_vm/t_client.master/t_client.rc | Updates specific test configs/expected failure strings and key/cert selection. |
| t_server/original/client_vm/bin/t_client.sh | Refactors formatting/logic and tightens expected-failure detection behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
uddr
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.