fix(core): map an unresolved iri to None instead of omitting it

oold types ResolveResult.nodes as Dict[str, Union[None, ...]] and indexes
it by iri in three places without checking for the key, so omitting an
unresolved iri turns a skipped page into a KeyError.

Author: LukasGold

src/osw/core.py

@@ -280,7 +280,9 @@ def resolve(self, request: ResolveParam):
                     entity = entities_by_title.get(iri)
                     if entity is None:
                         _logger.warning(f"Could not resolve iri '{iri}'")
-                        continue
+                    # ResolveResult.nodes is typed Dict[str, Union[None, ...]],
+                    # and oold indexes it by iri without checking for the key,
+                    # so an unresolved iri has to be present and None
                     nodes[iri] = entity
                 return ResolveResult(nodes=nodes)
 

tests/test_load_entity_result_shape.py

@@ -81,8 +81,12 @@ def _stub_load_entity(self, param):
         ResolveParam(iris=["Item:OSWAlignBad", "Item:OSWAlignGood"])
     )
 
-    assert result.nodes == {"Item:OSWAlignGood": good}
-    assert "Item:OSWAlignBad" not in result.nodes
+    # ResolveResult validates its values, which copies the entity, so compare
+    # by equality rather than by identity
+    assert result.nodes["Item:OSWAlignGood"] == good
+    # oold indexes nodes by iri without checking for the key, and types the
+    # values as Union[None, ...], so an unresolved iri maps to None
+    assert result.nodes["Item:OSWAlignBad"] is None
 
 
 def test_resolve_returns_all_entities_when_every_iri_resolves(monkeypatch):