Skip to content

Commit c151d85

Browse files
committed
arm64: drop stray SBGEMM P/Q/R undefs picked up by other cpu blocks
The edit that added the SBGEMM P/Q/R overrides to the VORTEXM4 block matched on the SBGEMM UNROLL undef lines, which occur in several other cpu blocks as well, so the undefs landed in four of them and broke their setparam compilation under DYNAMIC_ARCH (SBGEMM_DEFAULT_P undeclared, e.g. for NEOVERSEV1 with GCC). This is what the review comment about unrelated cpus was about; the overrides themselves were already dropped in 0bc31e8.
1 parent 0bc31e8 commit c151d85

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

‎param.h‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3285,9 +3285,6 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
32853285

32863286
#undef SBGEMM_DEFAULT_UNROLL_M
32873287
#undef SBGEMM_DEFAULT_UNROLL_N
3288-
#undef SBGEMM_DEFAULT_P
3289-
#undef SBGEMM_DEFAULT_Q
3290-
#undef SBGEMM_DEFAULT_R
32913288
#define SBGEMM_DEFAULT_UNROLL_M 8
32923289
#define SBGEMM_DEFAULT_UNROLL_N 8
32933290

@@ -3349,9 +3346,6 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
33493346

33503347
#undef SBGEMM_DEFAULT_UNROLL_M
33513348
#undef SBGEMM_DEFAULT_UNROLL_N
3352-
#undef SBGEMM_DEFAULT_P
3353-
#undef SBGEMM_DEFAULT_Q
3354-
#undef SBGEMM_DEFAULT_R
33553349
#define SBGEMM_DEFAULT_UNROLL_M 16
33563350
#define SBGEMM_DEFAULT_UNROLL_N 8
33573351

@@ -3860,9 +3854,6 @@ is a big desktop or server with abundant cache rather than a phone or embedded d
38603854
#undef SBGEMM_ALIGN_K
38613855
#undef SBGEMM_DEFAULT_UNROLL_M
38623856
#undef SBGEMM_DEFAULT_UNROLL_N
3863-
#undef SBGEMM_DEFAULT_P
3864-
#undef SBGEMM_DEFAULT_Q
3865-
#undef SBGEMM_DEFAULT_R
38663857
#define SBGEMM_ALIGN_K 4
38673858
#define SBGEMM_DEFAULT_UNROLL_M 8
38683859
#define SBGEMM_DEFAULT_UNROLL_N 4
@@ -3921,9 +3912,6 @@ is a big desktop or server with abundant cache rather than a phone or embedded d
39213912
#undef SBGEMM_ALIGN_K
39223913
#undef SBGEMM_DEFAULT_UNROLL_M
39233914
#undef SBGEMM_DEFAULT_UNROLL_N
3924-
#undef SBGEMM_DEFAULT_P
3925-
#undef SBGEMM_DEFAULT_Q
3926-
#undef SBGEMM_DEFAULT_R
39273915
#define SBGEMM_ALIGN_K 4
39283916
#define SBGEMM_DEFAULT_UNROLL_M 8
39293917
#define SBGEMM_DEFAULT_UNROLL_N 8

0 commit comments

Comments
 (0)