From c783f9733749e1cdc18b9b16a8a06c97cd5cf58c Mon Sep 17 00:00:00 2001 From: Doug Lance <4741454+douglance@users.noreply.github.com> Date: Thu, 1 May 2025 12:18:41 -0400 Subject: [PATCH 1/4] test logging --- run-nitro-test-node/action.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index 2b0d5a7..0b20b6b 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -57,20 +57,32 @@ runs: export TOKEN_BRIDGE_BRANCH="${{ inputs.token-bridge-branch }}" fi + # Send all node output to a temp log while still running in background + LOG_FILE="$RUNNER_TEMP/nitro.log" ./test-node.bash --init ${{ inputs.no-simple == 'true' && '--no-simple' || '' }} \ ${{ inputs.l3-node == 'true' && '--l3node' || '' }} \ ${{ inputs.no-token-bridge == 'true' && '--no-tokenbridge' || '--tokenbridge' }} \ ${{ inputs.l3-node == 'true' && inputs.no-l3-token-bridge != 'true' && '--l3-token-bridge' || '' }} \ - ${{ inputs.args }} & + ${{ inputs.args }} 2>&1 | tee -a "$LOG_FILE" & - name: Wait for nitro startup shell: bash - run: ${{ github.action_path }}/waitForNitro.sh 8547 + run: | + LOG_FILE="$RUNNER_TEMP/nitro.log" + tail -f "$LOG_FILE" & + TAIL_PID=$! + ${{ github.action_path }}/waitForNitro.sh 8547 + kill $TAIL_PID - name: Wait for L3 startup if: ${{ inputs.l3-node == 'true' }} shell: bash - run: ${{ github.action_path }}/waitForNitro.sh 3347 + run: | + LOG_FILE="$RUNNER_TEMP/nitro.log" + tail -f "$LOG_FILE" & + TAIL_PID=$! + ${{ github.action_path }}/waitForNitro.sh 3347 + kill $TAIL_PID - name: Wait for token bridge deployment if: ${{ inputs.no-token-bridge != 'true' }} From d88da36c1d000bf0d4cf2998b2aa2e0e642bf1cb Mon Sep 17 00:00:00 2001 From: Doug Lance <4741454+douglance@users.noreply.github.com> Date: Thu, 1 May 2025 12:55:48 -0400 Subject: [PATCH 2/4] try adding deps --- run-nitro-test-node/action.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index 0b20b6b..3d2f272 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -34,6 +34,21 @@ inputs: runs: using: "composite" steps: + - name: Install GLIBC dependencies + shell: bash + run: | + sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test + sudo apt-get update + sudo apt-get install -y libc6 + + - name: Install Foundry + shell: bash + run: | + curl -L https://foundry.paradigm.xyz | bash + export PATH="$PATH:$HOME/.foundry/bin" + foundryup + echo "$HOME/.foundry/bin" >> $GITHUB_PATH + - name: Checkout uses: actions/checkout@v4 with: From 08bcd6d38c1245d378648d58e0f9ab8f3d6c9487 Mon Sep 17 00:00:00 2001 From: Doug Lance <4741454+douglance@users.noreply.github.com> Date: Thu, 1 May 2025 13:05:58 -0400 Subject: [PATCH 3/4] fix --- run-nitro-test-node/action.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index 3d2f272..872da38 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -41,14 +41,6 @@ runs: sudo apt-get update sudo apt-get install -y libc6 - - name: Install Foundry - shell: bash - run: | - curl -L https://foundry.paradigm.xyz | bash - export PATH="$PATH:$HOME/.foundry/bin" - foundryup - echo "$HOME/.foundry/bin" >> $GITHUB_PATH - - name: Checkout uses: actions/checkout@v4 with: From debbdeaf0c6f30b20f5b47d99c6d5f4b2c2803f8 Mon Sep 17 00:00:00 2001 From: Doug Lance <4741454+douglance@users.noreply.github.com> Date: Mon, 5 May 2025 11:57:43 -0400 Subject: [PATCH 4/4] remove unnecessary deps --- run-nitro-test-node/action.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index 872da38..0b20b6b 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -34,13 +34,6 @@ inputs: runs: using: "composite" steps: - - name: Install GLIBC dependencies - shell: bash - run: | - sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test - sudo apt-get update - sudo apt-get install -y libc6 - - name: Checkout uses: actions/checkout@v4 with: