From 7d2a1aeaccedebb912231868839ef6de1cc5ece6 Mon Sep 17 00:00:00 2001 From: spsjvc Date: Tue, 15 Oct 2024 12:42:21 +0200 Subject: [PATCH 1/3] feat(testnode): add debug mode --- run-nitro-test-node/action.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index 2b0d5a7..fc157cf 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -31,6 +31,10 @@ inputs: token-bridge-branch: required: false description: "The token-bridge-contracts branch to use" + debug: + required: false + default: "false" + description: "Whether to run the testnode in debug mode" runs: using: "composite" steps: @@ -44,7 +48,8 @@ runs: - name: Start background nitro-testnode test-node.bash shell: bash - # Currently, you can't run parallel steps, so we add the "&" to run this step in the background + # Currently, you can't run parallel steps, so we add the "&" at the very end to run this step in the background. + # When debug mode is enabled, the testnode will run in the foreground, enabling you to see the output. # # See https://stackoverflow.com/a/72203688 for more info run: | @@ -61,7 +66,8 @@ runs: ${{ inputs.l3-node == 'true' && '--l3node' || '' }} \ ${{ inputs.no-token-bridge == 'true' && '--no-tokenbridge' || '--tokenbridge' }} \ ${{ inputs.l3-node == 'true' && inputs.no-l3-token-bridge != 'true' && '--l3-token-bridge' || '' }} \ - ${{ inputs.args }} & + ${{ inputs.args }} \ + ${{ inputs.debug == 'true' && '' || '&' }} - name: Wait for nitro startup shell: bash From 59b8be9358accca6ec8de9932352e362cc56f796 Mon Sep 17 00:00:00 2001 From: spsjvc Date: Tue, 15 Oct 2024 12:51:44 +0200 Subject: [PATCH 2/3] sigh --- run-nitro-test-node/action.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index fc157cf..5e4ad5f 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -66,8 +66,7 @@ runs: ${{ inputs.l3-node == 'true' && '--l3node' || '' }} \ ${{ inputs.no-token-bridge == 'true' && '--no-tokenbridge' || '--tokenbridge' }} \ ${{ inputs.l3-node == 'true' && inputs.no-l3-token-bridge != 'true' && '--l3-token-bridge' || '' }} \ - ${{ inputs.args }} \ - ${{ inputs.debug == 'true' && '' || '&' }} + ${{ inputs.args }} - name: Wait for nitro startup shell: bash From 515ac95d10a43efbe7da8c4962a18af1481a6166 Mon Sep 17 00:00:00 2001 From: spsjvc Date: Tue, 15 Oct 2024 13:08:04 +0200 Subject: [PATCH 3/3] test --- run-nitro-test-node/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run-nitro-test-node/action.yml b/run-nitro-test-node/action.yml index 5e4ad5f..251efb6 100644 --- a/run-nitro-test-node/action.yml +++ b/run-nitro-test-node/action.yml @@ -19,7 +19,7 @@ inputs: description: "Additional args that can be supplied to the test node script" nitro-testnode-ref: required: false - default: "release" + default: "v3.2.1-d81324d" description: "The nitro-testnode branch to use" l3-node: required: false