From 2195ae1c1162b51ce963f92f8231a0a90f1d081f Mon Sep 17 00:00:00 2001 From: Omar Ibrahim Date: Thu, 13 Aug 2026 11:02:10 -0500 Subject: [PATCH] fix(commons): set changeSummary on constructed model versions The schema added ModelVersion.changeSummary but nothing in src ever referenced it, so every hand-built ModelVersionEntity was missing a required field and check-types failed across five files. --- .../model-additional-file/model-additional-file.service.spec.ts | 1 + .../modules/model-version-tag/model-version-tag.service.spec.ts | 1 + .../modules/model-version/domain/model-version.domain.spec.ts | 2 ++ .../src/modules/model-version/domain/model-version.domain.ts | 1 + .../src/modules/model-version/model-version.service.spec.ts | 1 + 5 files changed, 6 insertions(+) diff --git a/apps/modeling-commons-backend/src/modules/model-additional-file/model-additional-file.service.spec.ts b/apps/modeling-commons-backend/src/modules/model-additional-file/model-additional-file.service.spec.ts index 99066b4d..d64bfd62 100644 --- a/apps/modeling-commons-backend/src/modules/model-additional-file/model-additional-file.service.spec.ts +++ b/apps/modeling-commons-backend/src/modules/model-additional-file/model-additional-file.service.spec.ts @@ -18,6 +18,7 @@ function makeVersion(overrides: Partial = {}): ModelVersionE previewImageFileKey: null, netlogoFileKey: '2026/04/17/abcd-model.nlogox', netlogoVersion: null, + changeSummary: null, infoTab: null, createdAt: new Date(), finalizedAt: null, diff --git a/apps/modeling-commons-backend/src/modules/model-version-tag/model-version-tag.service.spec.ts b/apps/modeling-commons-backend/src/modules/model-version-tag/model-version-tag.service.spec.ts index 4ce7025c..7c40d31e 100644 --- a/apps/modeling-commons-backend/src/modules/model-version-tag/model-version-tag.service.spec.ts +++ b/apps/modeling-commons-backend/src/modules/model-version-tag/model-version-tag.service.spec.ts @@ -18,6 +18,7 @@ function makeVersion(overrides: Partial = {}): ModelVersionE previewImageFileKey: null, netlogoFileKey: 'files/key-1', netlogoVersion: null, + changeSummary: null, infoTab: null, createdAt: new Date(), finalizedAt: null, diff --git a/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.spec.ts b/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.spec.ts index 31362af7..4d4c61eb 100644 --- a/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.spec.ts +++ b/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.spec.ts @@ -30,6 +30,7 @@ describe('modelVersionDomain', () => { previewImageFileKey: null, netlogoFileKey: 'f1', netlogoVersion: null, + changeSummary: null, infoTab: null, createdAt: new Date(), finalizedAt: null, @@ -46,6 +47,7 @@ describe('modelVersionDomain', () => { previewImageFileKey: null, netlogoFileKey: 'f1', netlogoVersion: null, + changeSummary: null, infoTab: null, createdAt: new Date(), finalizedAt: new Date(), diff --git a/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.ts b/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.ts index 78869c50..2a4360b4 100644 --- a/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.ts +++ b/apps/modeling-commons-backend/src/modules/model-version/domain/model-version.domain.ts @@ -19,6 +19,7 @@ export default function modelVersionDomain() { previewImageFileKey: props.previewImageFileKey ?? null, netlogoFileKey: props.netlogoFileKey, netlogoVersion: null, + changeSummary: null, infoTab: null, createdAt: new Date(), finalizedAt: null, diff --git a/apps/modeling-commons-backend/src/modules/model-version/model-version.service.spec.ts b/apps/modeling-commons-backend/src/modules/model-version/model-version.service.spec.ts index 3b1fb6b2..4b67d226 100644 --- a/apps/modeling-commons-backend/src/modules/model-version/model-version.service.spec.ts +++ b/apps/modeling-commons-backend/src/modules/model-version/model-version.service.spec.ts @@ -20,6 +20,7 @@ function makeVersion(overrides: Partial = {}): ModelVersionE previewImageFileKey: null, netlogoFileKey: '2026/04/17/abcd-model.nlogox', netlogoVersion: null, + changeSummary: null, infoTab: null, createdAt: new Date(), finalizedAt: null,