feat(windows): vite HMR livesync, comment cleanup

Windows livesync now hot-refreshes a running app when the bundler is vite
with HMR on, and still launches it on the first sync. Adds windows to the
bundler's user project platforms and drops a stale app.nsbundle on dev
builds.

Author: triniwiz

README.md

@@ -99,7 +99,7 @@ With the NativeScript CLI, you can target the following platforms.
 
 * Android 4.2 or a later stable official release
 * iOS 9.0 or later stable official release
-* Windows 10 version 1809 (build 17763) or later — via `@nativescript/windows`
+* Windows 10 version 1809 (build 17763) or later. Via `@nativescript/windows`
 
 [Back to Top][1]
 
@@ -314,7 +314,7 @@ After you have listed the available devices, you can quickly run your app by exe
 ```Shell
 ns run android
 ns run ios
-ns run windows   # Windows only — runs on the local machine
+ns run windows   # Windows only. Runs on the local machine
 ```
 
 [Back to Top][1]

docs/man_pages/project/testing/debug-windows.md

@@ -7,7 +7,7 @@ position: 7
 
 ### Description
 
-Initiates a debugging session for your project on the local Windows machine. When necessary, the command will prepare, build, deploy and launch the app before starting the debug session. The NativeScript runtime starts a Chrome DevTools Protocol server on port 9229 — attach Chrome DevTools or any CDP-compatible debugger to `ws://localhost:9229`.
+Initiates a debugging session for your project on the local Windows machine. When necessary, the command will prepare, build, deploy and launch the app before starting the debug session. The NativeScript runtime starts a Chrome DevTools Protocol server on port 9229. Attach Chrome DevTools or any CDP-compatible debugger to `ws://localhost:9229`.
 
 <% if(isConsole && (isLinux || isMacOS)) { %>WARNING: You can run this command only on Windows systems. To view the complete help for this command, run `$ ns help debug windows`<% } %>
 <% if((isConsole && isWindows) || isHtml) { %>
@@ -45,7 +45,7 @@ Attach the debug tools to a running app | `$ ns debug windows --start [--timeout
 1. Run `ns debug windows`
 2. Open Chrome and navigate to `chrome://inspect`
 3. Under **Devices**, click **Configure** and add `localhost:9229`
-4. The NativeScript runtime will appear under **Remote Target** — click **inspect**
+4. The NativeScript runtime will appear under **Remote Target**. Click **inspect**
 
 ### Command Limitations
 

lib/commands/build.ts

@@ -331,7 +331,7 @@ export class BuildWindowsCommand extends BuildCommandBase implements ICommand {
 		let canExecute = await super.canExecuteCommandBase(platform);
 		if (canExecute) {
 			// A sideload release package without signing material can be produced,
-			// but it won't be installable until signed — warn rather than fail.
+			// but it won't be installable until signed. Warn rather than fail.
 			if (
 				this.$options.release &&
 				!this.$options.storeUpload &&

lib/common/mobile/windows/windows-application-manager.ts

@@ -98,23 +98,23 @@ export class WindowsApplicationManager extends ApplicationManagerBase {
 		}
 		// Two distinct artifact shapes reach here (see WindowsProjectService's
 		// getValidBuildOutputData): a debug build resolves to the loose bin/ output's
-		// AppxManifest.xml, meant for `-Register` (in-place dev registration — no signature
+		// AppxManifest.xml, meant for `-Register` (in-place dev registration; no signature
 		// validation, matches "AppxManifest.xml triggers Add-AppxPackage -Register (dev flow)");
 		// a release build resolves to the packaged .msix/.msixupload under AppPackages/, which
 		// `-Register` rejects outright ("An invalid manifest file name was passed to this
-		// function") and which instead needs a plain package install via `-Path` — exactly what
+		// function") and which instead needs a plain package install via `-Path`. Exactly what
 		// the generated Install.ps1/Add-AppDevPackage.ps1 next to it do. A `-Path` install of an
 		// unsigned release package still fails signature validation (0x800B0100); that's expected
-		// — pass `--certificate`/`--certificate-thumbprint` at build time for a sideloadable
+		// pass `--certificate`/`--certificate-thumbprint` at build time for a sideloadable
 		// release package, this isn't something the install step can paper over.
 		const isLooseManifest = packageFilePath.toLowerCase().endsWith("appxmanifest.xml");
 		let addAppxCommand: string;
 		if (isLooseManifest) {
 			addAppxCommand = `Add-AppxPackage -ForceApplicationShutdown -Register -Path "${packageFilePath}"`;
 		} else {
 			// Thread through any Dependencies\<arch>\*.msix (e.g. the Windows App SDK runtime
-			// framework package) the same way Add-AppDevPackage.ps1 does via `-DependencyPath` —
-			// needed on a machine that doesn't already have that framework package installed.
+			// framework package) the same way Add-AppDevPackage.ps1 does via `-DependencyPath`.
+			// Needed on a machine that doesn't already have that framework package installed.
 			const arch = process.arch === "arm64" ? "arm64" : "x64";
 			const dependencyDir = path.join(path.dirname(packageFilePath), "Dependencies", arch);
 			const dependencyGlob = path.join(dependencyDir, "*.msix");
@@ -176,7 +176,7 @@ export class WindowsApplicationManager extends ApplicationManagerBase {
 	 * The runtime writes console.log to ApplicationData.LocalFolder (LocalState), alongside the
 	 * crash/panic/lastcalls logs. NOTE: earlier builds assumed a UWP app's GetTempPathW() virtualises
 	 * to AC\Temp, but the app is `runFullTrust` (not an app container), so GetTempPathW() resolves to
-	 * the *system* temp — which is neither AC\Temp nor a path the CLI could reliably find. The runtime
+	 * the *system* temp, which is neither AC\Temp nor a path the CLI could reliably find. The runtime
 	 * now targets LocalState explicitly (runtime_set_local_folder → set_log_dir), so pin that here.
 	 * Falls back to the system temp path when no PFN is known (unpackaged EXE).
 	 */
@@ -230,7 +230,7 @@ export class WindowsApplicationManager extends ApplicationManagerBase {
 		// Truncate the trace log so the streamer starts from a clean state each run.
 		try {
 			fs.writeFileSync(this.getLogFilePath(), "", "utf8");
-		} catch { /* ignore — log dir may not exist yet */ }
+		} catch { /* ignore: log dir may not exist yet */ }
 
 		if (isExe) {
 			if (appData.waitForDebugger) {

lib/common/mobile/windows/windows-device-file-system.ts

@@ -102,7 +102,7 @@ export class WindowsDeviceFileSystem implements Mobile.IDeviceFileSystem {
 		_hashes: IStringDictionary,
 		_appIdentifier: string,
 	): Promise<void> {
-		// no-op — Windows LiveSync does not use hash-based diffing yet
+		// no-op: Windows LiveSync does not use hash-based diffing yet
 	}
 
 	public getDeviceHashService(_appIdentifier: string): any {

lib/common/mobile/windows/windows-device.ts

@@ -56,7 +56,7 @@ export class WindowsDevice implements Mobile.IDevice {
 		}
 
 		// For packaged UWP apps, GetTempPath() inside the app container resolves to
-		// %LOCALAPPDATA%\Packages\<PFN>\TempState — not the system temp dir.
+		// %LOCALAPPDATA%\Packages\<PFN>\TempState: not the system temp dir.
 		// Ask the application manager for the correct path based on the known PFN.
 		const manager = this.applicationManager as WindowsApplicationManager;
 		const logPath = manager.getLogFilePath();
@@ -73,7 +73,7 @@ export class WindowsDevice implements Mobile.IDevice {
 		// Rotate the log if it exceeds 10 MB to prevent unbounded disk growth.
 		const MAX_LOG_BYTES = 10 * 1024 * 1024;
 
-		// Internal Rust runtime diagnostics written via debug_output() — useful in
+		// Internal Rust runtime diagnostics written via debug_output(). Useful in
 		// VS Output / DebugView but noisy in the CLI. Suppress them; errors/exceptions
 		// are kept because their prefix contains "error", "exception", or "PANIC".
 		const INTERNAL_PREFIXES = [
@@ -106,11 +106,11 @@ export class WindowsDevice implements Mobile.IDevice {
 				if (stat.size > MAX_LOG_BYTES) {
 					try { fs.writeFileSync(logPath, "", "utf8"); offset = 0; } catch { /* ignore */ }
 				}
-			} catch { /* ignore — file may not exist between app restarts */ }
+			} catch { /* ignore: file may not exist between app restarts */ }
 		}, 50);
 
 		// Also tail nativescript-crash.log from LocalState so C# exception reports
-		// and JS errors caught by the host surface in the CLI — same as Android/iOS
+		// and JS errors caught by the host surface in the CLI. Same as Android/iOS
 		// crash log streaming. Truncate on each run so only errors from this session appear.
 		if (crashLogPath) {
 			try { fs.writeFileSync(crashLogPath, "", "utf8"); } catch { /* may not exist yet */ }
@@ -134,7 +134,7 @@ export class WindowsDevice implements Mobile.IDevice {
 							this.$deviceLogProvider.logData(`[crash] ${line}`, "Windows", deviceId);
 						}
 					}
-				} catch { /* ignore — file may not exist until first crash */ }
+				} catch { /* ignore: file may not exist until first crash */ }
 			}, 50);
 		}
 	}

lib/device-path-provider.ts

@@ -62,7 +62,7 @@ export class DevicePathProvider implements IDevicePathProvider {
 				if (options.getDirname) {
 					return buildOutputPath;
 				}
-				// Sync into bin\app — the registered package root — so the running app
+				// Sync into bin\app (the registered package root) so the running app
 				// picks up changes without a rebuild.
 				return path.join(buildOutputPath, APP_FOLDER_NAME);
 			}

lib/services/bundler/bundler-compiler-service.ts

@@ -597,6 +597,7 @@ export class BundlerCompilerService
 				USER_PROJECT_PLATFORMS_ANDROID_MODULE:
 					this.$options.hostProjectModuleName,
 				USER_PROJECT_PLATFORMS_IOS: this.$options.hostProjectPath,
+				USER_PROJECT_PLATFORMS_WINDOWS: this.$options.hostProjectPath,
 			});
 		}
 

lib/services/livesync/windows-device-livesync-service.ts

@@ -1,4 +1,5 @@
 import * as fs from "fs";
+import { spawnSync } from "child_process";
 import { DeviceLiveSyncServiceBase } from "./device-livesync-service-base";
 import { IPlatformsDataService } from "../../definitions/platform";
 import { IProjectData } from "../../definitions/project";
@@ -39,15 +40,31 @@ export class WindowsDeviceLiveSyncService
 		_projectData: IProjectData,
 		liveSyncInfo: ILiveSyncResultInfo,
 	): Promise<boolean> {
-		return !liveSyncInfo.useHotModuleReload;
+		return !liveSyncInfo.useHotModuleReload || !!liveSyncInfo.waitForDebugger;
 	}
 
 	public async tryRefreshApplication(
-		_projectData: IProjectData,
-		_liveSyncInfo: ILiveSyncResultInfo,
+		projectData: IProjectData,
+		liveSyncInfo: ILiveSyncResultInfo,
 	): Promise<boolean> {
-		// HMR not yet implemented for Windows — signal full restart
-		return false;
+		// Vite HMR: a running app pulls every change from the dev server over its WebSocket
+		// (HTTP ES modules), so a synced file never needs a restart. But an app that isn't
+		// running yet (first sync after install) must still be launched. Webpack HMR isn't
+		// implemented for Windows: signal a restart.
+		return (
+			projectData.bundler === "vite" &&
+			!!liveSyncInfo.useHotModuleReload &&
+			this.isAppRunning(projectData.projectName)
+		);
+	}
+
+	private isAppRunning(processName: string): boolean {
+		const result = spawnSync(
+			"tasklist",
+			["/FI", `IMAGENAME eq ${processName}.exe`, "/NH", "/FO", "CSV"],
+			{ encoding: "utf8", windowsHide: true },
+		);
+		return (result.stdout || "").toLowerCase().includes(`"${processName.toLowerCase()}.exe"`);
 	}
 
 	public async removeFiles(

lib/services/project-cleanup-service.ts

@@ -172,7 +172,7 @@ export class ProjectCleanupService implements IProjectCleanupService {
 			try {
 				execSync(`taskkill /F /IM "${name}.exe" /T`, { stdio: "ignore" });
 				this.$logger.trace(`[clean] Killed process: ${name}.exe`);
-			} catch { /* process not running — ignore */ }
+			} catch { /* process not running: ignore */ }
 		}
 	}
 }